From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4692B4240B; Wed, 18 Jan 2023 11:22:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37466400D6; Wed, 18 Jan 2023 11:22:41 +0100 (CET) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by mails.dpdk.org (Postfix) with ESMTP id EC0C24003F for ; Wed, 18 Jan 2023 11:22:39 +0100 (CET) Received: by mail-vs1-f52.google.com with SMTP id 3so35205265vsq.7 for ; Wed, 18 Jan 2023 02:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6ftZda/U3fz+S6/XOwPonI+inOqLAsKmVkE/lfg43P8=; b=MdEaSYKNqHuZFp8fKy9l32yvixPscXIZ1+NNMHpv2XoaSmyWbkgkZhIqNty4NtMEV1 cX+Mk25A6kMfBxlvnju4W8gs2AUHj4oFprSPay8c4Owg6WVVMY/5OPD6TpkStIxPadNd GdFkxUCfsf7hNpoafjkKaw2f1m/gQCHe9pm2cZbfYXDxyVdIVaE3/yMEraGI6LIwHRgV xYTyix0T/viicjAQQ9z/5b3VtbrK1pTbdlnMygam1PCSWh3CoeGDzjvMVzUk0w+rClli 5Szbvl+JkCcxB2cYnmT8nTfdnyBX+hQwV5FBlWvXVTGOucltFlTRNbrLIAgpqRhTMLeZ dglg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6ftZda/U3fz+S6/XOwPonI+inOqLAsKmVkE/lfg43P8=; b=Ma/p1yfO4MCj0ySHvdDtI7mWBtlQXuDuqaVlSyJGfapt7TeFcmyYs/YOzcb5/DxUog 4Pf058IhxNTnI0DmDClzglKS4RbE69Hi4JAOYg2tGJA3nULpWDdfyM0nPW1ugeTqhXQI RuWQSihC86i9dve+lhEJJi04+lBSgSGKPqXvIuDUXPveGHELAWOuG6Xa5Oc8lccm4gca gkenVfk3E6KF5+dgaAypvGuo1EIkhQ87TLj4Nil2ULWx4+bQqkIyX5SDW7qXSNMQ73/d m8hOTeIEFlqwFj/97inKueeuuZVD/yVFi9NxKWQNqXZfuSgdBUS/NogwFStOaHUBu/pV /wqQ== X-Gm-Message-State: AFqh2kpB11RP6ID3NDzXmTjgyWXoVLpfrT6FMYYlAUEs5ZhdKisGDtb0 910hiS8bdc3YZaJNaFrR1uk1x8olLozX0y1hjfs= X-Google-Smtp-Source: AMrXdXs9hOCG0SuXRE5Xk0m3WJPoChcT9yPH4tQ22Noy5iTHl+VjUEjXtLllenl6qQKnoAjVaGv82IBWonQvAbaDafU= X-Received: by 2002:a05:6102:5124:b0:3d3:c7fb:d602 with SMTP id bm36-20020a056102512400b003d3c7fbd602mr873866vsb.31.1674037359264; Wed, 18 Jan 2023 02:22:39 -0800 (PST) MIME-Version: 1.0 References: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> From: Jerin Jacob Date: Wed, 18 Jan 2023 15:52:13 +0530 Message-ID: Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs To: Naga Harish K S V Cc: jerinj@marvell.com, abhinandan.gujjar@intel.com, dev@dpdk.org, jay.jayatheerthan@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 7, 2023 at 9:49 PM Naga Harish K S V wrote: > > The adapter configuration parameters defined in the > ``struct rte_event_eth_rx_adapter_config_params`` can be configured > and retrieved using ``rte_event_eth_rx_adapter_set_params`` and > ``rte_event_eth_tx_adapter_get_params`` respectively. > > Signed-off-by: Naga Harish K S V > --- > > +/** > + * Adapter configuration parameters > + */ > +struct rte_event_eth_rx_adapter_runtime_params { > + uint32_t max_nb_rx; > + /**< The adapter can return early if it has processed at least > + * max_nb_rx mbufs. This isn't treated as a requirement; batching may > + * cause the adapter to process more than max_nb_rx mbufs. This parameter as specific to SW only driver. So future something added from HW only driver item then it won't work for SW driver. So we need capability per adapter. So, I would suggest following theme across _all_ adapters. 1) Introduce RTE_EVENT_ETH_RX_ADAPTER_CAP_RUNTIME_XYZ and associate each parameter(the one we think, it is not common for all adapters) 2) Add some reserved fields in rte_event_eth_rx_adapter_runtime_params so that we don't break ABI in future 3) Add rte_event_eth_rx_adapter_runtime_params_init() function just make structure fill with default to avoid ABI break 4) Add rte_event_eth_rx_adapter_runtime_params_info_get(). Lets capability flags and other items can be return via this 5) Change rte_event_eth_rx_adapter_set_params as rte_event_eth_rx_adapter_runtime_set() or rte_event_eth_rx_adapter_runtime_params_set() to make it runtime explicit 6) Change rte_event_eth_rx_adapter_get_params as rte_event_eth_rx_adapter_runtime_get() or rte_event_eth_rx_adapter_runtime_params_get() to make it runtime explicit