From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B866A0548; Sat, 3 Apr 2021 11:51:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99AF1140E24; Sat, 3 Apr 2021 11:51:42 +0200 (CEST) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id 64B0C40696 for ; Sat, 3 Apr 2021 11:51:41 +0200 (CEST) Received: by mail-io1-f46.google.com with SMTP id e8so7508218iok.5 for ; Sat, 03 Apr 2021 02:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=su5il8sIR5F2KR0T3gi2E6nyxO94eGS+DPc9xpNY3SI=; b=DQdbguCEvfQDZoIx/wzikmGuCC1eq2Z8xfEUyEi5jEG4bpag12y8NFs0G3txDG7Dmo yQvnFj9Y50EEfmw8mMjwYjzVN0abM1YJ1HrY2CtiU0W6N0ONR3boN6Jgjz0zm30GRO9b pepP4jH3lGaX2uiz7FXyCSczlyjaKPUmX4XoOB1Bf/8eo03Q/lEgAdCf1XU8z3X2sXgK pYi5do5Hev9swfrP8RTPJGbANXToIUE9e9TFj09iVP/Rcz+i2AHHZ6D5tm3nGAcsc4o1 7NYZNQryw7aoVMqPItr7ulRFesRbSlbtLuJzrk75eHHX1A+ekFZMzOz7n6iFmKsTIq8m aV1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=su5il8sIR5F2KR0T3gi2E6nyxO94eGS+DPc9xpNY3SI=; b=fII77L2BrUA/NUTwVf8ADxpIFdbJbaWMZDseOuXh0me2UDHdXip3UO6uXDvIf5WoS9 UZZB1ycJXeCkUVO7ik09nbyS5xqwaG8aV5/0cCdim9/Biu+HwOUenjEPAQ5/AZngM/u9 5IIg8+P7xJdLyps6eS81jbVotJNxCrerWTiaKgoWw46QKMT7woDvypuPZOUnlmU0UnSy 55E0x1WiQP2P311qu12cQ7YtJ7+ShN8RdH04YIjEX1MvSqYdfpvCGJrmgzgDa7kggv1K CzxrspxCU3QzU0UljWvpARPd+qz2eGcvxOk8dqd4lycFgNPsFhNyIcYlRB6pqFzdClX/ 4+7Q== X-Gm-Message-State: AOAM5319ouy7nSiz9fkmGbiYwXKT68Kf+XyXO+SIfI7mr8yRC0NepRMp 4NPN+Gchj3NFNE/5GjC+ZctUpzTSe+PrClWl3WE= X-Google-Smtp-Source: ABdhPJyWfgW2/Z9prG4gABdMuy68NZDRX8ltVMD1qlKcgOb6PVpSVB7pi94RGMVFz7XsOwiOXQ4PPOkF4EWc5ttIutE= X-Received: by 2002:a02:7f0e:: with SMTP id r14mr15982444jac.112.1617443500666; Sat, 03 Apr 2021 02:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20210316221857.2254-2-timothy.mcdaniel@intel.com> <1617132940-24800-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1617132940-24800-1-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Sat, 3 Apr 2021 15:21:24 +0530 Message-ID: To: Timothy McDaniel Cc: dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" , Jerin Jacob , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add DLB V2.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 31, 2021 at 1:06 AM Timothy McDaniel wrote: > > This patch series adds support for DLB v2.5 to > the current DLB V2.0 PMD. The resulting PMD supports > both hardware versions. > > The main differences between the DLB v2.5 and v2.0 hardware > are: > - Number of queues/ports > - DLB v2.5 uses a combined credit pool, whereas DLB v2.0 > splits credits into 2 pools, a directed credit pool and a > load balanced credit pool. > - Different register maps, with different bit names and offsets Please fix the following issues [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 27 Wrong headline format: event/dlb2: add v2.5 get_resources event/dlb2: delete old dlb2_resource.c file event/dlb2: move dlb_resource_new.c to dlb_resource.c event/dlb2: remove temporary file, dlb_hw_types.h event/dlb2: move dlb2_hw_type_new.h to dlb2_hw_types.h event/dlb2: delete old register map file, dlb2_regs.h event/dlb2: rename dlb2_regs_new.h to dlb2_regs.h event/dlb2: Change device name to dlb_event Wrong headline uppercase: event/dlb2: Change device name to dlb_event ./devtools/checkpatches.sh -n 27 ### event/dlb2: add v2.5 sparse cq mode WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4: Subject: [PATCH] event/dlb2: add v2.5 sparse cq mode WARNING:REPEATED_WORD: Possible repeated word: 'mode' #6: Update sparse cq mode mode functions for DLB v2.5, accounting for new total: 0 errors, 2 warnings, 70 lines checked ### event/dlb2: Change device name to dlb_event WARNING:REPEATED_WORD: Possible repeated word: 'the' #9: to the the directory name that contains the PMD, as well total: 0 errors, 1 warnings, 666 lines checked 22/27 valid patches > > In order to support both hardware versions with the same PMD, > and avoid code duplication, the file dlb2_resource.c required a > complete rewrite. This required some creative staging of the changes > in order to keep the individual patches relatively small, while > also meeting the requirement that all individual patches in the set > compile cleanly. > > To accomplish this, a few temporary files are used: > > dlb2_hw_types_new.h > dlb2_resources_new.h > dlb2_resources_new.c > > As dlb2_resources_new.c is populated with the new combined v2.0/v2.5 > low level logic, the corresponding old code is removed from > dlb2_resource.c, thus allowing both the original and new code to > continue to compile and link cleanly. Once all of the code has been > migrated to the new model, the old versions of the files are removed, > and the new versions are renamed, effectively replacing the old original > files. > > As you review the code, you can ignore the code deletions from > dlb2_resource.c, as that file continues to shrink as the new > corresponding logic is added to dlb2_resource_new.c. > > Changes since V1 > 1) Simplified subject text for all patches > 2) correct typos/spelling > 3) remove FPGA references > 4) remove stale sysconf() references > 5) fixed patches that had compilation issues > 6) updated release notes > 7) renamed dlb device from dlb2_event to dlb_event > 8) moved dlb2 directory to dlb,to match name change > 9) fixed other cases where "dlb2" was being used externally > > Timothy McDaniel (27): > event/dlb2: add v2.5 probe > event/dlb2: add v2.5 HW init > event/dlb2: add v2.5 get_resources > event/dlb2: add v2.5 create sched domain > event/dlb2: add v2.5 domain reset > event/dlb2: add V2.5 create ldb queue > event/dlb2: add v2.5 create ldb port > event/dlb2: add v2.5 create dir port > event/dlb2: add v2.5 create dir queue > event/dlb2: add v2.5 map qid > event/dlb2: add v2.5 unmap queue > event/dlb2: add v2.5 start domain > event/dlb2: add v2.5 credit scheme > event/dlb2: add v2.5 queue depth functions > event/dlb2: add v2.5 finish map/unmap > event/dlb2: add v2.5 sparse cq mode > event/dlb2: add v2.5 sequence number management > event/dlb2: consolidate resource header files into one file > event/dlb2: delete old dlb2_resource.c file > event/dlb2: move dlb_resource_new.c to dlb_resource.c > event/dlb2: remove temporary file, dlb_hw_types.h > event/dlb2: move dlb2_hw_type_new.h to dlb2_hw_types.h > event/dlb2: delete old register map file, dlb2_regs.h > event/dlb2: rename dlb2_regs_new.h to dlb2_regs.h > event/dlb2: update xstats for v2.5 > doc/dlb2: update documentation for v2.5 > event/dlb2: Change device name to dlb_event > > MAINTAINERS | 6 +- > app/test/test_eventdev.c | 6 +- > config/rte_config.h | 11 +- > doc/api/doxy-api-index.md | 2 +- > doc/api/doxy-api.conf.in | 2 +- > doc/guides/eventdevs/dlb.rst | 390 ++ > doc/guides/eventdevs/dlb2.rst | 75 +- > doc/guides/eventdevs/index.rst | 2 +- > doc/guides/rel_notes/release_21_05.rst | 5 + > drivers/event/{dlb2 => dlb}/dlb2.c | 455 +- > drivers/event/{dlb2 => dlb}/dlb2_iface.c | 0 > drivers/event/{dlb2 => dlb}/dlb2_iface.h | 0 > drivers/event/{dlb2 => dlb}/dlb2_inline_fns.h | 0 > drivers/event/{dlb2 => dlb}/dlb2_log.h | 0 > drivers/event/{dlb2 => dlb}/dlb2_priv.h | 163 +- > drivers/event/{dlb2 => dlb}/dlb2_selftest.c | 8 +- > drivers/event/{dlb2 => dlb}/dlb2_user.h | 27 +- > drivers/event/{dlb2 => dlb}/dlb2_xstats.c | 70 +- > drivers/event/{dlb2 => dlb}/meson.build | 4 +- > .../{dlb2 => dlb}/pf/base/dlb2_hw_types.h | 102 +- > .../event/{dlb2 => dlb}/pf/base/dlb2_osdep.h | 3 + > .../{dlb2 => dlb}/pf/base/dlb2_osdep_bitmap.h | 0 > .../{dlb2 => dlb}/pf/base/dlb2_osdep_list.h | 0 > .../{dlb2 => dlb}/pf/base/dlb2_osdep_types.h | 0 > drivers/event/dlb/pf/base/dlb2_regs.h | 4412 +++++++++++++++++ > .../{dlb2 => dlb}/pf/base/dlb2_resource.c | 3278 ++++++------ > .../{dlb2 => dlb}/pf/base/dlb2_resource.h | 28 +- > drivers/event/{dlb2 => dlb}/pf/dlb2_main.c | 37 +- > drivers/event/{dlb2 => dlb}/pf/dlb2_main.h | 0 > drivers/event/{dlb2 => dlb}/pf/dlb2_pf.c | 62 +- > .../rte_pmd_dlb2.c => dlb/rte_pmd_dlb.c} | 6 +- > .../rte_pmd_dlb2.h => dlb/rte_pmd_dlb.h} | 12 +- > drivers/event/{dlb2 => dlb}/version.map | 2 +- > drivers/event/dlb2/pf/base/dlb2_mbox.h | 596 --- > drivers/event/dlb2/pf/base/dlb2_regs.h | 2527 ---------- > drivers/event/meson.build | 2 +- > 36 files changed, 7270 insertions(+), 5023 deletions(-) > create mode 100644 doc/guides/eventdevs/dlb.rst > rename drivers/event/{dlb2 => dlb}/dlb2.c (90%) > rename drivers/event/{dlb2 => dlb}/dlb2_iface.c (100%) > rename drivers/event/{dlb2 => dlb}/dlb2_iface.h (100%) > rename drivers/event/{dlb2 => dlb}/dlb2_inline_fns.h (100%) > rename drivers/event/{dlb2 => dlb}/dlb2_log.h (100%) > rename drivers/event/{dlb2 => dlb}/dlb2_priv.h (79%) > rename drivers/event/{dlb2 => dlb}/dlb2_selftest.c (99%) > rename drivers/event/{dlb2 => dlb}/dlb2_user.h (97%) > rename drivers/event/{dlb2 => dlb}/dlb2_xstats.c (94%) > rename drivers/event/{dlb2 => dlb}/meson.build (89%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_hw_types.h (81%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep.h (99%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_bitmap.h (100%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_list.h (100%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_types.h (100%) > create mode 100644 drivers/event/dlb/pf/base/dlb2_regs.h > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_resource.c (68%) > rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_resource.h (99%) > rename drivers/event/{dlb2 => dlb}/pf/dlb2_main.c (95%) > rename drivers/event/{dlb2 => dlb}/pf/dlb2_main.h (100%) > rename drivers/event/{dlb2 => dlb}/pf/dlb2_pf.c (92%) > rename drivers/event/{dlb2/rte_pmd_dlb2.c => dlb/rte_pmd_dlb.c} (88%) > rename drivers/event/{dlb2/rte_pmd_dlb2.h => dlb/rte_pmd_dlb.h} (88%) > rename drivers/event/{dlb2 => dlb}/version.map (60%) > delete mode 100644 drivers/event/dlb2/pf/base/dlb2_mbox.h > delete mode 100644 drivers/event/dlb2/pf/base/dlb2_regs.h > > -- > 2.23.0 >