From: Jerin Jacob <jerinjacobk@gmail.com>
To: wangyunjian <wangyunjian@huawei.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: remove logically dead code
Date: Sun, 11 Oct 2020 15:19:12 +0530 [thread overview]
Message-ID: <CALBAE1OsKUzuHY7n70sZ+bJKfX+5h1jn6QWLNLzWWYamF2GGAw@mail.gmail.com> (raw)
In-Reply-To: <1602247145-14676-1-git-send-email-wangyunjian@huawei.com>
On Fri, Oct 9, 2020 at 6:09 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The glibc free allows free(NULL) as null operation,
> so remove this useless null checks.
>
> Coverity issue: 357719
> Fixes: da138cd47e06 ("net/octeontx2: handle port reconfigure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
> v2:
> fix code styles suggested by Stephen Hemminger
> ---
> drivers/net/octeontx2/otx2_ethdev.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index 03d81faef..b69b92bf5 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -1383,10 +1383,8 @@ nix_store_queue_cfg_and_then_release(struct rte_eth_dev *eth_dev)
> return 0;
>
> fail:
> - if (tx_qconf)
> - free(tx_qconf);
> - if (rx_qconf)
> - free(rx_qconf);
> + free(tx_qconf);
> + free(rx_qconf);
>
> return -ENOMEM;
> }
> --
> 2.23.0
>
prev parent reply other threads:[~2020-10-11 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:18 [dpdk-dev] [PATCH] " wangyunjian
2020-09-29 18:14 ` Jerin Jacob
2020-09-30 10:34 ` wangyunjian
2020-10-04 8:52 ` Jerin Jacob
2020-09-29 19:57 ` Stephen Hemminger
2020-10-09 12:39 ` [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-11 9:49 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OsKUzuHY7n70sZ+bJKfX+5h1jn6QWLNLzWWYamF2GGAw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerry.lilijun@huawei.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).