From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 188B4A04B6; Sun, 11 Oct 2020 11:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0C511D421; Sun, 11 Oct 2020 11:49:31 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id C446E1BCD5; Sun, 11 Oct 2020 11:49:29 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id u19so14714658ion.3; Sun, 11 Oct 2020 02:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6ovMLuNlECVC6fmJDCW0ilVbhx8o81cvFrZEC11ATx8=; b=LKAA1xZEjaedqiOkI8Ks2yaSQxmDr3g3FXcPDqrJufeRetwV6lKR0Brty1i07qpId0 f4cecQ4Cf0oP+pUi/JbX9s562fyAXdNhqV0hRPrL8LcVaqqLeNSpDaVaNl2Cpk679Hc/ dR78sCaCUJgPuKEJsX+N9O/9mNhGBPn1uPXGVE5gT/cvybkhTqqjk8S/irsrQXsCOFYx rnDt4qJ9eG2YAVsynaMqo/M1ITdKxpysNVX1Bw1pT15YU3MV5DkaT9raL5byG9i3Jq2d tR2Flzqlq1fJ6wyFolUOKJAl+vOWpLTgTrXQ3ZWj7rCLdYimwhmfVmkiGSw6RK6jCmGm 3UmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ovMLuNlECVC6fmJDCW0ilVbhx8o81cvFrZEC11ATx8=; b=cMBSIAvX6Wip3ua5RP6gFVvrf0R/LgU0AbgLxLwEMAJKEEBhHUCrTEcQhK5H3lyyWn M6n+ByeG4wN4x4GsyPhjyvqrFQJozQDsr6t9iLcEQcHNRrudWqXnEYQULrzK9odPmw1B V5BJMsUx/EtewK0lB5JOREswkXMmxapNz3K83fzLm1cvdGsWNFmYLrWsf5IZEPdSQXaO zcSYJYE2cQkf27tzibYUuqeupiUUam56922CsHar9fS0gaQcke9HI5J5FniJOeIEp2Qw gZNxv06o2YN9rAsPkhLd94En6AEnHYMe0EtymtHMviGEvVWMm0gZuW9JCtEH47sFMhnk KmZA== X-Gm-Message-State: AOAM532u6ng+NU6ApByjZRcMURR8RouIaxbDAxc0jmucv6r1CKnk268P VOwQAA17H0xWp4N9opGfB8ajjeCTgColG1c6iak= X-Google-Smtp-Source: ABdhPJzvubmyCItrDDccyc+Kxa1iRm1qDxTTA0b119T539upZjVPh2ZPJ3NYVy2v3ENV2NyRPHCqSB9vpdv0bcWg+pw= X-Received: by 2002:a5d:9615:: with SMTP id w21mr13980469iol.59.1602409768060; Sun, 11 Oct 2020 02:49:28 -0700 (PDT) MIME-Version: 1.0 References: <1602247145-14676-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1602247145-14676-1-git-send-email-wangyunjian@huawei.com> From: Jerin Jacob Date: Sun, 11 Oct 2020 15:19:12 +0530 Message-ID: To: wangyunjian , Ferruh Yigit Cc: dpdk-dev , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Lilijun (Jerry)" , xudingke , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: remove logically dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 9, 2020 at 6:09 PM wangyunjian wrote: > > From: Yunjian Wang > > The glibc free allows free(NULL) as null operation, > so remove this useless null checks. > > Coverity issue: 357719 > Fixes: da138cd47e06 ("net/octeontx2: handle port reconfigure") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > v2: > fix code styles suggested by Stephen Hemminger > --- > drivers/net/octeontx2/otx2_ethdev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c > index 03d81faef..b69b92bf5 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1383,10 +1383,8 @@ nix_store_queue_cfg_and_then_release(struct rte_eth_dev *eth_dev) > return 0; > > fail: > - if (tx_qconf) > - free(tx_qconf); > - if (rx_qconf) > - free(rx_qconf); > + free(tx_qconf); > + free(rx_qconf); > > return -ENOMEM; > } > -- > 2.23.0 >