From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 171DCA04BC;
Thu, 8 Oct 2020 11:33:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C8BDD1BBFD;
Thu, 8 Oct 2020 11:33:14 +0200 (CEST)
Received: from mail-il1-f193.google.com (mail-il1-f193.google.com
[209.85.166.193]) by dpdk.org (Postfix) with ESMTP id C4DA21BBEE;
Thu, 8 Oct 2020 11:33:11 +0200 (CEST)
Received: by mail-il1-f193.google.com with SMTP id l16so5016076ilt.13;
Thu, 08 Oct 2020 02:33:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=/X3LzgzKrMd9yWhaZ0JQbw/aK53SMhMECH5kTjsA+OQ=;
b=P+FXO51xHQM91x1QZjn4Fo9bVb0EXeHAKqkGLuxs5dm8b0VbR4wW+Cd8nRJJ6VADfX
P45R8UpICMKWmHNV3hF1tNOT1yT1w9ioP7PTTDKSpoZgkCMSqmYHakH8qAMPzqOY7bgJ
CtXMIr78lot93XlWi7DH04hawAoTlvvv7GDXYcC4bxbPRUmBgH3xgvQEtL/xtQtua4MX
OlJPQro/yLeEzocBv+82rXClgXxP2zGL2Km6YwUoM29Yq8kypJTf5GkJpr8mEWhRN7V/
n8Nkv54ao3SDQoss7192Oys2wxV9JZPU0Kqey5X/pA5/Dv1cS+Xt0oFCcF156ws2CjpS
rdIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=/X3LzgzKrMd9yWhaZ0JQbw/aK53SMhMECH5kTjsA+OQ=;
b=SiEtM4TmVT4ta0WivuobsfdyM5lJ+HmeRx9iFIux0tK1a0+4AMuZhPmNf9ROSSdcsI
PLtPNqxdVSeuuDjYjcGT3vlX4A0IebLsM920yWIfpcbm3mobpxR8qlLFNT01v/ECsTdJ
mFWQ2oBafh8hRyLPFuWtfA+Hkq2+vy/qwJPkD9im4lApixg3xUdNjujavkDKyXWNuFM4
9cp0ES9O0dZT3Oiq8rJWbgZpy2hz3+Uvr3nskvG8PoH+HpRggIrAlSNt+BIs3xfjuh9p
Rv+nelMpGRRk4hHLJyf/+YEon02svsVwhndBo3XbhMe5DoCC3tTru2ltdK/B7c1z8oi4
yUQA==
X-Gm-Message-State: AOAM5330gzYgwB/1aja0wrDA0WAwyskZzIZL1K6GHOQpkMlvlJDsexOQ
OhxMiqFdWrgukAW1N+4mAUhqv4j8N8O2LwKEXyM=
X-Google-Smtp-Source: ABdhPJxoRUBYPT+jAYMY+ibKevoVrZtj0Cq03ffr1Sowec8klPsVVDuwHqKhHjo0QSZGE3J96wn70WQBpbwx7nMtjxU=
X-Received: by 2002:a92:d7c4:: with SMTP id g4mr6097057ilq.162.1602149589989;
Thu, 08 Oct 2020 02:33:09 -0700 (PDT)
MIME-Version: 1.0
References: <20201003090541.32449-1-jay.jayatheerthan@intel.com>
<CY4PR1101MB22969F6E2619E7B07A99971E9C0A0@CY4PR1101MB2296.namprd11.prod.outlook.com>
In-Reply-To: <CY4PR1101MB22969F6E2619E7B07A99971E9C0A0@CY4PR1101MB2296.namprd11.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Thu, 8 Oct 2020 15:02:53 +0530
Message-ID: <CALBAE1OvcmT1SSFnv5JMNFJd5-Mk6CUhwWDKhq9uqSRCQNofgA@mail.gmail.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx
adapter autotest
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, Oct 7, 2020 at 3:43 PM Rao, Nikhil <nikhil.rao@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: Saturday, October 3, 2020 2:36 PM
> > To: jerinj@marvell.com; thomas@monjalon.net; Rao, Nikhil
> > <nikhil.rao@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com>
> > Subject: [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest
> >
> > From: "Jay Jayatheerthan" <jay.jayatheerthan@intel.com>
> >
> > adapter_multi_eth_add_del() does vdev init but doesn't uninit them.
> > This causes issues when running event_eth_rx_adapter_autotest multiple
> > times.
> >
> > The fix does vdev uninit before exiting the test.
> >
> > Signed-off-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> > ---
> > app/test/test_event_eth_rx_adapter.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_event_eth_rx_adapter.c
> > b/app/test/test_event_eth_rx_adapter.c
> > index dd3bce71b..71c946164 100644
> > --- a/app/test/test_event_eth_rx_adapter.c
> > +++ b/app/test/test_event_eth_rx_adapter.c
> > @@ -464,7 +464,7 @@ adapter_multi_eth_add_del(void)
> > int err;
> > struct rte_event ev;
> >
> > - uint16_t port_index, drv_id = 0;
> > + uint16_t port_index, port_index_base, drv_id = 0;
> > char driver_name[50];
> >
> > struct rte_event_eth_rx_adapter_queue_conf queue_config; @@ -
> > 484,6 +484,7 @@ adapter_multi_eth_add_del(void)
> >
> > /* add the max port for rx_adapter */
> > port_index = rte_eth_dev_count_total();
> > + port_index_base = port_index;
> > for (; port_index < RTE_MAX_ETHPORTS; port_index += 1) {
> > snprintf(driver_name, sizeof(driver_name), "%s%u",
> > "net_null",
> > drv_id);
> > @@ -513,6 +514,17 @@ adapter_multi_eth_add_del(void)
> > TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> > }
> >
> > + /* delete vdev ports */
> > + for (drv_id = 0, port_index = port_index_base;
> > + port_index < RTE_MAX_ETHPORTS;
> > + drv_id += 1, port_index += 1) {
> > + snprintf(driver_name, sizeof(driver_name), "%s%u",
> > "net_null",
> > + drv_id);
> > + err = rte_vdev_uninit(driver_name);
> > + TEST_ASSERT(err == 0, "Failed driver %s got %d",
> > + driver_name, err);
> > + }
> > +
> > return TEST_SUCCESS;
> > }
> >
> > --
> > 2.17.1
> Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
Series applied to dpdk-next-eventdev/main. Thanks.