From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 394E9A0598; Fri, 10 Apr 2020 19:56:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8C5E1D61B; Fri, 10 Apr 2020 19:56:37 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id AABB31D61A for ; Fri, 10 Apr 2020 19:56:36 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id w1so2523114iot.7 for ; Fri, 10 Apr 2020 10:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ileQ2MN5cmadbryc4ekawWCR+2O4+a9xdVokD7nWbLY=; b=sFfR+6F+sRAok/u+HC3RDkUaN+bK1wXAYu4PqaXzdtqRmOdK8wr0gXLvTF6JrxPqiI DTjiJD6qef0TqxF3ThwjKn6u0UjS1kKiPaGyBx/bbl7LaqSoHvRElq+60W5ywuiVUDSo 4ILeGtqE+iwPfVB5bMDm0w7NRmgGdp0TyXph2t7q8BXEWtUguLa4yoAvYKt6+CU5kw29 4bjxCJTxnaPPztpLtcSAjtU+xeleNDVFN7HU9gjxm7ts26wZqloLQL0F1YbqfaDqjO6j QPwRTuQpmlGVoG9OXfH/QlhDj9nK3ONyDpItSvMDUx2wYlXggcUverF4ZP1VJqPJ8rsA ldNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ileQ2MN5cmadbryc4ekawWCR+2O4+a9xdVokD7nWbLY=; b=CX8ItHtCi327RvM9EbN82zSXahG8P0xW+GxTetx2EHPhrQximUBFfnUWvGTU38kG/9 V3Zz7DSQUkeUr0Qd1JtkLTw8e2CmDtg8DKp5huqPk8/KStnvmPk8Xt4PGQQWgpSX3LT0 lGMZzR8R2//M7hb2gGb8BosygycJr7OY14IQMLK63K3ZBsT/Y7iSkPFquG7py8HHfxcW ely8XaNVHRdvxEeDr/y+KezoXbJ3rPeQV6RNw+50TQYq34MVWYnxh0d7R6sdXrm/SnLp RnxM7/UoJEgrkyb6uT6z+eZt1CFwFCxVV1fzWKffiBh/oVBst61rjmlQ38f7QiXrJfcy KX5g== X-Gm-Message-State: AGi0PuaLo/5DgYDSbuwt9XoK9htJwfxzbKU3OCz2fKz6YVhDcNa/mQoZ wMUGBLtTwMiEt2XeET58MrF3n9nNaCnkFu1dpKs= X-Google-Smtp-Source: APiQypLs7jmWYPN2/CvLwErOYXfgCPmf9cDb+VJjcRd/cRLaXOJxDhZGjBcC0MAXq0kysGXFMmRdXLzhP1MpbdXgTEA= X-Received: by 2002:a05:6602:2f87:: with SMTP id u7mr5240714iow.94.1586541395875; Fri, 10 Apr 2020 10:56:35 -0700 (PDT) MIME-Version: 1.0 References: <20200329144342.1543749-1-jerinj@marvell.com> <3071160.0WQXIW03uk@thomas> In-Reply-To: <3071160.0WQXIW03uk@thomas> From: Jerin Jacob Date: Fri, 10 Apr 2020 23:26:18 +0530 Message-ID: To: Thomas Monjalon Cc: David Marchand , Jerin Jacob , dpdk-dev , "Richardson, Bruce" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Sunil Kumar Kori , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 10, 2020 at 8:42 PM Thomas Monjalon wrote: > > 10/04/2020 15:29, Jerin Jacob: > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > > wrote: > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > # In summary: > > > > ~~~~~~~~~~~~~ > > > > # In the existing code: > > > > The trace will be emitted when > > > > a) When the trace is enabled > > > > AND > > > > b) trace level than the global level. > > > > > > > > # in new suggestion > > > > The trace will be emitted when > > > > a) When it is enabled > > > > > > > > And the EAL argument will be --trace=regex/globbing, This EAL argument > > > > will call rte_trace_regexp() and enable the selected tracepoints. > > > > > > > > The downside will be it will not be similar to log API. I am fine with > > > > either way. > > > > > > The level notion in the traces api is artificial. > > > I prefer a simple api where tracepoints state is controlled via a > > > single criteria: with the new suggestion that would be names. > > > So +1. > > > > I thought it may be helpful to replace log and I decided to pick the > > level in the trace. > > > > Looks like the consensus is to remove "level" from Trace. > > I miss the plan to rework logs on top of trace. > How could it be done? # I think, David suggestion is to add "level" as a string in the trace name. Say "debug.lib.eal.*" # I am thinking, If we don't like above, a) Add following EAL private APIs to get and set "level" as opaque object when _needed_ from trace. 1) int eal_trace_opaque_set(rte_trace_t trace, uint8_t opaque); 2) uint8_t eal_trace_opaque_get(rte_trace_t trace); The above private API would be enough to implement. > >