From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00B4CA04B3; Tue, 28 Jan 2020 12:14:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B0251C23C; Tue, 28 Jan 2020 12:14:35 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 99BF61C23A for ; Tue, 28 Jan 2020 12:14:33 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id i11so13749983ioi.12 for ; Tue, 28 Jan 2020 03:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SstGEZEMqYkD/cWFgmuLExzy0Mtg7TVFFvBq8YYN1Rg=; b=UYAujd4Cb1SdMFxPUNCZFNfnwXZSjgbknfQRU1Cqh3l3FSKqHkurzL3iKFPbfU7QuN rvlKVFWvprX7x3HjPTMDfzNmuKlo5OPWHuS16z4/eusaIONphOQZ42pNKFQbnLKzmWDH rsgIbKq6my6iwlLipUr6GCZh1upNaJTiYEGiTg5BN8qwlG+spD8f1daRcJGSGbuwBqNw 0Y5pcebq0HTakQWM3q/lJE3pn25/Mpx4sAhLg3/7y4wwV8s5jmfq2dg7X0g3+kQLSnpq QU5+fNBhcFHIBMyv/PNMbsxgEMTJfWc41tZ9YhaPFuBKPqsMK2gkDQ9KZWjVqdIPBLzB agxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SstGEZEMqYkD/cWFgmuLExzy0Mtg7TVFFvBq8YYN1Rg=; b=Ah91IihOiUCSbzFokBIU7rkMYgSD4tODCmsCk5iTMXDdpq1YOt2JT/EeXqYYKtdDgX 8bDM4+dzVFDeEuThoHeNXu1rnJq2eNTAmPef49HFh/q6dpjvmD9ihoZtDHSYQc2f87av 2FGi+j/8n3rHcKrk6Vk2oNZDfJRPVLtKk5aDQPGJmVJKnzX8Ik43O5PLrWUh7hEhKSaD Yynq8aY2ctU6IhWeHBcH8AM7km8hecqc6vmea/7TTLLXe++cUMpNvLlbfZ8t8WR6nzhV BWDKJ6S8fc7cAWaBg0z8mlaNsDeBu3e9/6r8iGFhswkAeRmpjfOkFVjYRQ8eLzdDCsdo JkSA== X-Gm-Message-State: APjAAAW9hSnzVQQTHz/30ymHxkygKneew/i2LiFffJnqfS61pZfHvP2V asz3Iy9ogYOvFuCuPw/n/QsAF1QZzqyOokvoVRw= X-Google-Smtp-Source: APXvYqyWgeUcmGxotmyCq3qcuCJggrpjk2zp+z3Qoembk2k90errLh5S+ycSzC3Ep8dpKfO8L4btlPA3vCRKuG5eQzA= X-Received: by 2002:a05:6638:a2c:: with SMTP id 12mr17451334jao.60.1580210072622; Tue, 28 Jan 2020 03:14:32 -0800 (PST) MIME-Version: 1.0 References: <20200122034609.19100-1-kirankumark@marvell.com> <20200124034602.4660-1-kirankumark@marvell.com> In-Reply-To: <20200124034602.4660-1-kirankumark@marvell.com> From: Jerin Jacob Date: Tue, 28 Jan 2020 16:44:16 +0530 Message-ID: To: Kiran Kumar K Cc: Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: extend RSS supported offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 24, 2020 at 9:16 AM wrote: > > From: Kiran Kumar K > > Extend RSS offload types for octeontx2. Add support to select > L3 SRC, L3 DST, L4 SRC and L4 DST for RSS calculation. > > Add support to select L3 SRC or DST only, L4 SRC or DST only for RSS > calculation. > > With this requirement there will be following combinations, > IPV[4,6]_SRC_ONLY, IPV[4,6]_DST_ONLY, [TCP,UDP,SCTP]_SRC_ONLY, > [TCP,UDP,SCTP]_DST_ONLY. So, instead of creating a bit for each > combination, we are using upper 4 bits (31:28) in the flow_key_cfg > to represent the SRC, DST selection. 31 => L3_SRC, 30 => L3_DST, > 29 => L4_SRC, 28 => L4_DST. These won't be part of flow_cfg, so that > we don't need to change the existing ABI. > > Signed-off-by: Kiran Kumar K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > V2 Changes: > * Updated supported offloads > > drivers/common/octeontx2/otx2_mbox.h | 6 +++++- > drivers/net/octeontx2/otx2_ethdev.h | 6 +++++- > drivers/net/octeontx2/otx2_rss.c | 12 ++++++++++++ > 3 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h > index e0e4e2f63..4972b8a6e 100644 > --- a/drivers/common/octeontx2/otx2_mbox.h > +++ b/drivers/common/octeontx2/otx2_mbox.h > @@ -918,7 +918,11 @@ struct nix_rss_flowkey_cfg { > #define FLOW_KEY_TYPE_INNR_UDP BIT(15) > #define FLOW_KEY_TYPE_INNR_SCTP BIT(16) > #define FLOW_KEY_TYPE_INNR_ETH_DMAC BIT(17) > - uint8_t group; /* RSS context or group */ > +#define FLOW_KEY_TYPE_L4_DST BIT(28) > +#define FLOW_KEY_TYPE_L4_SRC BIT(29) > +#define FLOW_KEY_TYPE_L3_DST BIT(30) > +#define FLOW_KEY_TYPE_L3_SRC BIT(31) > + uint8_t __otx2_io group; /* RSS context or group */ > }; > > struct nix_rss_flowkey_cfg_rsp { > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index 3f3fdecc4..c075b8d1a 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -113,9 +113,13 @@ > #define CQ_TIMER_THRESH_DEFAULT 0xAULL /* ~1usec i.e (0xA * 100nsec) */ > #define CQ_TIMER_THRESH_MAX 255 > > +#define NIX_RSS_L3_L4_SRC_DST (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY \ > + | ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY) > + > #define NIX_RSS_OFFLOAD (ETH_RSS_PORT | ETH_RSS_IP | ETH_RSS_UDP |\ > ETH_RSS_TCP | ETH_RSS_SCTP | \ > - ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD) > + ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD | \ > + NIX_RSS_L3_L4_SRC_DST) > > #define NIX_TX_OFFLOAD_CAPA ( \ > DEV_TX_OFFLOAD_MBUF_FAST_FREE | \ > diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c > index bc7b64387..7a8c8f3de 100644 > --- a/drivers/net/octeontx2/otx2_rss.c > +++ b/drivers/net/octeontx2/otx2_rss.c > @@ -210,6 +210,18 @@ otx2_rss_ethdev_to_nix(struct otx2_eth_dev *dev, uint64_t ethdev_rss, > > dev->rss_info.nix_rss = ethdev_rss; > > + if (ethdev_rss & ETH_RSS_L3_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_SRC; > + > + if (ethdev_rss & ETH_RSS_L3_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_DST; > + > + if (ethdev_rss & ETH_RSS_L4_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_SRC; > + > + if (ethdev_rss & ETH_RSS_L4_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_DST; > + > if (ethdev_rss & RSS_IPV4_ENABLE) > flowkey_cfg |= flow_key_type[rss_level][RSS_IPV4_INDEX]; > > -- > 2.17.1 >