From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0001C4242B; Fri, 20 Jan 2023 10:32:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96B4940150; Fri, 20 Jan 2023 10:32:43 +0100 (CET) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mails.dpdk.org (Postfix) with ESMTP id BC497400D5 for ; Fri, 20 Jan 2023 10:32:42 +0100 (CET) Received: by mail-vs1-f46.google.com with SMTP id d66so5025276vsd.9 for ; Fri, 20 Jan 2023 01:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QoLIXKcK0AlZQGkvRFpt5SgSq/OUOMLKHp8p7bd7goE=; b=U+XP9C7XMC0Q5Tiq1l/Ytq1nFHlcs/3ZqMN2TIapnKWPQ5CYiBQYD0VNes0XeX0Ib5 ctQDT3Koq2c6a3wTqWwsPRjLzOjgpqyZ6TiDT1g6AiX+EPkc/1NBP0DFdyLdb4TxCMAE Gw/i7P28BqcetpmfwsoIKbpA7ki7jYA6g5OkkADBLxmaySEgFY5DC+iuWHXsdv6gDlos 8hmEG3/Z3CzkD8k1dNo3bRePNADLfPlB7R9obYDcp0BJh6lfgJuwksMWz1XiFfReYvUW VbR1oMKJS6pRAjUATuwOYP79phxkxt4lYDTAAkGjPWAp++9m1c2EfWKGy+wUMsazcHqg 4kuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QoLIXKcK0AlZQGkvRFpt5SgSq/OUOMLKHp8p7bd7goE=; b=C2Za74rcGc7XRJ9Mm82+/nJ5Tj5ny6TCEldtfYrBh63C1ByzaSwkh2FID7NG8igY4K dqtQ57H17hPCP78msZwhla4u/CPS5FJidsKwcJTydeokBf89wQKae9U6Fcy+Eolf177H I+4/sDSEkcvdPUIDyrMFYwQspfVD1Ieu4SNFfAaxHDqp2plD3MnBQGtRMNfRAbp585/G kRp1ssm02kszQunWefnRJjnWKE3hN3IU+bAU6v++/ckoMpuAnvUuWfmBT87QFwopbgkS /Q6Gx8o3waDZTnqvk9hfxVkcqL5vVxBL50Fkpb3G5f1yUM/XpJt5+Ov0EEmH2mXliU0l wj+w== X-Gm-Message-State: AFqh2kpTIjgpkyiQlfcbDd+4rN+c7DxcINIpjooIGIbymM9t5cwDnHis XELawScFLK0hyK4EBlXVjXh2xG7PgKfTS5IdvbI= X-Google-Smtp-Source: AMrXdXtZDPNipvNLoBThgbKp2OwQ2iLiUZb0LnWSWlXlfuiJCHG5leGak60+szz5KOhH+VRFv1skH961DFnbVmWlKH0= X-Received: by 2002:a67:ea8f:0:b0:3d0:ee83:9599 with SMTP id f15-20020a67ea8f000000b003d0ee839599mr2094739vso.45.1674207161931; Fri, 20 Jan 2023 01:32:41 -0800 (PST) MIME-Version: 1.0 References: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 20 Jan 2023 15:02:15 +0530 Message-ID: Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs To: "Naga Harish K, S V" Cc: "jerinj@marvell.com" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 20, 2023 at 2:28 PM Naga Harish K, S V wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, January 18, 2023 3:52 PM > > To: Naga Harish K, S V > > Cc: jerinj@marvell.com; Gujjar, Abhinandan S > > ; dev@dpdk.org; Jayatheerthan, Jay > > > > Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs > > > > On Sat, Jan 7, 2023 at 9:49 PM Naga Harish K S V > > wrote: > > > > > > The adapter configuration parameters defined in the ``struct > > > rte_event_eth_rx_adapter_config_params`` can be configured and > > > retrieved using ``rte_event_eth_rx_adapter_set_params`` and > > > ``rte_event_eth_tx_adapter_get_params`` respectively. > > > > > > Signed-off-by: Naga Harish K S V > > > --- > > > > > > +/** > > > + * Adapter configuration parameters > > > + */ > > > +struct rte_event_eth_rx_adapter_runtime_params { > > > + uint32_t max_nb_rx; > > > + /**< The adapter can return early if it has processed at least > > > + * max_nb_rx mbufs. This isn't treated as a requirement; batching may > > > + * cause the adapter to process more than max_nb_rx mbufs. > > > > This parameter as specific to SW only driver. So future something added from > > HW only driver item then it won't work for SW driver. So we need capability > > per adapter. > > > > So, I would suggest following theme across _all_ adapters. > > > > 1) Introduce RTE_EVENT_ETH_RX_ADAPTER_CAP_RUNTIME_XYZ and > > associate each parameter(the one we think, it is not common for all > > adapters) > > The parameters that are exposed in the patch are all existing parameters and they are made > runtime configurable for SW implementation. I think, there are no such parameters existing today for > HW driver implementation. Hence it may be better to introduce these flags when the HW driver > Implementation requires runtime configurable parameters. Since current values are not applicable to HW. So we any way need the capability now to tell this is not applicable for HW. > > > 2) Add some reserved fields in rte_event_eth_rx_adapter_runtime_params > > so that we don't break ABI in future > > Agreed. > > > 3) Add rte_event_eth_rx_adapter_runtime_params_init() function just > > make structure fill with default to avoid ABI break > > 4) Add rte_event_eth_rx_adapter_runtime_params_info_get(). Lets > > capability flags and other items can be return via this > > These two items(3,4) can be taken as and when item "1" above is implemented. See above. > > > 5) Change rte_event_eth_rx_adapter_set_params as > > rte_event_eth_rx_adapter_runtime_set() or > > rte_event_eth_rx_adapter_runtime_params_set() to make it runtime > > explicit > > Agreed > > > 6) Change rte_event_eth_rx_adapter_get_params as > > rte_event_eth_rx_adapter_runtime_get() or > > rte_event_eth_rx_adapter_runtime_params_get() to make it runtime > > explicit > > Agreed