From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9BF643C08; Tue, 27 Feb 2024 12:01:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D64484027D; Tue, 27 Feb 2024 12:01:02 +0100 (CET) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id 68B7A40150 for ; Tue, 27 Feb 2024 12:01:02 +0100 (CET) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-42e86f37a0eso12832491cf.0 for ; Tue, 27 Feb 2024 03:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709031662; x=1709636462; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zADLb1PLYtDU55U9Bw0zQRKUL9LT39Cw2LZ/To+cSac=; b=Xrj3xhUHU4ycFYiQ6Zmoxi4Aiyq+58R4W3jOKu8NlWrjbDokVgDtvra5+Wsfo4jZ06 mo9Y2vi77L96xBhVIrDZ9OLBzczHcQXXFxt0s1+4mcdUcpncV7X7Gh19RVElLhsB/cx8 7MtvDeKfKbwWSDp6lmrY8o3zo03dzJnCW8dhRytRzf+GuBiaQIu9cbJqbL/eCUvThK/x d7J82jLopVcwr0Eibv8pI5b9RWN5deZCmNZYwejpRMnk7k8ZxMHjYcDJyFplzdT9CKe8 eZw2mJ3PAAM8/2Qip61GXNFQ+JmTxlBrk5mFlAWTfkf56tM2No2HPlzxWamF/jbNhbNQ Ajfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709031662; x=1709636462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zADLb1PLYtDU55U9Bw0zQRKUL9LT39Cw2LZ/To+cSac=; b=JrFrcP6L3qVRmNbXXLUESC+HB2SffJJlOwRkyRKs4oogYvWQzZ6tZObQ/r2tv8J0wS chOn2QgRnSMWxUVZvVgqW18jSZMiB1BOya6Zua9dI+dTQzd3fPCrCpfYjH5RaHUEfF+x p8rqODBnuqCRspkQZb77JNI1bWehrBqwJcHvY+zHJVX2FfamiPeRw8q/A+fklXB1gG2B 5wI7E7cT6gsib7pVxszCScn4aSQ+5w6gC9o0FUq2k6nxJwPX6UoUnHfVT5ewJkWYlle1 rEPsV8990m3j+18WG2RPmdJeK3PnZPq1EsJOAQrfguTdPziSxp0in+sXdpgm4Qnn9B2U b90Q== X-Forwarded-Encrypted: i=1; AJvYcCViiAFnluMWRb3Ek++a64aBWZs4GVKxATh6/ToIsvY0pHjzPkVVuU5Z5n55Bro5b8qQ4CNOwEE8yrARYxQ= X-Gm-Message-State: AOJu0YxuMiqv7F30jVNjkzOvob/9ag5PtVFnOMShGKBbGOvAizT3rK28 6oj92GJfHD1lw5tOtKIN9oDkqlwNL8kGFM1CpC7A2l0vtTSAogJwGChsV8C/kHlsKLvIQAHB4uh 5qMwHwRdtiv24sS0y0o9BFtf7+Z/dqH12 X-Google-Smtp-Source: AGHT+IFP6i6gnf1m2S1nxTUIXO1feTH6DkVUu/4z74sINBVCcacs2dNnyayPwX1aKc4xZhX+BToygN24Ef2DVl5e1h8= X-Received: by 2002:ac8:5792:0:b0:42e:7a3e:4ac7 with SMTP id v18-20020ac85792000000b0042e7a3e4ac7mr10136035qta.4.1709031661678; Tue, 27 Feb 2024 03:01:01 -0800 (PST) MIME-Version: 1.0 References: <20240223140056.130844-1-mb@smartsharesystems.com> <98CBD80474FA8B44BF855DF32C47DC35E9F269@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F269@smartserver.smartshare.dk> From: Jerin Jacob Date: Tue, 27 Feb 2024 16:30:35 +0530 Message-ID: Subject: Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: julien_dpdk@jaube.fr, dev@dpdk.org, stephen@networkplumber.org, rmody@marvell.com, shshaikh@marvell.com, palok@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 26, 2024 at 8:17=E2=80=AFPM Morten Br=C3=B8rup wrote: > > > From: Jerin Jacob [mailto:jerinjacobk@gmail.com] > > Sent: Monday, 26 February 2024 09.34 > > > > On Fri, Feb 23, 2024 at 7:30=E2=80=AFPM Morten Br=C3=B8rup > > wrote: > > > > > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only > > the > > > VLAN ID, so only copy 2 byte, not 4. The target structure has padding > > > after the field, so copying 2 byte too many is effectively harmless. > > > There is no need to backport this patch. > > > > > > Use RTE_PTR_ADD where copying arrays to the offset of a first field i= n > > a > > > structure holding multiple fields, to avoid compiler warnings with > > > decorated rte_memcpy. > > > > > > Bugzilla ID: 1146 > > > > > > Fixes: 540a211084a7695a1c7bc43068934c140d6989be ("bnx2x: driver core"= ) > > > Cc: stephen@networkplumber.org > > > Cc: rmody@marvell.com > > > Cc: shshaikh@marvell.com > > > Cc: palok@marvell.com > > > > > > Signed-off-by: Morten Br=C3=B8rup > > > Acked-by: Devendra Singh Rawat > > > --- > > > v9: > > > * Fix checkpatch warning about spaces. > > > > Fixed the following issues[1] and updated the git commit as follows > > and applied to dpdk-next-net-mrvl/for-main. Thanks > > Thank you, Jerin. > > [...] > > > Is it candidate for Cc: stable@dpdk.org backport? > > No, I don't think so: > 1. The extra 2 byte copy is effectively harmless due to padding, as menti= oned in the commit message. > 2. The decorated rte_memcpy (if work on that patch series is ever resumed= ) is an improvement, not a bug fix, and will not be backported. So the memc= py parts of this patch are irrelevant for the stable versions. Shall remove Fixes: tag then?. Since the patch has a Fixes tag, I thought good to merge to stable as it is fixing. Also, could you comment on @Stephen Hemminger latest comments, Should I wait for new version? or new changes can go as separate patches. >