From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E455A0519; Fri, 3 Jul 2020 17:36:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E85F1DC48; Fri, 3 Jul 2020 17:36:25 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id DA93B1DC35 for <dev@dpdk.org>; Fri, 3 Jul 2020 17:36:23 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id q8so32845945iow.7 for <dev@dpdk.org>; Fri, 03 Jul 2020 08:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IxsWKTfXEJVJirEyz6+qANGC4p01YPUkHVEv3omcBNU=; b=ctWR2SlqA1gbpatCPVtPYSQGj3LIX4StOwpAOU5FjIlna5LrbxKzyZBm0gWoszh+PP m+4s1me/IwKI0XfsZNfW4WHrCWkpA/IiAfm4HlmFD1jQqemi0pkwlR7AdRqb3a7xVCTS 0nzENPS9hAiUpMjLSsbx5wBkarCU5ftKbXWp7Y3QHVhLtkAFVpInigdLJVcNtIzu9OlA uKZkeASnurhNEJJ8cwLhHV3FCy6O8gBFSQEafyiX+Yy22PhxL64Q35KonImeeyS7zfj7 ZqAc7mKKSuzyy1OfxJ/EE2sDG40pmlcqUHO+oWi6FWTsQofuanwR1qDa6qE8LQzgzcUf NvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IxsWKTfXEJVJirEyz6+qANGC4p01YPUkHVEv3omcBNU=; b=Rf/cvPWRAimp8xqIhmbTDqVYX8LF+CTOUnREBDjWdsdXH3vNEQCddK7NZ1XcCq2N5M d5rlBgBAUQ/3/FL5fEkQY3CMsuwJn7yfsglIfH5XFVLA9KdRxxkC7fwl/UyTHejdoByD pjRCYHcCtGI2+rCgaTIQgzbvhJ71kfgKunEIoupEs1rAKVZQRBFnRXtIT2CKZKnmp7Zi 4KE/1FMi+BmqI2rcUFS0a48swT0+/cTo9ISGS6dTt6btjJkjC7i8lM8Y83iMcXUNH4cI UBfrrk1c9Vvi0MlGRHpYTFAAM9qGX9sXfauinPLKKNE7Hl2hHTk/ITyXqF4++KkWjAjc mFkw== X-Gm-Message-State: AOAM530HOl4zSalRuL5HDv83i6WemQ9/C/7J46viHsMU3H1JinXg1H1T BntDZbVFJYYUkrjmj2evwXDPS+slTDJALyPDjuA= X-Google-Smtp-Source: ABdhPJxYLBdTYUwLgT/nVTmqnwOhNjOtXwA3kL2XKs1fcGiP3Vfw+uhtIri2iLNle8QJ/4jP7/g0EH4oHOzlxCUcL1Q= X-Received: by 2002:a6b:b344:: with SMTP id c65mr13289231iof.123.1593790583096; Fri, 03 Jul 2020 08:36:23 -0700 (PDT) MIME-Version: 1.0 References: <1593102379-400132-1-git-send-email-jiaweiw@mellanox.com> <AM0PR0502MB40191263150E3A4F6E91758ED26A0@AM0PR0502MB4019.eurprd05.prod.outlook.com> <CALBAE1PE3kTKAyhLQAaZQ8dg2nbBS9ch6_QOXAN2hNjeTira1Q@mail.gmail.com> <2018114.U5Vea0xDAA@thomas> In-Reply-To: <2018114.U5Vea0xDAA@thomas> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Fri, 3 Jul 2020 21:06:07 +0530 Message-ID: <CALBAE1OxCNMHX9Z+DdQV-nsE_vaz912WfG8LEJqVF_Kuj2SFxw@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Matan Azrad <matan@mellanox.com>, "Jiawei(Jonny) Wang" <jiaweiw@mellanox.com>, Ori Kam <orika@mellanox.com>, Slava Ovsiienko <viacheslavo@mellanox.com>, dpdk-dev <dev@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>, "ian.stokes@intel.com" <ian.stokes@intel.com>, "fbl@redhat.com" <fbl@redhat.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > 03/07/2020 17:08, Jerin Jacob: > > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad <matan@mellanox.com> wrote: > > > From: Jerin Jacob: > > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > > library(ethdev). > > > > Please depreciate the old API. > > > > We should not have two separate paths for the same function in the same > > > > ethdev library. It is pain for app and driver developers. > > > > > > What are about all the other rte_flow parallel configuration APIs in ethdev: > > > promiscuous_enable; > > > promiscuous_disable; > > > allmulticast_enable; > > > allmulticast_disable; > > > mac_addr_remove; > > > mac_addr_add; > > > mac_addr_set; > > > set_mc_addr_list; > > > vlan_filter_set; > > > vlan_tpid_set; > > > vlan_strip_queue_set; > > > vlan_offload_set; > > > vlan_pvid_set; > > > udp_tunnel_port_add; > > > udp_tunnel_port_del; > > > ... > > > > > > These APIs can be replaced easily by rte_flow API. > > > Do you think we need to deprecate all? > > > > I think, basic stuff like below can have separate API. > > 1) promiscuous_enable; > > 2) promiscuous_disable; > > 3) allmulticast_enable; > > 4) allmulticast_disable; > > 5) mac_addr_remove; > > 6) mac_addr_add; > > 7) mac_addr_set; > > 8) set_mc_addr_list; > > "Basic" is not a precise definition :) Yep. > I would say port-level configuration should remain > out of rte_flow API. +1. In addition that, I would say anything needs to configured at "per-flow" granularity use rte_flow. > > > But The VLAN and UDP related should be rte_flow candidates.(IMO) > > Yes definitely, tunneling is better managed with rte_flow. > > This is an important discussion, I Cc other ethdev maintainers. > Note: this is an ethdev patch, all ethdev maintainers should be Cc'ed. > Aren't you using --cc-cmd devtools/get-maintainer.sh ? > >