From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BC9DA034C; Tue, 18 Aug 2020 12:04:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B1A71C037; Tue, 18 Aug 2020 12:04:17 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 7810E2BE2 for ; Tue, 18 Aug 2020 12:04:15 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id g14so20671706iom.0 for ; Tue, 18 Aug 2020 03:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KBmgVaF/22ZXQYLQ/u4SeHsEzPtTvSTeaJZP8m2mrgM=; b=hGMzyJNK95oicFh09Zbjjvc9RNPlpPrHvGlSTcECV76p1eIddaUarySYNuLkR8cTRn 1r3Y5x1gLDagu+YXEULpcTWEDEjzVu3Sbc1tHXn9ahoLIgS14Km0HyGsvdfvlzW0yCxZ CBvZQ0sSw5D21gJ1dIHGiFU7OTnaAHquZFdKC55poHKBS3LdlhywH/xLM3HyGE8quB0B KEEv8opE1n9YxwqR8lPTma8YAg4CfnJi3QEvesq4VymuF2F1DrM4S07ELRJ8asbhqq8k d1iALbIUYG9d66ryC7z8D6AeGW8Gfr0lWp/A5tXB0KPXCl+GXmKhhmBBRLi++EqZM2hY Fm/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KBmgVaF/22ZXQYLQ/u4SeHsEzPtTvSTeaJZP8m2mrgM=; b=hRNy1Sr4TxgS2Dm2JfK595OePOiQCYLv+AeiJl8V0/Wvdt2jiagIQyM7pWlWdcyL2q vTH8ZLHPm25Lqf3PoamL1YifRQKVPPrpgxcMp2NmPR68NtJcu/iuTgA2mAp4EZ4+ytv2 j8PTiBvD73wx9RC/yRCDxOlb6l4bVyI++YTyHnL0Eu1tH9lF6Twa2h4ScoSAYps/urYC YHivhq1UIPPypDoqICiVyPK1JzgzylPQfwGwdE5bd7qTFKVLqNQnWDu7abXqlyLUbXOX hnQnSDu5hFnhmhu7apHDoIbmcguY3gPErq4MEREZvn/OHjclCU8bItrmjSG2XWHe5A6O 3nmA== X-Gm-Message-State: AOAM532dkhB4KWQOoVZKJcE7EyD7Ym4cqE9iVEpLdPKA5CLQ99lCAig8 0O+bgFvfGwuLSPH0luArqQvIwzNZtXqPqwXwql0= X-Google-Smtp-Source: ABdhPJwcE39FygSwaH9Do2tel9095oLksiZDZlZMf7n8vADecCExlwV6BvnHbyRiAsoy+9pIVHHJBg9dMLUHn5vOqbM= X-Received: by 2002:a5e:9247:: with SMTP id z7mr15866851iop.1.1597745054672; Tue, 18 Aug 2020 03:04:14 -0700 (PDT) MIME-Version: 1.0 References: <20200808143631.1704756-1-kirankumark@marvell.com> <20200818072143.2189928-1-kirankumark@marvell.com> <20200818072143.2189928-2-kirankumark@marvell.com> In-Reply-To: <20200818072143.2189928-2-kirankumark@marvell.com> From: Jerin Jacob Date: Tue, 18 Aug 2020 15:33:58 +0530 Message-ID: To: Kiran Kumar K Cc: Jerin Jacob , Nithin Dabilpuram , dpdk-dev , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ori Kam , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Rosen Xu , Beilei Xing , jia.guo@intel.com, Rasesh Mody , Shahed Shaikh , Qiming Yang , Qi Zhang , "Wiles, Keith" , Hemant Agrawal , Sachin Saxena , "Zhao1, Wei" , John Daley , Hyong Youb Kim , Chas Williams , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Rahul Lakkireddy , Gaetan Rivet , Liron Himi , Jingjing Wu , "Wei Hu (Xavier" , "Min Hu (Connor" , Yisen Zhuang , Ajit Khaparde , Somnath Kotur , Jasvinder Singh , Cristian Dumitrescu Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/octeontx2: add rss hash level support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 18, 2020 at 12:52 PM wrote: > > From: Kiran Kumar K > > Add support to choose rss hash level from ethdev rss config. > > Signed-off-by: Kiran Kumar K > --- > drivers/net/octeontx2/otx2_ethdev.h | 4 +++- > drivers/net/octeontx2/otx2_rss.c | 9 +++++++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index e9efe52bb..953445ecb 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -119,7 +119,9 @@ > #define NIX_RSS_OFFLOAD (ETH_RSS_PORT | ETH_RSS_IP | ETH_RSS_UDP |\ > ETH_RSS_TCP | ETH_RSS_SCTP | \ > ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD | \ > - NIX_RSS_L3_L4_SRC_DST) > + NIX_RSS_L3_L4_SRC_DST | ETH_RSS_LEVEL_INNER | \ > + ETH_RSS_LEVEL_OUTER | \ > + ETH_RSS_LEVEL_INNER_OUTER) Since it is value 1 and 2, for bitmask purpose, shouldn't be ETH_RSS_LEVEL_MASK instead of ETH_RSS_LEVEL_OUTER | ETH_RSS_LEVEL_INNER_OUTER