From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DBB3A04C0; Mon, 28 Sep 2020 09:38:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 279B01D58A; Mon, 28 Sep 2020 09:38:04 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id BD83A1D56C for ; Mon, 28 Sep 2020 09:38:01 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id z5so240592ilq.5 for ; Mon, 28 Sep 2020 00:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=utmA0sjcqYa8+m+w1s31ftjZWYGSnjfWYBfUsQhjgWQ=; b=RNRUcUbEIgGc7BZLxJ9ytgOFX8GCOvK5M4+ZQMFCyXmRv2bLcw7F/O8uoTqlR5JO7l vIERZ+blDmoQo5D3AZxp72sCWhUrA8SnNb7hQ5iI1GnOWoAA68N4eUED6XCTa8nxKV0x seypPyGKoxB51MbVtYbPaJW11UfD6M7431J7oBDOHlZl7I6zRwF+6docV8yU+0TgyUU6 yoY6Ndv9OgdlaSeI492Xfhz3uRI7iuVD9DkqtkzWM+DN4EcGh+C3lMxFgnd9L1136NIB yECbnX/QljHShODq/WC+iEzcTz4otDaZPtBbfD4e6iAvZHeegIhuVjWhHciquwtmPsBj lxNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=utmA0sjcqYa8+m+w1s31ftjZWYGSnjfWYBfUsQhjgWQ=; b=HtPnvHNl/VVLk/3BkcPStPtU+Osl5kjIijm6KHBV+jEouaWYHypst3k7Ek1chcDpVW h6+9iPIcgLK2Gy5GZ5h02LvRCc7vyWxfRrplJzbCLFwWhguAgv6CyLeY+2Y8OxzqqXj9 h/qwcEnw2PQ5UyH1BNzPM6fl6AIQy0qz47QOi0wS066OTe56PD4j0DgYEA8i5yMlhx8v jG1I/OZVYizN1ulShlFfiOUTZD/nczmR49UmVp2RuSupf6jVW/TjCo1FE0brhV7srmeg 3iHqeryWwMKvO2D9Nnlz3g/K5VP35vfrjxdE90fEFtyOLbcZtnSwlJFvrDqpXttEFEnk gZqA== X-Gm-Message-State: AOAM53211R37E/UQadTMELzqVxFWhW2ua2YcSoO58wwJ+9xyScdpoQKp atVIwJ39sLbmMdOmhA5x2AB9ltpSGBbOVho2SLi7hP+Evu7yqw== X-Google-Smtp-Source: ABdhPJxKZKWd2gQqvebDQL6COCAbsdbrgAAfJtylOycnIyntdRQ6743rUVfj6gBD9VYxxDiM9jsXsPY2NAV+DjmrRLI= X-Received: by 2002:a92:d8cb:: with SMTP id l11mr95389ilo.271.1601278681174; Mon, 28 Sep 2020 00:38:01 -0700 (PDT) MIME-Version: 1.0 References: <20200813072249.1897215-1-kirankumark@marvell.com> In-Reply-To: <20200813072249.1897215-1-kirankumark@marvell.com> From: Jerin Jacob Date: Mon, 28 Sep 2020 13:07:45 +0530 Message-ID: To: Kiran Kumar K Cc: Jerin Jacob , Nithin Dabilpuram , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add support for VLAN based RSS hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 13, 2020 at 12:53 PM wrote: > > From: Kiran Kumar K > > Adding support for VLAN based RSS hash. 2 bytes of SPI will s/SPI/TCI Fixed above comment on merge. > be considered for hashing. > > Signed-off-by: Kiran Kumar K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/common/octeontx2/otx2_mbox.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev.h | 2 +- > drivers/net/octeontx2/otx2_rss.c | 3 +++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h > index 34b1d0663..831445703 100644 > --- a/drivers/common/octeontx2/otx2_mbox.h > +++ b/drivers/common/octeontx2/otx2_mbox.h > @@ -966,6 +966,8 @@ struct nix_rss_flowkey_cfg { > #define FLOW_KEY_TYPE_INNR_SCTP BIT(16) > #define FLOW_KEY_TYPE_INNR_ETH_DMAC BIT(17) > #define FLOW_KEY_TYPE_CH_LEN_90B BIT(18) > +#define FLOW_KEY_TYPE_CUSTOM0 BIT(19) > +#define FLOW_KEY_TYPE_VLAN BIT(20) > #define FLOW_KEY_TYPE_L4_DST BIT(28) > #define FLOW_KEY_TYPE_L4_SRC BIT(29) > #define FLOW_KEY_TYPE_L3_DST BIT(30) > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index e9efe52bb..c4cb09621 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -119,7 +119,7 @@ > #define NIX_RSS_OFFLOAD (ETH_RSS_PORT | ETH_RSS_IP | ETH_RSS_UDP |\ > ETH_RSS_TCP | ETH_RSS_SCTP | \ > ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD | \ > - NIX_RSS_L3_L4_SRC_DST) > + NIX_RSS_L3_L4_SRC_DST | ETH_RSS_C_VLAN) > > #define NIX_TX_OFFLOAD_CAPA ( \ > DEV_TX_OFFLOAD_MBUF_FAST_FREE | \ > diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c > index d859937e6..364dc623c 100644 > --- a/drivers/net/octeontx2/otx2_rss.c > +++ b/drivers/net/octeontx2/otx2_rss.c > @@ -238,6 +238,9 @@ otx2_rss_ethdev_to_nix(struct otx2_eth_dev *dev, uint64_t ethdev_rss, > flowkey_cfg |= FLOW_KEY_TYPE_CH_LEN_90B; > } > > + if (ethdev_rss & ETH_RSS_C_VLAN) > + flowkey_cfg |= FLOW_KEY_TYPE_VLAN; > + > if (ethdev_rss & ETH_RSS_L3_SRC_ONLY) > flowkey_cfg |= FLOW_KEY_TYPE_L3_SRC; > > -- > 2.25.1 >