From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA019A04A7; Tue, 5 May 2020 19:28:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54F7F1D694; Tue, 5 May 2020 19:28:46 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id E2CE61D693 for ; Tue, 5 May 2020 19:28:44 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id i19so2784645ioh.12 for ; Tue, 05 May 2020 10:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iOVHYzCJ3M0NmPsNnMQnCKLYDy1qXmTs0Amc+FCVGpU=; b=JWBUuc14NbsNB9M9ww9o/L3WJRUoOxusBXBnkyrkKjowaA7wF61ime0XdYp3wUE0I0 5KJx/Jx6pGwlMYdzNs/kBy7j/qLIvSWOXnkFYR4QbNlTcmTZb2ObEYG9QWEoXtBzjS3q yzIM0hYghchmujQf6y3GcE6ReTQpu3TaU1l6pmDfvEhER51fj0JDSZVkc2bqcrbeX7nG 9W+YlnoTBycQrCZ8mffUYtuX+Ntoxyt2INTWq0QixkREdgvjF1/o24hHQUu8/WVpFq+F aipblOtwOjzl26xKDgj6q4mbImFdpYc7rE70cU4MAPp4JMDv4UuIIfs2OOwA0ESHKsWa NssQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iOVHYzCJ3M0NmPsNnMQnCKLYDy1qXmTs0Amc+FCVGpU=; b=bXunuFg8V/vqsajxquFTGXHtfnQLbCNF6LpsdtWy/wyKv6ouE6zYc3R2LhjtFSxc4a nHL6uoFErbXhNk/4WPX/JVkEb3z7qIQhhSESqFQX2WmfCCa6Vqc3ATDJH96nTtQxinLF D/3fWm9EdUPkOQeaX3srBEgDeqhE/u4Dd0qFQpqOmUBBvmBHP8axQCz4FEJktJdqL4L/ ZJ9MDPzEOEv5jmW3QhkqI0/ka+93Ley3kBp+gmRZVZV0b4gdkkUakqMhujhdddAgL1co ssWVmuXGAx842L53ccneWYkw8Xz80mKxPqUsOutJHFNL/LF0FWsKuHbYzovwPABaptFe LQ4Q== X-Gm-Message-State: AGi0PuYr10ipDKZhcRaZ8VcwS52dBCG4vU8WK5/QoD6PiZSh7xyXiYya iSw+T5tU2TnvmItWQRF3uCi2I0g1eyy2At+LNHY= X-Google-Smtp-Source: APiQypIxFJdhGZaoBO75zpiG2z+noKY586b3vRgtVkSd66TayOvidjRbT9UOOZjmxUYkbFbLvB96X778DstwTGvkQm0= X-Received: by 2002:a05:6638:2a2:: with SMTP id d2mr4688393jaq.104.1588699724040; Tue, 05 May 2020 10:28:44 -0700 (PDT) MIME-Version: 1.0 References: <20200503203135.6493-1-david.marchand@redhat.com> <1870194.PIDvDuAF1L@thomas> In-Reply-To: <1870194.PIDvDuAF1L@thomas> From: Jerin Jacob Date: Tue, 5 May 2020 22:58:27 +0530 Message-ID: To: Thomas Monjalon Cc: David Marchand , dpdk-dev , Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , Declan Doherty , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > 05/05/2020 19:09, Jerin Jacob: > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > > > 05/05/2020 18:46, Jerin Jacob: > > > > > On Tue, May 5, 2020 at 9:58 PM David Marchand wrote: > > > > > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > > > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand wrote: > > > > > > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > > > > > > > > > Please share the data. > > > > > > > > > > > > > > > > > > > > > > Measured time between first rte_trace_point_register and last one with > > > > > > > > > > > a simple patch: > > > > > > > > > > > > > > > > > > > > I will try to reproduce this, once we finalize on the above synergy > > > > > > > > > > with rte_log. > > > > > > > > > > > > > > > > > > I took the time to provide measure but you won't take the time to look at this. > > > > > > > > > > > > > > > > I will spend time on this. I would like to test with a shared library > > > > > > > > also and more tracepoints. > > > > > > > > I was looking for an agreement on using the constructor for rte_log as > > > > > > > > well(Just make sure the direction is correct). > > > > > > > > > > > > > > > > Next steps: > > > > > > > > - I will analyze the come back on this overhead on this thread. > > > > > > > > > > > > > > I have added 500 constructors for testing the overhead with the shared > > > > > > > build and static build. > > > > > > > My results inline with your results aka negligible overhead. > > > > > > > > > > > > > > David, > > > > > > > Do you have plan for similar RTE_LOG_REGISTER as mentioned earlier? > > > > > > > I would like to have rte_log and rte_trace semantics similar to registration. > > > > > > > If you are not planning to submit the rte_log patch then I can send > > > > > > > one for RC2 cleanup. > > > > > > > > > > > > It won't be possible for me. > > > > > > > > > > I can do that if we agree on the specifics. > > > > > > > > > > > > > > > > > > > > > > Relying on the current rte_log_register is buggy with shared builds, > > > > > > as drivers are calling rte_log_register, then impose a default level > > > > > > without caring about what the user passed. > > > > > > So if we introduce a RTE_LOG_REGISTER macro now at least this must be fixed too. > > > > > > > > > > > > What I wanted to do: > > > > > > - merge rte_log_register_and_pick_level() (experimental) into > > > > > > rte_log_register, doing this should be fine from my pov, > > > > > > - reconsider the relevance of a fallback logtype when registration fails, > > > > > > - shoot the default level per component thing: levels meaning is > > > > > > fragmented across the drivers/libraries because of it, but this will > > > > > > open a big box of stuff, > > > > > > > > > > This you are referring to internal implementation improvement. Right? > > > > > I was referring to remove the current clutter[1] > > > > > If we stick the following as the interface. Then you can do other > > > > > improvements when you get time > > > > > that won't change the consumer code or interference part. > > > > > > > > > > #define RTE_LOG_REGISTER(type, name, level) > > > > > > > > This discussion is interesting but out of scope for rte_trace. > > > > I am also interested in rte_log registration cleanup, > > > > but I know it is too much work for the last weeks of 20.05. > > > > > > > > As Olivier said about rte_trace, > > > > "Since it's a new API, it makes sense to make > > > > it as good as possible for the first version." > > > > > > > > So please let's conclude on this rte_trace patch for 20.05-rc2, > > > > and commit to fix rte_log registration in the first days of 20.08. > > > > > > Why not hold the trace registration patch 2/8 and apply rest for RC2. > > > Once we have synergy between the registration scheme between rte_log > > > and rte_trace > > > apply the patch for RC2. > > > > I meant, Once we have synergy between the registration scheme between > > rte_log and rte_trace > > apply the patch for _20.08_? > > Because of what I wrote above: > As Olivier said about rte_trace, > "Since it's a new API, it makes sense to make > it as good as possible for the first version." > > The intent is to show an API as simple as possible > in order to have a maximum of developers integrating it, > and getting more interesting feedbacks. > > In other words, we want to make your work shine for prime time. I like that, If it is not shining just because of 2/8 not applying now then I fine with that. Anyway, it is an experimental API, There is still room to change and nothing is set and stone. For me, the synergy between log/trace interface important as trace needs to replace rte_log. > >