From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 284C6A0C45; Fri, 30 Jul 2021 12:25:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5F7B4014D; Fri, 30 Jul 2021 12:25:09 +0200 (CEST) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id 364874003F for ; Fri, 30 Jul 2021 12:25:08 +0200 (CEST) Received: by mail-io1-f50.google.com with SMTP id y200so10830783iof.1 for ; Fri, 30 Jul 2021 03:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x/4ECOWS2aTVuWX/4lIpXa8ilCWhxVcIEuNSjkoYmnU=; b=GZlzKea4tFfzhfGG7cGnWJnxIyRH5Lmqrz9bAmqmg2QpRGHsu9qfIHvCOawOu0CSbA EfVtKGnPMLr4MBid1Y4gMtadzeLWL3PniC9zbET3aQGbyVfFHzk/uTeNUdZwWl26tCbC JykDV7mwSgMglclXxb/NVFZOSjsmoiayJ3bQoWFQnmNALkCv1fhLPTsQOwO9vdsw7rQF J1qFaMolElU2X5gkPyRGWedP/BDgKEzYgMLK0nudJ9fjVEPVoKtbqklhoELX/wDJZD+y f60jUj6Xj6xM6tnmwwQRktP/ml9UQMfGTDEp+fufZ29dWztrprioq9GzUJFJWJApY7VQ uieA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/4ECOWS2aTVuWX/4lIpXa8ilCWhxVcIEuNSjkoYmnU=; b=bTWbqA7cyNvImVSBHJVNpDVa7OPz23cPBKZIafiuxgtrxBL/fAO4U7HuJapRAVWfg4 QfI+KC5crQJtdkcWKt81AwqHyrYT2bXCQPbj6o7r6X3p5t/lJ0U6IPVol7CIJC2a/3kk i5bFaAkRdpMMakhALPku7GoMVkTQ4dGchELl3O10VOOfJICXkRB1hRRqVYRhxYyNHBLU nGxN6Tqm48Y/3bqpOhJt0uH0u073hANDTYXPTh9r4Gu5JuMdyqIKepA0ZLFtlMieFtLi zL0goBMBV2wVDyD+/h6TtpvKIPGYh3SPqRqLyp0AbAfSc67ptwtHjKn93FrBGWbKrqAX Xbog== X-Gm-Message-State: AOAM531RHogNd0Lu/UddVIBnSJrzrOparDnYSTDC9GcY0OizyD3FyG2A FNot79TYMW2CwMJ3fAwCI8a2FX3Gvc1+V0N23yI= X-Google-Smtp-Source: ABdhPJzdeZswYTNXY2GEm43GA5fKqX+AG22fDqtaqXPNnvVYuMKJh2BZdkthbClgAuooKhm+mcH1De3lomlrDu73zEY= X-Received: by 2002:a02:93a7:: with SMTP id z36mr1598248jah.112.1627640707588; Fri, 30 Jul 2021 03:25:07 -0700 (PDT) MIME-Version: 1.0 References: <20210723081222.4176279-1-s.v.naga.harish.k@intel.com> <20210724141036.915356-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 30 Jul 2021 15:54:41 +0530 Message-ID: To: "Jayatheerthan, Jay" , Thomas Monjalon , David Marchand Cc: "Naga Harish K, S V" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay wrote: > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, July 28, 2021 3:01 PM > > To: Jayatheerthan, Jay > > Cc: Naga Harish K, S V ; dev@dpdk.org > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter > > > > > > > > > > > > > Signed-off-by: Naga Harish K, S V > > > > > > @Naga Harish K, S V Can we remove "," from the Signoff name. > > > > Some suggestions for consideration in preferred order. Let me know > > your preferred Signoff name, I will change it accordingly. > > > > Naga Harish > > > > or > > > > Naga Harish K > > > > or > > > > Naga Harish K S V > > This option is good. (Harish is out and hence I am responding) 1) Option 'Signed-off-by: Naga Harish K S V is warned by checkpatch [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1 ### eventdev: fix event port setup in Tx adapter WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Naga Harish K, S V" ' != 'Signed-off-by: Naga Harish K S V ' 2) Option 'Signed-off-by: Naga Harish K, S V ' is warning by check-git-log.sh [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1 Wrong tag: Signed-off-by: Naga Harish K, S V @thomas @David Marchand Could you suggest what Sign-off to take? > > > > > > > --- > > > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > index db260bfb68..18c0359db7 100644 > > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, > > > > return ret; > > > > } > > > > > > > > - pc->event_port_cfg = 0; > > > > ret = rte_event_port_setup(dev_id, port_id, pc); > > > > if (ret) { > > > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > > > > -- > > > > 2.25.1