From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35138A00C3; Thu, 14 May 2020 12:18:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13EF91D737; Thu, 14 May 2020 12:18:02 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 35A4F1D72C; Thu, 14 May 2020 12:18:00 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id h10so755501iob.10; Thu, 14 May 2020 03:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uCzOgZq1p6YaPT0P8ojiXVF106MKX1zcDhR4Pob7WUo=; b=lRmsj9+oMvBTBbsTumtuScXVqfQlsmGcdSfehK9JcLNAiIAhDjnbJdFbPvCvVUStLP woXU/rWFTDcOOPwT2OQvObwyxo3cqcT28mO872txXiEmhIbBg8MegUxtS2QAyVKZ/KQO LR0ckkByQs4Ph3YlIKhs9I1lb43rHzldy+GsrSpt1pnSYxyLCoFRWnr6vUnTmd9dQkl1 dME/DRhvCrOaPW3ASZUG58y1X0ri+PsRqPhjlGmlzdHjWHob1mYif1jIwYOIczpuDNSF JkkeD9fe2kep5pfBpJH1GUtV5AANtd4iDlDI3iEGYAgJzGv1u9dj/STtTCtwtgFwrVLY zkeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uCzOgZq1p6YaPT0P8ojiXVF106MKX1zcDhR4Pob7WUo=; b=B+iDfWFHR2kWLFAlDDB1JKxCAI9WpWsgU18ii26OWBRw0Xsk2AahiePGT0M9otwBb+ GkkvAw65YPvcWmQMYBIznrpjiHcCezSIW2ELQd8lk2vTz+SeyejwnTNHBTS7K5XwG2LB 583wII9KA6eI2ImZ3WrtCWkaVvkMttrLylok0mx0RlWxVo+Zh9rRJ61BpGVuFByi9QuG YZAUjZnmdHdGYT1M3Ruz9CAOfG0+2nP2OMu8HwfbOT8gvz6c5v/tX9LTFiXGw9Y4vIFC iD4nJcf3qSZgFEF6BPjZaJ4NHsh88ewVrLCFSZkt+i4ry/0EvkPOF29YLtUccmln84Mr +ZNA== X-Gm-Message-State: AOAM530N2twH3CvD/Wr5sINQ6ldSEsB5I0FjDhKkeQolMpALYO8iEV+r +x2fVDLKf8WW+JKVIhobDu7kRXrz7Jug/4j0tVA= X-Google-Smtp-Source: ABdhPJzr7MCfVZmeIdfmctob8pjgiD5yjZeCEkpYpNHjvZMx0Si+qNBU2KBgjhiSmJ+guCxUeF9ZsVTouumhl+rg1as= X-Received: by 2002:a6b:1543:: with SMTP id 64mr3436261iov.123.1589451479444; Thu, 14 May 2020 03:17:59 -0700 (PDT) MIME-Version: 1.0 References: <20200512004624.11114-1-rmody@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 14 May 2020 15:47:43 +0530 Message-ID: To: Rasesh Mody Cc: dpdk-dev , Jerin Jacob Kollanukkaran , Ferruh Yigit , GR-Everest-DPDK-Dev , dpdk stable , Shahed Shaikh , Igor Russkikh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/qede: fix link state configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 9:41 AM Rasesh Mody wrote: > > Hi Jerin, > > >From: Jerin Jacob > >Sent: Wednesday, May 13, 2020 9:25 AM > > > >On Tue, May 12, 2020 at 6:16 AM Rasesh Mody wrote: > >> > >> Move link state enable/disable to dev_start() and dev_stop() > >> respectively. This will ensure when devices are stopped, link status > >> will be appropriately shown as down. > >> > >> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") > > > >I assume you need this patch for -rc3. > >Please rebase the patch to dpdk-next-net-mrvl and send v2. > > Yes, this patch is for -rc3. > This patch had a dependency on https://patches.dpdk.org/patch/69737/. > I've submitted a v2 for this patch, please apply. Applied to dpdk-next-net-mrvl/master. Thanks > > Thanks! > -Rasesh > > > >log: > >git am -3 /tmp/to_merge/net-qede-fix-link-state-configuration > > > >Applying: net/qede: fix link state configuration > >error: sha1 information is lacking or useless > >(drivers/net/qede/qede_ethdev.c). > >error: could not build fake ancestor > >Patch failed at 0001 net/qede: fix link state configuration > >hint: Use 'git am --show-current-patch=diff' to see the failed patch When you > >have resolved this problem, run "git am --continue". > >If you prefer to skip this patch, run "git am --skip" instead. > >To restore the original branch and stop patching, run "git am --abort". > >HEAD is now at a8b8a8631 node: fix arm64 build with old gcc git am failed > >/tmp/g//net-qede-fix-link-state-configuration > >Wed 13 May 2020 09:51:26 PM IST > > > > > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Shahed Shaikh > >> Signed-off-by: Rasesh Mody > >> Signed-off-by: Igor Russkikh > >> --- > >> drivers/net/qede/qede_ethdev.c | 14 +++++++++----- > >> 1 file changed, 9 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/net/qede/qede_ethdev.c > >> b/drivers/net/qede/qede_ethdev.c index bcd8252d9..9a5847076 100644 > >> --- a/drivers/net/qede/qede_ethdev.c > >> +++ b/drivers/net/qede/qede_ethdev.c > >> @@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev > >*eth_dev) > >> if (qede_activate_vport(eth_dev, true)) > >> goto err; > >> > >> + /* Bring-up the link */ > >> + qede_dev_set_link_state(eth_dev, true); > >> + > >> /* Update link status */ > >> qede_link_update(eth_dev, 0); > >> > >> @@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev > >*eth_dev) > >> */ > >> qede_assign_rxtx_handlers(eth_dev, true); > >> > >> + /* Bring the link down */ > >> + qede_dev_set_link_state(eth_dev, false); > >> + > >> + /* Update link status */ > >> + qede_link_update(eth_dev, 0); > >> + > >> /* Disable vport */ > >> if (qede_activate_vport(eth_dev, false)) > >> return; > >> @@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev > >*eth_dev) > >> eth_dev->data->nb_rx_queues = 0; > >> eth_dev->data->nb_tx_queues = 0; > >> > >> - /* Bring the link down */ > >> - qede_dev_set_link_state(eth_dev, false); > >> qdev->ops->common->slowpath_stop(edev); > >> qdev->ops->common->remove(edev); > >> rte_intr_disable(&pci_dev->intr_handle); > >> @@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct > >> rte_eth_dev *eth_dev, bool is_vf) > >> > >> eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : > >> &qede_eth_dev_ops; > >> > >> - /* Bring-up the link */ > >> - qede_dev_set_link_state(eth_dev, true); > >> - > >> adapter->num_tx_queues = 0; > >> adapter->num_rx_queues = 0; > >> SLIST_INIT(&adapter->arfs_info.arfs_list_head); > >> -- > >> 2.18.0 > >> >