From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DBCD41C5D; Fri, 10 Feb 2023 08:06:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 448DB40EE6; Fri, 10 Feb 2023 08:06:43 +0100 (CET) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by mails.dpdk.org (Postfix) with ESMTP id 4720D40EE3 for ; Fri, 10 Feb 2023 08:06:41 +0100 (CET) Received: by mail-vs1-f52.google.com with SMTP id d66so4691701vsd.9 for ; Thu, 09 Feb 2023 23:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bfLAbH+7F4DqLXyEJmkUasEM2bcpZ7h1ocTCro+lVIw=; b=CQwRqSoqSvGDGSwUcZOO/LltlzQsrn6gRsRe47rDHTCgN8MrJ8wyXKh2/8fOHl0yvM Tk/OHjr8uPUZ8Ucukko+PztwfRbooTDdNlcb+J8TGBBsPjv/g+n4AgUiZwqxAh/TnYM2 w1XIxt0gM55OS9IaWtmjb11xWwt2QlFBOvlg5pS5VvhiwewmeK2ea1mH9EnR4fI2AXBi e6DnaLYlroCvhVvdkYYdsKAW/la1wad4sj0LdqCcKMWJLCLHw6Gf8Dn4SkE5b0p5dbF4 cB9DIjhQX1jiCwynTP8iYwvuP1vdJGUAVmjZUhONC0JXcPj9z+WCFP6decdhT64wRSEi Swmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bfLAbH+7F4DqLXyEJmkUasEM2bcpZ7h1ocTCro+lVIw=; b=3pOjzBR6PYtifqAAuG8xqLIjeN/NoEI7OGvtZCHfxdRqkP8J+/EMH4KOee6/L7HTxg 0LYVHpOxdCC6JqXSPuw+d6HP/MxBIAgK1LKaz8zzAKFAK8/V2QmP2KOBzQUxokBxwlAC I0G0IkAXQPPTtyGqdC0xqWh1nxwHRYXyuBizhebvOVCcBE9q0Y7UvjWmi5a2MFjATH5+ d7AffE/A+lkBc5oafFAC4YMdNhrZEgY0ptNXdQhZIf9HdyOL9GI4Yxu1/tXQhfQsdVQf IcKRipTKHGly6xmJhqqBCuloIf2qNRLfbj6hy5Kh3MjJlvCbo6nV0rGGXRM8a8jkOyWa nK6A== X-Gm-Message-State: AO0yUKU+4ozNwCiDEleKHROEDYC/nvOt+xXWV3m/J549qMLuNishPxWT dIT9p/WZWvkLgGTE0Ecfh0dELe2jPVTkrAtn2YU= X-Google-Smtp-Source: AK7set/VURWrAPsfgJOqqiUV0Gwe9SyOaBii50Ify4KxFJ2xzVqCf2Cj3WcDdePnmNKKQK8vhVTLw0v6JCz7syADLNQ= X-Received: by 2002:a67:de9a:0:b0:40f:b3a4:ccbc with SMTP id r26-20020a67de9a000000b0040fb3a4ccbcmr3172132vsk.45.1676012800653; Thu, 09 Feb 2023 23:06:40 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 10 Feb 2023 12:36:14 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: Ankur Dwivedi Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "ferruh.yigit@amd.com" , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > >wrote: > >> > >> The file rte_mempool_trace.h contains tracepoints which are internal > >> to the mempool library. This file is renamed to mempool_trace.h, and > >> is made an internal header. The tracepoints in this file are removed > >> from the experimental section in version.map file. > >> > >> Signed-off-by: Ankur Dwivedi > > > >> @@ -47,22 +47,8 @@ EXPERIMENTAL { > >> __rte_mempool_trace_generic_get; > >> __rte_mempool_trace_get_bulk; > >> __rte_mempool_trace_get_contig_blocks; > > > >I think, FP ones also can be removed. > > The FP symbols are used in header file rte_mempool.h. Removing the symbols will cause build > failure in shared build. OK. Please update the below note documentation only for FP symbols then. > > > >Also, in one of the patch(may be eal). Update the doc > >https://urldefense.proofpoint.com/v2/url?u=https- > >3A__doc.dpdk.org_guides_prog-5Fguide_trace- > >5Flib.html&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=ILjiNF3GF25y6QdHZU > >xMl6JrStU0MIuCtO5dMzn3Ybk&m=wr975- > >STqC3Y1eiGa9KZMdPdNKingEIEfZXvMkri8VO0p31eWWzr8kAoQC2TEIxV&s=g_ > >M3SEGmHvisHLnOLO8ilDQbVQ85MFRR2YCmCfYZ3SE&e= > > > >The following note can be removed: > > > >The RTE_TRACE_POINT_REGISTER defines the placeholder for the > >rte_trace_point_t tracepoint object. The user must export a > >__ symbol in the library .map file for this tracepoint to > >be used out of the library, in shared builds. For example, __app_trace_string > >will be the exported symbol in the above example. > > > > > > > >> - __rte_mempool_trace_create; > >> - __rte_mempool_trace_create_empty; > >> - __rte_mempool_trace_free; > >> - __rte_mempool_trace_populate_iova; > >> - __rte_mempool_trace_populate_virt; > >> - __rte_mempool_trace_populate_default; > >> - __rte_mempool_trace_populate_anon; > >> - __rte_mempool_trace_cache_create; > >> - __rte_mempool_trace_cache_free; > >> __rte_mempool_trace_default_cache; > >> - __rte_mempool_trace_get_page_size; > >> __rte_mempool_trace_cache_flush; > >> - __rte_mempool_trace_ops_populate; > >> - __rte_mempool_trace_ops_alloc; > >> - __rte_mempool_trace_ops_free; > >> - __rte_mempool_trace_set_ops_byname; > >> }; > >> > >> INTERNAL { > >> -- > >> 2.25.1 > >>