From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A4F4430AB; Mon, 13 Nov 2023 11:08:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28D9B402B7; Mon, 13 Nov 2023 11:08:25 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 817C2402AB for ; Mon, 13 Nov 2023 11:08:23 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6cd09f51fe0so2766087a34.1 for ; Mon, 13 Nov 2023 02:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699870102; x=1700474902; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h8n43f6E7auOpOoJ+fGl5Hb2pVuldvApQzsWBh9I9jw=; b=mM1WXjAbK+7QeozYZema63Hv42mbRfd6a6IJpfur+uEgwPT45okmkP0aDFic9t1dEV VQ68/RjCba8k2aUGLUJJnFv0oy0n35/aqs6+HdL2zeM+EH2+yFxnnAp8O2lSJhAesjyg uiUE+F84NW0Q4XYwftCc69T2QA0eVDSCUcPgQxo9zU4Kkr0weicWBpZPQBEBe6bfGh3n 4daha07o6AcETMEMq3A+M6vMj4Is5hK6kgAGcDbgA2i9HJ0AuNU+aP+hCtzunKY4f7Fs CHMBGhInjPK/Xgji9LcZ39qrccslHpSjOIVpGz5niT4RHuiiFvwvCbZK+kvYp/cpUZM/ Fa0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699870102; x=1700474902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8n43f6E7auOpOoJ+fGl5Hb2pVuldvApQzsWBh9I9jw=; b=VgfMuxWVybN9HkYSvJ+rYiB7pdjw4aJ+3y56jRJUwMdkqHwMr191gd7t1s2aQ2E8XB pJkOJwU7F5wsrt1VcYPNcSr7+p4FGRsewTqL1vvKQSK+5uN2ReUksxYtal5+nASEzlFY 5AZwOvIzRWXs5JOZM1C0S3bwn5UzMUultjjzuw7uueubcMCJzRIuztXXL0SOvqE16LdO sSj3shNZc5BY1gsfH9knRojIfaZiOnist4KH96jK0NWiLoU6vlatrVZTh8sD4XS8pc9Q zuuqKAgo/ktifcrezzfVi5fnHeF3u7K/Vffwwwmwstqa3trCtNHSGphUyUXB8xpSe9jp 6peA== X-Gm-Message-State: AOJu0Yy7hroI+aMyqFpvyV/WJlfaJpyR7Z5HlTkvBpgDd2PlGnaskIjm wE+1kz2N1HNwz5QAz/Mlp7p8ZUasn62+fWQoY+w= X-Google-Smtp-Source: AGHT+IE9o0mj+pH4o2/imqkygCP4S4fSutKDIwjSJeajgOfQ79TI2E7uoaJLfDUBBuQtGgvSBmXugGC2mKP++LYeHPw= X-Received: by 2002:a05:6358:785:b0:168:e7f4:8fc9 with SMTP id n5-20020a056358078500b00168e7f48fc9mr5887324rwj.24.1699870102583; Mon, 13 Nov 2023 02:08:22 -0800 (PST) MIME-Version: 1.0 References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024025422.126021-1-stephen@networkplumber.org> <20231024025422.126021-24-stephen@networkplumber.org> In-Reply-To: From: Jerin Jacob Date: Mon, 13 Nov 2023 15:37:56 +0530 Message-ID: Subject: Re: [PATCH v7 23/25] node: remove some of the experimental tags To: David Marchand Cc: Stephen Hemminger , Nithin Dabilpuram , Pavan Nikhilesh , dev@dpdk.org, Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Nov 12, 2023 at 8:29=E2=80=AFPM David Marchand wrote: > > On Tue, Oct 24, 2023 at 4:57=E2=80=AFAM Stephen Hemminger > wrote: > > > > The node library has been around long enough that experimental > > tag should be removed. The IPv6 support was added in 23.03 > > but that is still enough time that it can be marked stable. > > > > The logtype variable should have been marked internal > > since it is not intended to be used outside of library. > > There is, even, no need to export this symbol in the first place. > > $ git grep -lw rte_node_logtype > lib/node/log.c > lib/node/node_private.h > > $ git grep -lw node_private.h '**.h' > > > We only need to remove rte_node_logtype from version.map. > This can be fixed when applying. > > > > > Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob > > > -- > David Marchand >