DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
@ 2020-10-26 16:01 Timothy McDaniel
  2020-10-28  9:35 ` Jerin Jacob
  2020-10-30 20:03 ` Eads, Gage
  0 siblings, 2 replies; 5+ messages in thread
From: Timothy McDaniel @ 2020-10-26 16:01 UTC (permalink / raw)
  To: Bruce Richardson
  Cc: dev, erik.g.carrillo, gage.eads, harry.van.haaren, jerinj

DLB supports a total of 256 queues, 128 load balanced queues
and 128 directed queues.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/rte_config.h b/config/rte_config.h
index 8aa46a1..b78c6aa 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -71,7 +71,7 @@
 
 /* eventdev defines */
 #define RTE_EVENT_MAX_DEVS 16
-#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
+#define RTE_EVENT_MAX_QUEUES_PER_DEV 255
 #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
-- 
2.6.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
  2020-10-26 16:01 [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255 Timothy McDaniel
@ 2020-10-28  9:35 ` Jerin Jacob
  2020-10-28 14:52   ` McDaniel, Timothy
  2020-10-30 20:03 ` Eads, Gage
  1 sibling, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2020-10-28  9:35 UTC (permalink / raw)
  To: Timothy McDaniel
  Cc: Bruce Richardson, dpdk-dev, Erik Gabriel Carrillo, Gage Eads,
	Van Haaren, Harry, Jerin Jacob

On Mon, Oct 26, 2020 at 9:29 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> DLB supports a total of 256 queues, 128 load balanced queues
> and 128 directed queues.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  config/rte_config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 8aa46a1..b78c6aa 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -71,7 +71,7 @@
>
>  /* eventdev defines */
>  #define RTE_EVENT_MAX_DEVS 16
> -#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
> +#define RTE_EVENT_MAX_QUEUES_PER_DEV 255

If it is 0..255 then this value should be 256. Isn't it?


>  #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
>  #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
>  #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
> --
> 2.6.4
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
  2020-10-28  9:35 ` Jerin Jacob
@ 2020-10-28 14:52   ` McDaniel, Timothy
  0 siblings, 0 replies; 5+ messages in thread
From: McDaniel, Timothy @ 2020-10-28 14:52 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Richardson, Bruce, dpdk-dev, Carrillo, Erik G, Eads, Gage,
	Van Haaren, Harry, Jerin Jacob



> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, October 28, 2020 4:36 AM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dpdk-dev
> <dev@dpdk.org>; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> Jerin Jacob <jerinj@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV
> to 255
> 
> On Mon, Oct 26, 2020 at 9:29 PM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> > DLB supports a total of 256 queues, 128 load balanced queues
> > and 128 directed queues.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> >  config/rte_config.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/rte_config.h b/config/rte_config.h
> > index 8aa46a1..b78c6aa 100644
> > --- a/config/rte_config.h
> > +++ b/config/rte_config.h
> > @@ -71,7 +71,7 @@
> >
> >  /* eventdev defines */
> >  #define RTE_EVENT_MAX_DEVS 16
> > -#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
> > +#define RTE_EVENT_MAX_QUEUES_PER_DEV 255
> 
> If it is 0..255 then this value should be 256. Isn't it?
> 

.max_event_queues is a uint8_t, so we could not go to 256 without changing the
data structure.

> 
> >  #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
> >  #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
> >  #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
> > --
> > 2.6.4
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
  2020-10-26 16:01 [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255 Timothy McDaniel
  2020-10-28  9:35 ` Jerin Jacob
@ 2020-10-30 20:03 ` Eads, Gage
  2020-10-31 10:58   ` Jerin Jacob
  1 sibling, 1 reply; 5+ messages in thread
From: Eads, Gage @ 2020-10-30 20:03 UTC (permalink / raw)
  To: McDaniel, Timothy, Richardson, Bruce
  Cc: dev, Carrillo, Erik G, Van Haaren, Harry, jerinj



> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Sent: Monday, October 26, 2020 11:01 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com
> Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
> 
> DLB supports a total of 256 queues, 128 load balanced queues
> and 128 directed queues.
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>

Perhaps you can increase the queues-related fields to uint16_t in the future
to allow for the full 256, but in the meantime:

Reviewed-by: Gage Eads <gage.eads@intel.com>

Thanks,
Gage

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
  2020-10-30 20:03 ` Eads, Gage
@ 2020-10-31 10:58   ` Jerin Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2020-10-31 10:58 UTC (permalink / raw)
  To: Eads, Gage
  Cc: McDaniel, Timothy, Richardson, Bruce, dev, Carrillo, Erik G,
	Van Haaren, Harry, jerinj

On Sat, Oct 31, 2020 at 1:34 AM Eads, Gage <gage.eads@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> > Sent: Monday, October 26, 2020 11:01 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> > <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > jerinj@marvell.com
> > Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
> >
> > DLB supports a total of 256 queues, 128 load balanced queues
> > and 128 directed queues.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
>
> Perhaps you can increase the queues-related fields to uint16_t in the future
> to allow for the full 256, but in the meantime:
>
> Reviewed-by: Gage Eads <gage.eads@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-eventdev/for-main with following git commit change, Thanks.

commit e79fdca1baaff30cbdd423b1fec82087cafc0b83 (HEAD -> for-main,
origin/for-main, origin/HEAD)
Author: Timothy McDaniel <timothy.mcdaniel@intel.com>
Date:   Mon Oct 26 11:01:08 2020 -0500

    eventdev: increase max queues configuration

    DLB supports a total of 256 queues, 128 load balanced queues
    and 128 directed queues. Increase RTE_EVENT_MAX_QUEUES_PER_DEV
    to max possible uint_8_t max value.

    Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
    Reviewed-by: Gage Eads <gage.eads@intel.com>
    Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> Thanks,
> Gage

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-31 10:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 16:01 [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255 Timothy McDaniel
2020-10-28  9:35 ` Jerin Jacob
2020-10-28 14:52   ` McDaniel, Timothy
2020-10-30 20:03 ` Eads, Gage
2020-10-31 10:58   ` Jerin Jacob

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git