From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44EB9A00C4; Wed, 28 Sep 2022 15:51:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB3BB4113C; Wed, 28 Sep 2022 15:51:20 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 2B9A2410FA for ; Wed, 28 Sep 2022 15:51:20 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id p3so2623852qvz.6 for ; Wed, 28 Sep 2022 06:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=7K/HgX+LfArYVOeNN0/w+X5Sk8SHyWTauGKvGlWSVcw=; b=Jgp3rsIT6NPvaO606AmELWEq7d14tIc9RDjCzuvIuNGls9omoEpLutO2jfMzWiBwTb Z6muIURGEtmac4IFn8iwryjixS5m6fSyb/XF6ZQB4N2mItfuDDiw3iPD0Wl3X19Ts5MZ HAExCzmpxWA8iFxOM/cc1PEzZVskXU2P73Kc1zeDoKMC+XYK5eBwLW3/m5erws3FJ2sk YtPc+2s7P3sHCZ2HGAxfAb0BL8n3lPtmnpxZONsgxCR9irdpYj+lSNIBGJ+hnoJxf3jQ rmJYpRVL0ysQLLvYBL8v1ZSvWuTZL907lasqurPDXihFYMyIspxAeMVYWBa7saXq0nEa 82IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=7K/HgX+LfArYVOeNN0/w+X5Sk8SHyWTauGKvGlWSVcw=; b=bzxir+paNWnFSBUfx8jNPJZB32u06+Y8YlZS3/t6p+j6aY+aDhvM3avg1nXPpwBdOB hNLnsKx+LKrIVjS4RcyAcwW/+5FYWivmDoYqQM2tAkm3EyMR4eo/MESw38tC08HJRC3w xffV62JvWeD7W2phNEQHd8nhz0iUZOAbkD5PzH5dnqDUBHQFvclCr2b0rsYdPRk9nbeo qQPv6vjfgPs1Z/4oW+MsFkK0b2ReCwlo4dFQtzqpFZFHkHR/COs9rjVp2TYa1taaAQ6D T3Uce6AhP0rL1EH5f+qlQ+MV0Iihm+ABziJV/o2W3HznCBKJseCBek7xdg+R7323f6Tm vyZw== X-Gm-Message-State: ACrzQf0oclA/sUIGpYwjuBZtPNHpS4PlnySfNlqZ31rbrpJcraXBw0FJ W95vj/tkUiPWFEVO4A4c/+IZ1CAE8H7wdC2RP7c= X-Google-Smtp-Source: AMsMyM5G+Lrc6gdukUyxsupP+AahPUPAqfcX0y826EqWvw1+DVhv/5TebTuF5DEuOLFIzWZIDR4SN3vNPyBp6rdJ0Go= X-Received: by 2002:a0c:f3d3:0:b0:4a0:86d9:1807 with SMTP id f19-20020a0cf3d3000000b004a086d91807mr26339804qvm.19.1664373079399; Wed, 28 Sep 2022 06:51:19 -0700 (PDT) MIME-Version: 1.0 References: <20220926150548.5076-1-pbhagavatula@marvell.com> In-Reply-To: <20220926150548.5076-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Wed, 28 Sep 2022 19:20:53 +0530 Message-ID: Subject: Re: [PATCH] app/eventdev: fix incorrect cleanup check To: pbhagavatula@marvell.com Cc: jerinj@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 26, 2022 at 8:35 PM wrote: > > From: Pavan Nikhilesh > > During cleanup `rte_event_port_quiesce` should be called > irrespective of whether an event has been dequeued or not > to flush any prefetched events. > > Fixes: 7da008df0c8d ("app/eventdev: use port quiescing") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > app/test-eventdev/test_pipeline_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 4f40d37659..22a3918ed8 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[], > { > int i; > > - if (!(deq - enq)) > - return; > - > if (deq) { > for (i = enq; i < deq; i++) { > if (ev[i].op == RTE_EVENT_OP_RELEASE) > -- > 2.25.1 >