* [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action
@ 2023-03-13 5:24 psatheesh
2023-03-13 5:24 ` [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy psatheesh
2023-04-04 7:30 ` [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action Jerin Jacob
0 siblings, 2 replies; 4+ messages in thread
From: psatheesh @ 2023-03-13 5:24 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Kiran Kumar K <kirankumark@marvell.com>
Support SPI to SA index translation action with
SPI bits MS_28_25.
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Reviewed-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 4 ++++
drivers/common/cnxk/roc_npc.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 47536c8ce8..7228cffb57 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -438,6 +438,10 @@ npc_parse_spi_to_sa_action(struct roc_npc *roc_npc, const struct roc_npc_action
vtag_act.act.vtag1_lid = ROC_NPC_SEC_ACTION_ALG2;
break;
case ROC_NPC_SEC_ACTION_ALG3:
+ vtag_act.act.vtag1_valid = false;
+ vtag_act.act.vtag1_lid = ROC_NPC_SEC_ACTION_ALG3;
+ break;
+ case ROC_NPC_SEC_ACTION_ALG4:
vtag_act.act.vtag1_valid = false;
vtag_act.act.vtag1_lid = 0;
mbox = inl_dev->dev.mbox;
diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h
index 61d0628f5f..26a43c12cb 100644
--- a/drivers/common/cnxk/roc_npc.h
+++ b/drivers/common/cnxk/roc_npc.h
@@ -235,6 +235,7 @@ enum roc_npc_sec_action_alg {
ROC_NPC_SEC_ACTION_ALG1,
ROC_NPC_SEC_ACTION_ALG2,
ROC_NPC_SEC_ACTION_ALG3,
+ ROC_NPC_SEC_ACTION_ALG4,
};
struct roc_npc_sec_action {
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy
2023-03-13 5:24 [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action psatheesh
@ 2023-03-13 5:24 ` psatheesh
2023-03-15 5:52 ` Jerin Jacob
2023-04-04 7:30 ` [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action Jerin Jacob
1 sibling, 1 reply; 4+ messages in thread
From: psatheesh @ 2023-03-13 5:24 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul
From: Satheesh Paul <psatheesh@marvell.com>
While destroying SPI to SA index rule, inline device
mbox should be used. Adding changes to fix this.
Fixes: 04087b781484 ("common/cnxk: support SPI to SA index")
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 14 ++++++++++----
drivers/common/cnxk/roc_npc_mcam.c | 8 ++++----
2 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 7228cffb57..ba75207955 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1503,16 +1503,22 @@ npc_rss_group_free(struct npc *npc, struct roc_npc_flow *flow)
static int
roc_npc_delete_spi_to_sa_action(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
{
- struct roc_nix *roc_nix = roc_npc->roc_nix;
struct nix_spi_to_sa_delete_req *req;
+ struct nix_inl_dev *inl_dev;
+ struct idev_cfg *idev;
struct mbox *mbox;
- struct nix *nix;
+
+ PLT_SET_USED(roc_npc);
if (!flow->spi_to_sa_info.has_action || flow->spi_to_sa_info.duplicate)
return 0;
- nix = roc_nix_to_nix_priv(roc_nix);
- mbox = (&nix->dev)->mbox;
+ idev = idev_get_cfg();
+ if (!idev)
+ return -1;
+
+ inl_dev = idev->nix_inl_dev;
+ mbox = inl_dev->dev.mbox;
req = mbox_alloc_msg_nix_spi_to_sa_delete(mbox);
if (req == NULL)
return -ENOSPC;
diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
index 948c446312..72892be300 100644
--- a/drivers/common/cnxk/roc_npc_mcam.c
+++ b/drivers/common/cnxk/roc_npc_mcam.c
@@ -96,10 +96,10 @@ int
npc_mcam_free_all_entries(struct npc *npc)
{
struct npc_mcam_free_entry_req *req;
- struct mbox *mbox = npc->mbox;
+ struct mbox *mbox = mbox_get(npc->mbox);
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_free_entry(mbox_get(mbox));
+ req = mbox_alloc_msg_npc_mcam_free_entry(mbox);
if (req == NULL)
goto exit;
req->all = 1;
@@ -354,10 +354,10 @@ npc_mcam_alloc_entry(struct npc *npc, struct roc_npc_flow *mcam,
{
struct npc_mcam_alloc_entry_req *req;
struct npc_mcam_alloc_entry_rsp *rsp;
- struct mbox *mbox = npc->mbox;
+ struct mbox *mbox = mbox_get(npc->mbox);
int rc = -ENOSPC;
- req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox_get(mbox));
+ req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox);
if (req == NULL)
goto exit;
req->contig = 1;
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy
2023-03-13 5:24 ` [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy psatheesh
@ 2023-03-15 5:52 ` Jerin Jacob
0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2023-03-15 5:52 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, dev
On Mon, Mar 13, 2023 at 10:54 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> While destroying SPI to SA index rule, inline device
> mbox should be used. Adding changes to fix this.
>
> Fixes: 04087b781484 ("common/cnxk: support SPI to SA index")
Merged only 2/2 for rc3 as it is a fix.
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> ---
> drivers/common/cnxk/roc_npc.c | 14 ++++++++++----
> drivers/common/cnxk/roc_npc_mcam.c | 8 ++++----
> 2 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
> index 7228cffb57..ba75207955 100644
> --- a/drivers/common/cnxk/roc_npc.c
> +++ b/drivers/common/cnxk/roc_npc.c
> @@ -1503,16 +1503,22 @@ npc_rss_group_free(struct npc *npc, struct roc_npc_flow *flow)
> static int
> roc_npc_delete_spi_to_sa_action(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
> {
> - struct roc_nix *roc_nix = roc_npc->roc_nix;
> struct nix_spi_to_sa_delete_req *req;
> + struct nix_inl_dev *inl_dev;
> + struct idev_cfg *idev;
> struct mbox *mbox;
> - struct nix *nix;
> +
> + PLT_SET_USED(roc_npc);
>
> if (!flow->spi_to_sa_info.has_action || flow->spi_to_sa_info.duplicate)
> return 0;
>
> - nix = roc_nix_to_nix_priv(roc_nix);
> - mbox = (&nix->dev)->mbox;
> + idev = idev_get_cfg();
> + if (!idev)
> + return -1;
> +
> + inl_dev = idev->nix_inl_dev;
> + mbox = inl_dev->dev.mbox;
> req = mbox_alloc_msg_nix_spi_to_sa_delete(mbox);
> if (req == NULL)
> return -ENOSPC;
> diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
> index 948c446312..72892be300 100644
> --- a/drivers/common/cnxk/roc_npc_mcam.c
> +++ b/drivers/common/cnxk/roc_npc_mcam.c
> @@ -96,10 +96,10 @@ int
> npc_mcam_free_all_entries(struct npc *npc)
> {
> struct npc_mcam_free_entry_req *req;
> - struct mbox *mbox = npc->mbox;
> + struct mbox *mbox = mbox_get(npc->mbox);
> int rc = -ENOSPC;
>
> - req = mbox_alloc_msg_npc_mcam_free_entry(mbox_get(mbox));
> + req = mbox_alloc_msg_npc_mcam_free_entry(mbox);
> if (req == NULL)
> goto exit;
> req->all = 1;
> @@ -354,10 +354,10 @@ npc_mcam_alloc_entry(struct npc *npc, struct roc_npc_flow *mcam,
> {
> struct npc_mcam_alloc_entry_req *req;
> struct npc_mcam_alloc_entry_rsp *rsp;
> - struct mbox *mbox = npc->mbox;
> + struct mbox *mbox = mbox_get(npc->mbox);
> int rc = -ENOSPC;
>
> - req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox_get(mbox));
> + req = mbox_alloc_msg_npc_mcam_alloc_entry(mbox);
> if (req == NULL)
> goto exit;
> req->contig = 1;
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action
2023-03-13 5:24 [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action psatheesh
2023-03-13 5:24 ` [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy psatheesh
@ 2023-04-04 7:30 ` Jerin Jacob
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2023-04-04 7:30 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, dev
On Mon, Mar 13, 2023 at 10:54 AM <psatheesh@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Support SPI to SA index translation action with
> SPI bits MS_28_25.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Reviewed-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/roc_npc.c | 4 ++++
> drivers/common/cnxk/roc_npc.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
> index 47536c8ce8..7228cffb57 100644
> --- a/drivers/common/cnxk/roc_npc.c
> +++ b/drivers/common/cnxk/roc_npc.c
> @@ -438,6 +438,10 @@ npc_parse_spi_to_sa_action(struct roc_npc *roc_npc, const struct roc_npc_action
> vtag_act.act.vtag1_lid = ROC_NPC_SEC_ACTION_ALG2;
> break;
> case ROC_NPC_SEC_ACTION_ALG3:
> + vtag_act.act.vtag1_valid = false;
> + vtag_act.act.vtag1_lid = ROC_NPC_SEC_ACTION_ALG3;
> + break;
> + case ROC_NPC_SEC_ACTION_ALG4:
> vtag_act.act.vtag1_valid = false;
> vtag_act.act.vtag1_lid = 0;
> mbox = inl_dev->dev.mbox;
> diff --git a/drivers/common/cnxk/roc_npc.h b/drivers/common/cnxk/roc_npc.h
> index 61d0628f5f..26a43c12cb 100644
> --- a/drivers/common/cnxk/roc_npc.h
> +++ b/drivers/common/cnxk/roc_npc.h
> @@ -235,6 +235,7 @@ enum roc_npc_sec_action_alg {
> ROC_NPC_SEC_ACTION_ALG1,
> ROC_NPC_SEC_ACTION_ALG2,
> ROC_NPC_SEC_ACTION_ALG3,
> + ROC_NPC_SEC_ACTION_ALG4,
> };
>
> struct roc_npc_sec_action {
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-04 7:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-13 5:24 [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action psatheesh
2023-03-13 5:24 ` [dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy psatheesh
2023-03-15 5:52 ` Jerin Jacob
2023-04-04 7:30 ` [dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).