From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1247841C61; Fri, 10 Feb 2023 16:33:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F60C410EA; Fri, 10 Feb 2023 16:33:15 +0100 (CET) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by mails.dpdk.org (Postfix) with ESMTP id 16B8C410D3 for ; Fri, 10 Feb 2023 16:33:15 +0100 (CET) Received: by mail-vs1-f48.google.com with SMTP id k4so6030309vsc.4 for ; Fri, 10 Feb 2023 07:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sQic+F/2pQTR4bFLqM6T0rZG7qOJW1OEDZNHIGhT6tY=; b=DfJz9I1O4kGzKn3B+cGpH9eBNd9pIBC+qq2K7JU0PFmmmAeAzyS3/SRCaxH5a6ULui uEXlh9wdW74JO7I5OYLnT0rAe21g2eE7X7zbAFdRKsBtYF0UENyBP1bnkwMWS+cSh2bg PNghAldL3Qbksg1WlE85mVYxCJDdCtxvTrI1A3Lm3i2c1qYC1IEyqMAcDaqt8tCfSpRy v32XXdK4bdFurdoftuTZLL0aHh6OTySM1wyMsP2SMob5tHbr2v+fYaLel0vpdQmvWKP9 5hxk5Z6EZdEweyzBVfHr0zP44mIvP8Bsl8tfJayMs1yid1nqBfptRnpC5Ptnvnra8C4h 42zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sQic+F/2pQTR4bFLqM6T0rZG7qOJW1OEDZNHIGhT6tY=; b=EHUKRRvyiNdTR4/MOA863RQyPcf4PGw3iwvE0jEuq+5KzqqbkFuN/GfzdNt/2P1wUZ KbUYRAxBsk1POPszQpiWWPiYQsntqKfhmlP5cP3h7iOUgwEa2L0Fm9+XEwn2diHpkcf+ eEz+2ZfWq17RwsnHqij1Dp4JKoLLIbT71VjlHbPEpJdejFK8MtL/3aJKJy72fy2qMt7s wRpS6jZKC3B+Ky4U+I9BPyLhkZti7M8Dt6mMVEmdrgryoX28DV1s0rpiFo6L5Zyi7jKL XoLt+EhIXsSmveCWPO91aP5fZ59sPF0ui893QtbNRJdSy/XET7VWLzcOrHyheNaTndAx 5wAQ== X-Gm-Message-State: AO0yUKVGpzO8/mYEP97w6ZN4NhFX001cFASVpo3sdDw2fDuTbBuQtfrH LbU8dm7gsqhP+paw2ZaxnQnBF7qtfN8T4Mt4fWA= X-Google-Smtp-Source: AK7set85d9FJnFLEdNhXJbSMentT1BCY3GMKV2R2qDiT1WdxtoC3Y+2eEsQByCYmjb0+dSdiyxAEOMZGolxI9sa3vik= X-Received: by 2002:a05:6102:5c1a:b0:3fe:3011:1976 with SMTP id ds26-20020a0561025c1a00b003fe30111976mr3305324vsb.52.1676043194414; Fri, 10 Feb 2023 07:33:14 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 10 Feb 2023 21:02:48 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: David Marchand Cc: Ankur Dwivedi , "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 7:54 PM David Marchand wrote: > > On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > > >wrote: > > > >> > > > >> The file rte_mempool_trace.h contains tracepoints which are internal > > > >> to the mempool library. This file is renamed to mempool_trace.h, and > > > >> is made an internal header. The tracepoints in this file are removed > > > >> from the experimental section in version.map file. > > > >> > > > >> Signed-off-by: Ankur Dwivedi > > > > > > > >> @@ -47,22 +47,8 @@ EXPERIMENTAL { > > > >> __rte_mempool_trace_generic_get; > > > >> __rte_mempool_trace_get_bulk; > > > >> __rte_mempool_trace_get_contig_blocks; > > > > > > > >I think, FP ones also can be removed. > > > > > > The FP symbols are used in header file rte_mempool.h. Removing the symbols will cause build > > > failure in shared build. > > > > OK. Please update the below note documentation only for FP symbols then. > > I disagree. > > We may enhance this note, but it is not a matter of being FP / non-FP. > A simple example is the "generic" non-FP tracepoints provided by EAL. OK. Then what's your recommendation for the document update ? Generic datatype exposed by EAL trace library or FP trace point object. or something else? I am trying to see what needs to be added/changed in documentation? > > > -- > David Marchand >