From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EF11A04B3; Tue, 28 Jan 2020 10:59:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB2F71C1AB; Tue, 28 Jan 2020 10:59:31 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 49DAC1C122; Tue, 28 Jan 2020 10:59:30 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id h8so13565698iob.2; Tue, 28 Jan 2020 01:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1vcP4LR8/uA4tOsyYPbIa6Y+ucP4Jd9dILda+hoyZ2I=; b=P9xntucOg42CkFI1usyrnvcG/EariZ0eu0L/ORffxF4vCx82+eAYdQsdRaxNir0oMc UGmhZhhZXjNU7epCtY9RzBHh/MynfKA+2Oz6au/OhS3074acfC8VocJ92VK7mY3CzQdN Uoo6jpNN2W8S5RC+Mc56zcRZr/kbiUaMaROQNv1RktWzY8oz2pkn7s/y8jJD6SIwHqFc r9P1pG+IbjBmbAJIH6QJpfevU+Fpcp6wfzFK5deWQzQGEkeoUDr2YpXb4v1JG+jhTB+z jY0nPwYe983LNbDUtH8HzZ/TXNoTcB04Br+pqrCGOME6LH8WQlrLMqzvaKpzizetzeqx XTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1vcP4LR8/uA4tOsyYPbIa6Y+ucP4Jd9dILda+hoyZ2I=; b=Yhx/wWG5UkPYzdS0OmjedJIt9aVxgPeRKeOySnlcPeHUDnaa976N9JPa7z0lX84z9Q bPZA3gKybgVcgzomGZpHQ+0UEqu/ERLr9CiHPsHtRsL6/4kr1PxW+OGpzOvihdy0f7t5 GCGnZhpV1/FTZFLD9p/wDGd70/e3qJAeNQ1mZ9MIInQ0zpN+IXtvft6VlfcLsafGOGhS NNxDV3BGQlaJuXmahIx7CyloIea0Wj0ZbblduKkVe2shyMkEc1QGPp5L31Q56IAzyn6D kwRYkPQD3bP1+zbGOpThwjJi9awvquSqaqvnB8kmmIvdrYy/cvGMVfDrrkA7Xoj5NzB+ nBSw== X-Gm-Message-State: APjAAAU8eX/ukF8BN7VmjXiY5Fp2/uQ2gbwRehPITW+6qxBN7RgnGqQV RAJQKFdeGEDmS+stslGUkuBVtdc5vr5sKYb8WjQ= X-Google-Smtp-Source: APXvYqxQVZ3Ce++vUshg9mRsc+95U8kwNpaGr/EzKlmTzhZTSig2C/gcKivD6lN1vmTYsMi5WQ7zXGJBDc55iqCrXxE= X-Received: by 2002:a02:7715:: with SMTP id g21mr16118734jac.104.1580205569467; Tue, 28 Jan 2020 01:59:29 -0800 (PST) MIME-Version: 1.0 References: <20200114003920.17705-1-rmody@marvell.com> <20200126225419.23919-1-rmody@marvell.com> In-Reply-To: <20200126225419.23919-1-rmody@marvell.com> From: Jerin Jacob Date: Tue, 28 Jan 2020 15:29:13 +0530 Message-ID: To: Rasesh Mody Cc: dpdk-dev , Jerin Jacob , Ferruh Yigit , GR-Everest-DPDK-Dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/bnx2x: fix reset of scan FP flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 27, 2020 at 4:24 AM Rasesh Mody wrote: > > The fastpath task queue handler resets the fastpath scan flag > unconditionally, this patch changes that to reset the flag > only if it was set. > > Fixes: 08a6e472c3d7 ("net/bnx2x: fix packet drop") > Cc: stable@dpdk.org > > Signed-off-by: Rasesh Mody Series applied to dpdk-next-net-mrvl/master. Thanks. > --- > drivers/net/bnx2x/bnx2x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > index ed31335ac..50e289b28 100644 > --- a/drivers/net/bnx2x/bnx2x.c > +++ b/drivers/net/bnx2x/bnx2x.c > @@ -4577,10 +4577,10 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp) > bnx2x_handle_fp_tq(fp); > return; > } > + /* We have completed slow path completion, clear the flag */ > + rte_atomic32_set(&sc->scan_fp, 0); > } > > - /* Assuming we have completed slow path completion, clear the flag */ > - rte_atomic32_set(&sc->scan_fp, 0); > bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, > le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); > } > -- > 2.18.0 >