From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36358423BC; Fri, 13 Jan 2023 05:37:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2851F410EF; Fri, 13 Jan 2023 05:37:12 +0100 (CET) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by mails.dpdk.org (Postfix) with ESMTP id E60A5410D4 for ; Fri, 13 Jan 2023 05:37:10 +0100 (CET) Received: by mail-vs1-f44.google.com with SMTP id k6so12253948vsk.1 for ; Thu, 12 Jan 2023 20:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U1HxZ2AdOsxTfYcgJ+aQUM5mSHgw7cPLbJ24BoCAGcY=; b=UHyVLs/AR95bwVpHoJa4ExsKJq0izu5fQTKUkmgxRwG4umR/I5p5kQQ0GMtNx0TLi9 LzNo6B+o6w8IE0/BIhx4A279r7sQ78KTsZinCHmouHx7M0/RRmHuMK6e8/jx6QrBJ3yO DPo3K5cvza/oepouBtdJKI7/gW/n824NfonPUyOhwdk2R7IAf/26DCUFiUULi1/i0k8o AbgAMqcmxqWbLNxorOi4vAJofVFwxPW98QTbAIMDJ5tsFcQ4j2pV+upBs79nnU+36Dxk /vhq2KbfSFNHH+Cwv9L4jKCxQrdUMbPQqUFomWQwd2vZ8jxWghOnORCp4xYJfZ5QFbM8 ovww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U1HxZ2AdOsxTfYcgJ+aQUM5mSHgw7cPLbJ24BoCAGcY=; b=uAzhs4H2Rvx3v5KVCAx7VILjT7Bt+nJHfPLKsV1/kODsQYirShC9hN1Q0uBCrYTDDF JBGjWR51kJ6cwlWzTd4zv5+EYndcGG2l2TPDVCooP53g7/LYcY2CvJ6rAadwbOHAd0op 3x6ANF2G+y3mdAx8klwa1B66qdSW23ct893byQVLOKYnfsXLpISe9kJU27ar77Tt7Uzb 4Mf1QI7MUEX/23sCdE3l/EJaTw1ct/TIL8PzKwZe+A1EY7mrMcQP7kcqsQsRO9GAYxVH VRcwFrmPOmayi79SEuGja4LX0lih1kifWnhjIHEXf5EfGTOzn4lqMkNhg3n7hCZaMvEJ t1dw== X-Gm-Message-State: AFqh2kpT+EVRQLGf/bN9xXJ68nz4Fp76yFU8e5DHnjmw99YNykld7QGT LwuJU6LwmvgSlK/A0q7JNEHBa+8OEGwzwCfKd6g= X-Google-Smtp-Source: AMrXdXs/mnWyQ9aWy6CDXDtHUKW3//+sccznjopAuV9j0w3o7khikyxQlrZBk59fkzjrA9Prnb93VwwmXuQJXId3bTM= X-Received: by 2002:a67:fd97:0:b0:3d0:bfd2:3a12 with SMTP id k23-20020a67fd97000000b003d0bfd23a12mr2155642vsq.52.1673584630253; Thu, 12 Jan 2023 20:37:10 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1671036441-10234-1-git-send-email-roretzla@linux.microsoft.com> <1671036441-10234-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: From: Jerin Jacob Date: Fri, 13 Jan 2023 10:06:44 +0530 Message-ID: Subject: Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread To: David Marchand Cc: Tyler Retzlaff , Jerin Jacob Kollanukkaran , Sunil Kumar Kori , dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com, stephen@networkplumber.org, mb@smartsharesystems.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 11, 2023 at 9:39 PM David Marchand wrote: > > On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff > wrote: > > diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c > > index 5caaac8..89522dc 100644 > > --- a/lib/eal/common/eal_common_trace.c > > +++ b/lib/eal/common/eal_common_trace.c > > @@ -356,8 +356,6 @@ rte_trace_mode rte_trace_mode_get(void) > > /* Store the thread name */ > > char *name = header->stream_header.thread_name; > > memset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX); > > - rte_thread_getname(pthread_self(), name, > > - __RTE_TRACE_EMIT_STRING_LEN_MAX); > > > > trace->lcore_meta[count].mem = header; > > trace->nb_trace_mem_list++; > > Note, this belongs to patch 2. > > I understand we can drop the thread name retrieval helper from public > API, but at least for the trace framework it added some info in the > traces. > Jerin, Sunil, what do you think? Should we keep this helper internally? Good catch @David Marchand. Yes, we should be it as internal helper API use it here. For trace, It will be difficult to make sense without thread name. > > > -- > David Marchand >