From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4D68A0524; Sat, 7 Nov 2020 20:05:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B362437B1; Sat, 7 Nov 2020 20:05:57 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id BADB9377E for ; Sat, 7 Nov 2020 20:05:55 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id r9so5715522ioo.7 for ; Sat, 07 Nov 2020 11:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0GajNvYD8EYXjTg7byZ8eEo45W4k7rgBxAt+Zs8rxaQ=; b=RNvODe81h040BJhJr3X+ine7EY3aM/Ke3lAHQxqEuBk+hVP40x4D1PQI1KPE/PT888 NjZ5o9uwqvmJ7/xyLAUKtfdeKcWtXiBDerrtDP3P1YGYtKOmb6ROPKZj9qsCY2Hebq1i dsFu0ESqBIXt4Kp5uZNV6p/x2+qXEfO2cu6ULTUWtzz2cGKXCrC2d6mkULH8J9h5rjMg nolq7N0KcNUZ59gkgrTKMWGMv7LtGwKOT5wa4w0U7x6e4O0HSU9ZARJ8EDqws7laOm6q F8Xi7JD1qmaOrmCFsNIbGiok9DKtmRSd+u/+L7q3auaGB//d2w7LGyJRDVhT50/19x5a mCuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0GajNvYD8EYXjTg7byZ8eEo45W4k7rgBxAt+Zs8rxaQ=; b=YQB4Q7cw4nmPsKMe/9OTWNMIJpp3VCJecWPyFAa9UtC3J1ba6mdRHZ7o8qqIsMywM6 OGwNRnojyLmMkbv51BLrnKCnQVB4eC1ENlW3a1GnkwiyaW595OLP7FenYeb9ZF4UNigJ 4genQEFE0n9rYmVo8S85GB4LyWLEEnfQrErM19fjq6FTQqYo2v03UZNUHfo4Bxnce6Dq 4BZed87k7FcuG+C825oJq1XOwzXN33+4mkCTT/JSwwbuJbaX4H3pMt5ITh1ROdPMq1u9 pKOoWdKBa8t7X5xm7yX0YoCSUM7ds7W1ATmM/OyAxPtkGK/xuV5o7V4iejz4CUxq/6Jy 6x6A== X-Gm-Message-State: AOAM530J+CSm+nnHWWavfQvDd4sgPYMlkGMZwSJ9zxhGXjDFx0AoVWsz z4jUxUfCspvlfbZQfrvCJUib4eURuPiDKKrbO7E= X-Google-Smtp-Source: ABdhPJyjsC9YdPakV+O01ggBaxgPgH5Ksg2TVulJNU6oeRYx8LUgdBPX73Kt8g7L1JvCRK+d0PLrwdtfg2Hk2S9wMDU= X-Received: by 2002:a6b:fb07:: with SMTP id h7mr5406032iog.163.1604775954080; Sat, 07 Nov 2020 11:05:54 -0800 (PST) MIME-Version: 1.0 References: <20201107155306.463148-1-thomas@monjalon.net> <4509916.LqRtgDRpI1@thomas> In-Reply-To: <4509916.LqRtgDRpI1@thomas> From: Jerin Jacob Date: Sun, 8 Nov 2020 00:35:38 +0530 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , David Marchand , Ferruh Yigit , Olivier Matz , =?UTF-8?Q?Morten_Br=C3=B8rup?= , "Ananyev, Konstantin" , Andrew Rybchenko , Viacheslav Ovsiienko , Ajit Khaparde , Jerin Jacob , Hemant Agrawal , Ray Kinsella , Neil Horman , Nithin Dabilpuram , Kiran Kumar K Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 8, 2020 at 12:09 AM Thomas Monjalon wrote: > > 07/11/2020 18:12, Jerin Jacob: > > On Sat, Nov 7, 2020 at 10:04 PM Thomas Monjalon wrote: > > > > > > The mempool pointer in the mbuf struct is moved > > > from the second to the first half. > > > It should increase performance on most systems having 64-byte cache line, > > > > > i.e. mbuf is split in two cache lines. > > > > But In any event, Tx needs to touch the pool to freeing back to the > > pool upon Tx completion. Right? > > Not able to understand the motivation for moving it to the first 64B cache line? > > The gain varies from driver to driver. For example, a Typical > > ARM-based NPU does not need to > > touch the pool in Rx and its been filled by HW. Whereas it needs to > > touch in Tx if the reference count is implemented. See below. > > > > > Due to this change, tx_offload is moved, so some vector data paths > > > may need to be adjusted. Note: OCTEON TX2 check is removed temporarily! > > > > It will be breaking the Tx path, Please just don't remove the static > > assert without adjusting the code. > > Of course not. > I looked at the vector Tx path of OCTEON TX2, > it's close to be impossible to understand :) > Please help! Off course. Could you check the above section any share the rationale for this change and where it helps and how much it helps? > >