DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/octeontx2: fix rss flow create
@ 2020-10-10  6:33 kirankumark
  2020-10-11  9:37 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: kirankumark @ 2020-10-10  6:33 UTC (permalink / raw)
  To: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K; +Cc: dev

From: Kiran Kumar K <kirankumark@marvell.com>

While creating flow with action type RSS, action type is not being
set to RSS, and action type is being set to unicast. Therefore it breaks
RSS functionality. This patch add changes to program the RSS action
properly.

Fixes: 4092e4845d ("net/octeontx2: add flow operations")

Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
---
 drivers/net/octeontx2/otx2_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c
index 13a76e441..90540ffbd 100644
--- a/drivers/net/octeontx2/otx2_flow.c
+++ b/drivers/net/octeontx2/otx2_flow.c
@@ -270,6 +270,8 @@ flow_program_rss_action(struct rte_eth_dev *eth_dev,
 			if (rc)
 				return rc;
 
+			flow->npc_action &= (~(0xfULL));
+			flow->npc_action |= NIX_RX_ACTIONOP_RSS;
 			flow->npc_action |=
 				((uint64_t)(alg_idx & NIX_RSS_ACT_ALG_MASK) <<
 				 NIX_RSS_ACT_ALG_OFFSET) |
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/octeontx2: fix rss flow create
  2020-10-10  6:33 [dpdk-dev] [PATCH] net/octeontx2: fix rss flow create kirankumark
@ 2020-10-11  9:37 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2020-10-11  9:37 UTC (permalink / raw)
  To: Kiran Kumar K, Ferruh Yigit
  Cc: Jerin Jacob, Nithin Dabilpuram, dpdk-dev, dpdk stable

On Sat, Oct 10, 2020 at 12:03 PM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> While creating flow with action type RSS, action type is not being
> set to RSS, and action type is being set to unicast. Therefore it breaks
> RSS functionality. This patch add changes to program the RSS action
> properly.
>
> Fixes: 4092e4845d ("net/octeontx2: add flow operations")

Cc: stable@dpdk.org

Applied to dpdk-next-net-mrvl/for-main. Thanks.

>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
>  drivers/net/octeontx2/otx2_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c
> index 13a76e441..90540ffbd 100644
> --- a/drivers/net/octeontx2/otx2_flow.c
> +++ b/drivers/net/octeontx2/otx2_flow.c
> @@ -270,6 +270,8 @@ flow_program_rss_action(struct rte_eth_dev *eth_dev,
>                         if (rc)
>                                 return rc;
>
> +                       flow->npc_action &= (~(0xfULL));
> +                       flow->npc_action |= NIX_RX_ACTIONOP_RSS;
>                         flow->npc_action |=
>                                 ((uint64_t)(alg_idx & NIX_RSS_ACT_ALG_MASK) <<
>                                  NIX_RSS_ACT_ALG_OFFSET) |
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-11  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-10  6:33 [dpdk-dev] [PATCH] net/octeontx2: fix rss flow create kirankumark
2020-10-11  9:37 ` Jerin Jacob

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git