Re: [dpdk-dev] [EXT] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test

[Jerin Jacob <jerinjacobk@gmail.com>]

On Mon, Jan 25, 2021 at 11:19 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
> >For the wmb in order_process_stage_1 and
> >order_process_stage_invalid in
> >the order test, they can be removed. This is because when the test
> >results
> >are wrong, the worker core writes 'true' to t->err. Then other worker
> >cores, producer cores and the main core will load the 'error' index and
> >stop testing. So, for the worker cores, no other storing operation needs
> >to be guaranteed after this when errors happen.
> >
> >Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> >Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


Series applied to dpdk-next-eventdev/for-main. Thanks.


> >---
> > app/test-eventdev/test_order_common.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> >diff --git a/app/test-eventdev/test_order_common.h b/app/test-
> >eventdev/test_order_common.h
> >index 5ef840493..cd9d6009e 100644
> >--- a/app/test-eventdev/test_order_common.h
> >+++ b/app/test-eventdev/test_order_common.h
> >@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order
> >*const t,
> >                       flow, *order_mbuf_seqn(t, ev->mbuf),
> >                       expected_flow_seq[flow]);
> >               t->err = true;
> >-              rte_smp_wmb();
> >       }
> >       /*
> >        * Events from an atomic flow of an event queue can be
> >scheduled only to
> >@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order
> >*const t,
> > {
> >       evt_err("invalid queue %d", ev->queue_id);
> >       t->err = true;
> >-      rte_smp_wmb();
> > }
> >
> > #define ORDER_WORKER_INIT\
> >--
> >2.25.1
>