From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03FEBA052A; Tue, 26 Jan 2021 16:56:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 872EA140D5B; Tue, 26 Jan 2021 16:56:59 +0100 (CET) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 69D1D140D41 for ; Tue, 26 Jan 2021 16:56:58 +0100 (CET) Received: by mail-io1-f43.google.com with SMTP id x21so34526355iog.10 for ; Tue, 26 Jan 2021 07:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GZHUeJt7eCNxzQHFf7ZMXU138LYYu2d5ZbOoIkyASoQ=; b=H8tY5JMrKiQA28I1vjSM/b7E/VoMmXBwi99sms7aK+Hg/MkgbpnLOLFSgGi61tBhm2 nMZnR69v215YrACgL12wykVt76bBvqD1ZeiKTU1FZccQZ+S/8d/c7QQVvNgoN+Gfq0sO cXZXixrablp4KraLqxA8QcVouYL6Hkr4GXnjfPYsF3WAdKmyfQMvBYDPmUcN5mxAMbiq PBcpFSTY/07O8dk6FGqpB1pm+yt3+Baav1Z2hkwWbeLlkLgc3ANoPk9og4GCxznr04qi IY6KsVf4Ka61zkQgr0+4A2Fbpb/f3ikfxvlLk/3i6scahITDsz0qEyXr7nMXSlftUsJS FJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GZHUeJt7eCNxzQHFf7ZMXU138LYYu2d5ZbOoIkyASoQ=; b=h/u13VXd2etJUC5fPY7DyZqH3kZySb2jVOP4hNOsKR5INYZ0gHx23wEK1mZmm8+2LD 1gVuHr3feFkjcsvo0MjLIrJTetY3nZnObClApCR2ouiBlhDWH9RVLmgWJTZQFWLsfFph TO6nLXI3/Yh0fcyPR9FiCRszfGg530zLh/yUe9Rmn8skxjC3bI1et5W++6TFDcpJB8RK Rnq5P5nHMwIT8lLYwdefGnmCH2cCxEzBYqgEh58dA54l5/r+Uv/3Ec8DhHVVKrN+Fh4V 5EzKahUZDqz88c2w/OsTqmbsbCGH50i13CjkSDTqI3y+jIWpm1OJuwImpqO4+VjgSr52 HyTw== X-Gm-Message-State: AOAM530+rdjWK28rZZz40goq7Ti7HhtsuUJh7B40HvnkF4rlk4eyoXDN iAitvF6LfeWcQcuZC3dRXgx14DGN92gEog2sbwk= X-Google-Smtp-Source: ABdhPJxcVtzZjbxFS1mY+pAQpS+7QBfS4PnE6J9SnSWZhQaAZKdL0ezoqRxwxS4v4RT0T1jowJBtqNOZqvQ2E3b8n60= X-Received: by 2002:a92:c782:: with SMTP id c2mr2263723ilk.162.1611676617768; Tue, 26 Jan 2021 07:56:57 -0800 (PST) MIME-Version: 1.0 References: <20210114070830.707550-1-feifei.wang2@arm.com> <20210114070830.707550-6-feifei.wang2@arm.com> In-Reply-To: From: Jerin Jacob Date: Tue, 26 Jan 2021 21:26:41 +0530 Message-ID: To: Pavan Nikhilesh Bhagavatula Cc: Feifei Wang , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" , Ruifeng Wang Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 25, 2021 at 11:19 PM Pavan Nikhilesh Bhagavatula wrote: > > >For the wmb in order_process_stage_1 and > >order_process_stage_invalid in > >the order test, they can be removed. This is because when the test > >results > >are wrong, the worker core writes 'true' to t->err. Then other worker > >cores, producer cores and the main core will load the 'error' index and > >stop testing. So, for the worker cores, no other storing operation needs > >to be guaranteed after this when errors happen. > > > >Signed-off-by: Feifei Wang > >Reviewed-by: Ruifeng Wang > Acked-by: Pavan Nikhilesh Series applied to dpdk-next-eventdev/for-main. Thanks. > >--- > > app/test-eventdev/test_order_common.h | 2 -- > > 1 file changed, 2 deletions(-) > > > >diff --git a/app/test-eventdev/test_order_common.h b/app/test- > >eventdev/test_order_common.h > >index 5ef840493..cd9d6009e 100644 > >--- a/app/test-eventdev/test_order_common.h > >+++ b/app/test-eventdev/test_order_common.h > >@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order > >*const t, > > flow, *order_mbuf_seqn(t, ev->mbuf), > > expected_flow_seq[flow]); > > t->err = true; > >- rte_smp_wmb(); > > } > > /* > > * Events from an atomic flow of an event queue can be > >scheduled only to > >@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order > >*const t, > > { > > evt_err("invalid queue %d", ev->queue_id); > > t->err = true; > >- rte_smp_wmb(); > > } > > > > #define ORDER_WORKER_INIT\ > >-- > >2.25.1 >