From: Jerin Jacob <jerinjacobk@gmail.com>
To: pbhagavatula@marvell.com
Cc: jerinj@marvell.com, Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [PATCH] devtools: exclude atomic checks for common cnxk
Date: Thu, 12 Jun 2025 19:09:02 +0530 [thread overview]
Message-ID: <CALBAE1PSsm4o-a8_7tJfT=Shiq7xMLvakLgGH0kBRuhiH9e=gg@mail.gmail.com> (raw)
In-Reply-To: <20250327111344.2205-1-pbhagavatula@marvell.com>
On Thu, Mar 27, 2025 at 4:50 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Since driver/common/cnxk has common code that is
> used across multiple platforms, allow use of
> GCC builtin atomic functions.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> Rest of drivers i.e., drivers/*/cnxk have been migrated to use stdatomics in:
> https://patchwork.dpdk.org/project/dpdk/patch/20250327111120.1641-1-pbhagavatula@marvell.com/
>
> devtools/checkpatches.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index c9088bb403..2470d4fa83 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -139,6 +139,7 @@ check_forbidden_additions() { # <patch>
>
> # refrain from using compiler __atomic_xxx builtins
> awk -v FOLDERS="lib drivers app examples" \
> + -v SKIP_FILES='drivers/common/cnxk/' \
> -v EXPRESSIONS="__atomic_.*\\\( __ATOMIC_(RELAXED|CONSUME|ACQUIRE|RELEASE|ACQ_REL|SEQ_CST)" \
> -v RET_ON_FAIL=1 \
> -v MESSAGE='Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx' \
> --
> 2.43.0
>
prev parent reply other threads:[~2025-06-12 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 11:13 pbhagavatula
2025-06-12 13:39 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PSsm4o-a8_7tJfT=Shiq7xMLvakLgGH0kBRuhiH9e=gg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).