From: Jerin Jacob <jerinjacobk@gmail.com> To: Kiran Kumar K <kirankumark@marvell.com> Cc: Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>, dpdk-dev <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: extend RSS supported offload types Date: Wed, 22 Jan 2020 13:35:04 +0530 Message-ID: <CALBAE1PUGFxpgyqQtDA6LmFaq=iOfxb3WTh1E_gmR3ioEqJQ5g@mail.gmail.com> (raw) In-Reply-To: <20200122034609.19100-1-kirankumark@marvell.com> On Wed, Jan 22, 2020 at 9:16 AM <kirankumark@marvell.com> wrote: > > From: Kiran Kumar K <kirankumark@marvell.com> > > Extend RSS offload types for octeontx2. Add support to select > L3 SRC, L3 DST, L4 SRC and L4 DST for RSS calculation. > > Add support to select L3 SRC or DST only, L4 SRC or DST only for RSS > calculation. > > With this requirement there will be following combinations, > IPV[4,6]_SRC_ONLY, IPV[4,6]_DST_ONLY, [TCP,UDP,SCTP]_SRC_ONLY, > [TCP,UDP,SCTP]_DST_ONLY. So, instead of creating a bit for each > combination, we are using upper 4 bits (31:28) in the flow_key_cfg > to represent the SRC, DST selection. 31 => L3_SRC, 30 => L3_DST, > 29 => L4_SRC, 28 => L4_DST. These won't be part of flow_cfg, so that > we don't need to change the existing ABI. > > Signed-off-by: Kiran Kumar K <kirankumark@marvell.com> > --- > > struct nix_rss_flowkey_cfg_rsp { > diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c > index bc7b64387..7a8c8f3de 100644 > --- a/drivers/net/octeontx2/otx2_rss.c > +++ b/drivers/net/octeontx2/otx2_rss.c > @@ -210,6 +210,18 @@ otx2_rss_ethdev_to_nix(struct otx2_eth_dev *dev, uint64_t ethdev_rss, > > dev->rss_info.nix_rss = ethdev_rss; > Should n't we update the struct rte_eth_dev_info::flow_type_rss_offloads to show this capability to the driver. Please check other drivers. > + if (ethdev_rss & ETH_RSS_L3_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_SRC; > + > + if (ethdev_rss & ETH_RSS_L3_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_DST; > + > + if (ethdev_rss & ETH_RSS_L4_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_SRC; > + > + if (ethdev_rss & ETH_RSS_L4_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_DST; > + > if (ethdev_rss & RSS_IPV4_ENABLE) > flowkey_cfg |= flow_key_type[rss_level][RSS_IPV4_INDEX]; > > -- > 2.17.1 >
next prev parent reply other threads:[~2020-01-22 8:05 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-22 3:46 kirankumark 2020-01-22 8:05 ` Jerin Jacob [this message] 2020-01-23 5:30 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda 2020-01-24 3:46 ` [dpdk-dev] [PATCH v2] " kirankumark 2020-01-28 11:14 ` Jerin Jacob
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALBAE1PUGFxpgyqQtDA6LmFaq=iOfxb3WTh1E_gmR3ioEqJQ5g@mail.gmail.com' \ --to=jerinjacobk@gmail.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=vattunuru@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git