From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9EBCA0525; Wed, 22 Jan 2020 09:05:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B0642B8B; Wed, 22 Jan 2020 09:05:23 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id CCB09F04 for ; Wed, 22 Jan 2020 09:05:21 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id i7so5755130ioo.5 for ; Wed, 22 Jan 2020 00:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ms0kqjPhxLz3ZD2sHKO6iaPJru/z9C+PfiACh9WdmHQ=; b=qGm4oRKWs+fEeAEl5MrXstmQ5VAQhElt7dGVQWYBgSYnNOsh1eqQJppTXxXdMBTTRj TANardsxJ45V+cKICAonxQncMwZiKw2MRx1XN+jH9NYOsfL+zmfOxH2zjESb4NVQ3nCB P3XzGuOllF0ui/ZLnkW+rvFh+rD5sFC4CKzQHerXmgGA7DCRxgRSVuW6/mT2G7WzwvUm yWnpoh1lGp89Ubd7PYy86agINsD8wW2R+pcH9Xq2qccWrSpr8InXv/g2BFB03dIlm80f cIFa0lWlFPguVtmzpGGr8sy+heIqDEBf9ognfqtz5us5cmXdxG4pHVEs1CO/4n19+F4u feSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ms0kqjPhxLz3ZD2sHKO6iaPJru/z9C+PfiACh9WdmHQ=; b=lio33n0A93OaMlpIwuK9K4m0qZnu49IGcIL+l9ILt6TzclIDHTrYEuZ06mQf3GjgIC RvGOLIA9OHYCmhNDf7VNgGDDFCvcyUi4EIuG9D3zYpdeKi8j2jmUemfC81j9LVLBZJf2 DquaDj0QoHyid9LiW5x57TLmGKN7AoeBrntGrLZ/FWJMpKHLWLm+3/nCtTV4PB1a+14B oud5YywT6k5HkFKwINLpH6hGWMOh9Na6YyNnYeYoE1nqHbqULGqjQOZoB6eVSdsyZ123 bBsJoq98EF9DidjZZJ50OTAvg52b5/eGeb6QyLz2dEGMYFRIsJijtFub7lD+NWAeTl8a h/Bw== X-Gm-Message-State: APjAAAWlj/b6tTZfqR4eBrr9Q3t+PpwQwfTeTX3IC18+sWohTcZ5UXuj s3OaJjlKZ2fA9Y4S57/uTB8ji0kG/rRiyC/Dm7w= X-Google-Smtp-Source: APXvYqxRRpGtCU+ZnGY0Y7uLW5NnSPWd0jTJS53Si9npkV8hnV+ThQq1vDW1sz4lhI9L9ih6X0RsmAlFeuXNHHwYa4M= X-Received: by 2002:a5e:8516:: with SMTP id i22mr6383139ioj.130.1579680321012; Wed, 22 Jan 2020 00:05:21 -0800 (PST) MIME-Version: 1.0 References: <20200122034609.19100-1-kirankumark@marvell.com> In-Reply-To: <20200122034609.19100-1-kirankumark@marvell.com> From: Jerin Jacob Date: Wed, 22 Jan 2020 13:35:04 +0530 Message-ID: To: Kiran Kumar K Cc: Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: extend RSS supported offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 22, 2020 at 9:16 AM wrote: > > From: Kiran Kumar K > > Extend RSS offload types for octeontx2. Add support to select > L3 SRC, L3 DST, L4 SRC and L4 DST for RSS calculation. > > Add support to select L3 SRC or DST only, L4 SRC or DST only for RSS > calculation. > > With this requirement there will be following combinations, > IPV[4,6]_SRC_ONLY, IPV[4,6]_DST_ONLY, [TCP,UDP,SCTP]_SRC_ONLY, > [TCP,UDP,SCTP]_DST_ONLY. So, instead of creating a bit for each > combination, we are using upper 4 bits (31:28) in the flow_key_cfg > to represent the SRC, DST selection. 31 => L3_SRC, 30 => L3_DST, > 29 => L4_SRC, 28 => L4_DST. These won't be part of flow_cfg, so that > we don't need to change the existing ABI. > > Signed-off-by: Kiran Kumar K > --- > > struct nix_rss_flowkey_cfg_rsp { > diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c > index bc7b64387..7a8c8f3de 100644 > --- a/drivers/net/octeontx2/otx2_rss.c > +++ b/drivers/net/octeontx2/otx2_rss.c > @@ -210,6 +210,18 @@ otx2_rss_ethdev_to_nix(struct otx2_eth_dev *dev, uint64_t ethdev_rss, > > dev->rss_info.nix_rss = ethdev_rss; > Should n't we update the struct rte_eth_dev_info::flow_type_rss_offloads to show this capability to the driver. Please check other drivers. > + if (ethdev_rss & ETH_RSS_L3_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_SRC; > + > + if (ethdev_rss & ETH_RSS_L3_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L3_DST; > + > + if (ethdev_rss & ETH_RSS_L4_SRC_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_SRC; > + > + if (ethdev_rss & ETH_RSS_L4_DST_ONLY) > + flowkey_cfg |= FLOW_KEY_TYPE_L4_DST; > + > if (ethdev_rss & RSS_IPV4_ENABLE) > flowkey_cfg |= flow_key_type[rss_level][RSS_IPV4_INDEX]; > > -- > 2.17.1 >