From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19D3FA0547; Sun, 17 Oct 2021 07:58:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98B6740041; Sun, 17 Oct 2021 07:58:54 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id DFDEA4003C for ; Sun, 17 Oct 2021 07:58:52 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id z69so9417114iof.9 for ; Sat, 16 Oct 2021 22:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J7S26FTo/DY74rbe9vygJcshzmJ74vYk63+h2kK/83o=; b=WFGqNrK8PO1aL9Uijz8nfBHwYaphNyegZWxGnFVAVMmaBdA0jFv6YPIsfbl2V3P4Kf s752kveDtIF+WMdt6iYXzoNbsn72vbCjOlVAjDuwWk+aoLf3qxvwrr5QF/k6+5K5F71y e/zu+kKFOeZ1SqfMK96luYlgcfsRo2ESZYSI9cJND51sjmBWvEiAy3uAjTfphJa0zSlQ clvk72KjbzDt6HZu0e32DHM+NFBf4GimpTwX0u3oGSeX/F8s1zup7CLEfH13ldnK+aLj FSonrNSfiIokYMwmP6jHrpaCSXix1Rhlry93EaLI9OJMiur6d+3YzknRTAvrtQBUs8rm QoyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J7S26FTo/DY74rbe9vygJcshzmJ74vYk63+h2kK/83o=; b=kwTfA1/GGojIXeW6RBwsIt70EvfUAziK4u8ZXtD7x5qJY/Bn2Bcl0t1854EimmXEMI Op2H92omDs5EhsJ+ePp/byTyfKpQm9OnuVaF9BPPkXuKEbJAwZqf8YVT4HvUVZSgVRva XF+qi5GVBFJXO4it3jL5Z17BEinlS44P4irg1WHv3s1Pl08/53MS9oJVYeRhuoihtIk1 bLus6+qfRu2e0J5g1/j1og85hgIe1Ew7I2JvXnQlMqgqC+3BEtZP2rJJLIojo75VD/6Q RymPjOqbXzx4Olx3wlUhuIC7YR7VGpUvuzlRMS8NSlD7/QA86c1N2afk46ad/hCxXbOE xlSw== X-Gm-Message-State: AOAM533JlMZjFrywyoUypgtIVltpR6+VHLSChfTIHbWWr/c/x4N0cCB+ kcAaPXpnHeMMPn3VreW/ZLZr8p8gdJ+hCUaIfA5Ix0ISUzk= X-Google-Smtp-Source: ABdhPJwgj2YfRvWfqVN0hZ5QwsgnBw6nIJt0X3OPZzFvRBUDkBhoP5FEZnxptg31DwWxXPfrMBA+A9tLXvz/38ZWt+M= X-Received: by 2002:a05:6602:14d2:: with SMTP id b18mr9724787iow.123.1634450332269; Sat, 16 Oct 2021 22:58:52 -0700 (PDT) MIME-Version: 1.0 References: <20211006065012.16508-1-pbhagavatula@marvell.com> <20211015190221.2160-1-pbhagavatula@marvell.com> <20211015190221.2160-14-pbhagavatula@marvell.com> In-Reply-To: <20211015190221.2160-14-pbhagavatula@marvell.com> From: Jerin Jacob Date: Sun, 17 Oct 2021 11:28:26 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , Ray Kinsella , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 14/14] eventdev: mark trace variables as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 16, 2021 at 12:34 AM wrote: > > From: Pavan Nikhilesh > > Mark rte_trace global variables as internal i.e. remove them > from experimental section of version map. > Some of them are used in inline APIs, mark those as global. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Ray Kinsella > --- > doc/guides/rel_notes/release_21_11.rst | 12 +++++ > lib/eventdev/version.map | 71 ++++++++++++-------------- > 2 files changed, 44 insertions(+), 39 deletions(-) > > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index 38e601c236..5b4a05c3ae 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -226,6 +226,9 @@ API Changes > the crypto/security operation. This field will be used to communicate > events such as soft expiry with IPsec in lookaside mode. > > +* eventdev: Event vector configuration APIs have been made stable. > + Move memory used by timer adapters to hugepage. This will prevent TLB misses > + if any and aligns to memory structure of other subsystems. > > ABI Changes > ----------- > @@ -277,6 +280,15 @@ ABI Changes > were added in structure ``rte_event_eth_rx_adapter_stats`` to get additional > status. > > +* eventdev: A new structure ``rte_event_fp_ops`` has been added which is now used > + by the fastpath inline functions. The structures ``rte_eventdev``, > + ``rte_eventdev_data`` have been made internal. ``rte_eventdevs[]`` can't be > + accessed directly by user any more. This change is transparent to both > + applications and PMDs. > + > +* eventdev: Re-arrange fields in ``rte_event_timer`` to remove holes. > + ``rte_event_timer_adapter_pmd.h`` has been made internal. Looks good. Please fix the following, If there are no objections, I will merge the next version. 1) Please move the doc update to respective patches 2) Following checkpath issue [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 14 ### eventdev: move inline APIs into separate structure INFO: symbol event_dev_fp_ops_reset has been added to the INTERNAL section of the version map INFO: symbol event_dev_fp_ops_set has been added to the INTERNAL section of the version map INFO: symbol event_dev_probing_finish has been added to the INTERNAL section of the version map ERROR: symbol rte_event_fp_ops is added in the DPDK_22 section, but is expected to be added in the EXPERIMENTAL section of the version map