From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22004A00C3; Fri, 16 Sep 2022 18:14:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 749E240A82; Fri, 16 Sep 2022 18:14:02 +0200 (CEST) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mails.dpdk.org (Postfix) with ESMTP id 1925840156; Fri, 16 Sep 2022 18:14:01 +0200 (CEST) Received: by mail-qk1-f169.google.com with SMTP id o7so12392102qkj.10; Fri, 16 Sep 2022 09:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=uMqZx5ssehcRO6/Xuc5xvrBU3TPgUN5eLqAL3Z57l+g=; b=llhECnfH3tLcOnbDD6Y+tAKMQCuzYe2I+UIpc87sSWxZl5FtIFBjB3x+uL76Nu5+Jh 4aZTpmlTg2IzOOLw+vwmQzhQSl9+vbgYOpNb9uYi/KDz4Hc3nJcEwtvpocGGSmjW/TgI 31vcxZ9QzxwvrFQ5PTkzb3l4bSGNiJoEKvlVQU3ewf+4Dn2LdHI9jS2j1ToVP+5+TQjj ElkyYIQSpDSI2sH9wBegTSv0riROG7H31OFlpPC7fNSenG/MqHu/d2HLZLGq/ZJBP0am WAa6R45jEyFvFvMBymjkEyeVzq4dA4+IGk4AjWe8E0RSvKJDq1/drSao72NQDpF6XTcs wLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=uMqZx5ssehcRO6/Xuc5xvrBU3TPgUN5eLqAL3Z57l+g=; b=CYUwcwJJQAF75SwqA0Ma3VJAseHXKj8UwmXrOAwZcXMwcL9Sk+a3eYGE+zkcrIf0wN 6GATLxdHeiOsIM5uRygY6xycNbdhiJvlnnv92pNUHSHTN8toEIPCJejJDSbr+Kv852rD 0UHekQrPg7pUPvfIQlFKsmmA56Cg4DVt4pwWorZV/jF33wVgJY2f5r0/cBVvNHnbBgUk YwY8dsSkQhpjLJDu30GUjPP2g0GxXTf7rqy48x4LFzoUH3o84KdjwvegM2PQM26kjqnp dJoFPAkLEoWRDHYk48G9Wh9dyqRzTJxSMl87CiWVtsfXX6E5pu3CYHUUctONvrir3fAA iZYQ== X-Gm-Message-State: ACrzQf146NUVT8EkQMbHs+AO7KJRizcjLxyJGp5tFIK7TcnsjmY/BJJw eEq92ywfg2IpEnR06F98hnohjJlM5Tgf4Z1jJ1M= X-Google-Smtp-Source: AMsMyM7qHKjmC72+fK9Ml2dCIXhebleJqw6EmJtLDawS4axm4UT3Yi7HNN5OvUWOkW+EGmKXWCT4ErVyxSRKLx4ZYy8= X-Received: by 2002:ae9:efc4:0:b0:6cb:e44c:723a with SMTP id d187-20020ae9efc4000000b006cbe44c723amr4356298qkg.402.1663344840360; Fri, 16 Sep 2022 09:14:00 -0700 (PDT) MIME-Version: 1.0 References: <20220913051019.331807-1-psatheesh@marvell.com> In-Reply-To: <20220913051019.331807-1-psatheesh@marvell.com> From: Jerin Jacob Date: Fri, 16 Sep 2022 21:43:34 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter reset To: psatheesh@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 13, 2022 at 10:40 AM wrote: > > From: Satheesh Paul > > Added code to clear counters upon flow deletion. > > Fixes: f9af9080746 ("common/cnxk: add mcam utility API") > Cc: stable@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar Kokkilagadda Please use Kiran Kumar K as it is consistent across tree. Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix missing flow counter reset Added code to clear counters upon flow deletion. Fixes: f9af9080746 ("common/cnxk: add mcam utility API") Cc: stable@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K > --- > drivers/common/cnxk/roc_npc_mcam.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c > index 82a9756189..4bea6719c5 100644 > --- a/drivers/common/cnxk/roc_npc_mcam.c > +++ b/drivers/common/cnxk/roc_npc_mcam.c > @@ -850,8 +850,10 @@ npc_flow_free_all_resources(struct npc *npc) > for (idx = 0; idx < npc->flow_max_priority; idx++) { > while ((flow = TAILQ_FIRST(&npc->flow_list[idx])) != NULL) { > npc_rss_group_free(npc, flow); > - if (flow->ctr_id != NPC_COUNTER_NONE) > + if (flow->ctr_id != NPC_COUNTER_NONE) { > + rc |= npc_mcam_clear_counter(npc, flow->ctr_id); > rc |= npc_mcam_free_counter(npc, flow->ctr_id); > + } > > npc_delete_prio_list_entry(npc, flow); > > -- > 2.35.3 >