From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9796545A7B; Tue, 1 Oct 2024 16:05:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E4964027C; Tue, 1 Oct 2024 16:05:33 +0200 (CEST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by mails.dpdk.org (Postfix) with ESMTP id C045740268 for <dev@dpdk.org>; Tue, 1 Oct 2024 16:05:32 +0200 (CEST) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-458320b30e7so38928591cf.0 for <dev@dpdk.org>; Tue, 01 Oct 2024 07:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727791532; x=1728396332; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HxLXKGQ35Vc0rM5eIMslEpjXtUQlTuameZ95Dl9AgaU=; b=g3+2ptPwz801QTeGPpiFL0I8CZm/BltMrKmHlH9fQC/ExIdIJV/TC3G1K6Jxjl+EJ7 3AAAGzxPT5uyJro9iF4nmM+Tvho81pUYuk9lxaY/VqNOqz5b2yGzrzcDvx67rAkTi8dY fVCVOUj1dcxC43I/BTRExCM1I7sFWEVj8cZy1maS1M+m8c7da9CKLLZttn36MYbN6lzv Km6DO2YHRzzwHsWP90zsGnN+3Trm5wv7XKui7HDnHS7vk/42gcxrwzqgIAqMXFONwhVl FoWAhTBVqJzwQddM6uft1Sic0InyBmnknYcdom2kDjuujn5V+//aeumy/EgvjghhS/YP U2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727791532; x=1728396332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HxLXKGQ35Vc0rM5eIMslEpjXtUQlTuameZ95Dl9AgaU=; b=jc9VGd7fSA5NgHW/UgY4I6NyESNTryoUIJDYQX8M7vCWrV/8efzS475fsFoJ782ch+ AwyZXO+SvW51crKKIaqfLZ8lAozZ+CTkhGWT+jjlpxT+ggBXnxNOfCIAVO+JnceeZoW6 wuoB5pgJBB9GpC0/ktYDBZ7GQ5/iC4yHL2+eriyfcqfZmy+iCo5AopW6whHEz4A8fJnA Kgl5TOb+TbYWrf7fyq/ukx8fZ+hEf+an4ZmQz46mak36B3jsZAZWI9VaEoXPk04jgtvs 3LZ0Hfcyz2Fy09F2jCa0yYChpBoct6aOudRzijm8LE/HCLO8rcGYv6KO58Srl5K7ZaV8 FScw== X-Forwarded-Encrypted: i=1; AJvYcCWaF7DOAmloI6PZzyVWPafW3lsHjNW9Doig5iTQNiUp9o8yS5o0zIhbl9y21l4rB7jnWos=@dpdk.org X-Gm-Message-State: AOJu0YxumAsUonXAl3H7nsv0prK8pUDSvqKgbSpzG1QZZUxYtErNgzFI m+69/qPlvg6XWfsM/4cBOor1i0iaJdsv9eQ0K6pmmOXVMCJeLzWvQ05wuwxZ/V+EbI0aDoFsK4W jf8vJD1MMoWE9FkCBS78aFI18Tf0= X-Google-Smtp-Source: AGHT+IEkHrzZlLH2w+wA2gz9/07KLz1B5AxXyBgK/HWqbhfPyyhQx5Ecp/Bj3oR9nPZ/OZwgs1ugw7A/EnN2f0euxV4= X-Received: by 2002:a05:622a:14c6:b0:44f:5e2c:1600 with SMTP id d75a77b69052e-45c9f224b6cmr200124421cf.28.1727791531675; Tue, 01 Oct 2024 07:05:31 -0700 (PDT) MIME-Version: 1.0 References: <20240918085551.231015-1-mb@smartsharesystems.com> <20240924133957.1505113-1-mb@smartsharesystems.com> <CALBAE1MBD0bcLGgsSfBHN867fo_EU7gpvMPp5NzEC+BmD=4G7g@mail.gmail.com> <98CBD80474FA8B44BF855DF32C47DC35E9F72A@smartserver.smartshare.dk> <CALBAE1MwigJA+Vi=ZUTa_wCoKgWU2d3zzzY7CoUMTY82FsaT_A@mail.gmail.com> <98CBD80474FA8B44BF855DF32C47DC35E9F74B@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F74B@smartserver.smartshare.dk> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Tue, 1 Oct 2024 19:35:05 +0530 Message-ID: <CALBAE1PXs0iRFxx5WWycDkUB8HQbgqSD+3yxram7O1jhs1H8gg@mail.gmail.com> Subject: Re: [PATCH v4] eal: add build-time option to omit trace To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> Cc: Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 7:19=E2=80=AFPM Morten Br=C3=B8rup <mb@smartsharesys= tems.com> wrote: > > Jerin, > > If you have no further comments, please add review/ack tag, to help Thoma= s see that the patch has been accepted by the maintainer, and can be merged= . There was a comment to make the function as rte_trace_is_enabled() and remove internal. The rest looks good to me. I will Ack in the next version. >