Re: [dpdk-dev] [PATCH 4/4] event/octeontx2: timer always use virtual counter

[Jerin Jacob <jerinjacobk@gmail.com>]

On Thu, Feb 25, 2021 at 5:53 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Use virtual counter for estimating current bucket as PMU cannot be
> reliably used to estimate time.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>
> +#ifdef RTE_ARCH_ARM64
> +static inline uint64_t
> +tim_cntvct(void)
> +{
> +       uint64_t tsc;
> +
> +       asm volatile("mrs %0, cntvct_el0" : "=r"(tsc));
> +       return tsc;


Reuse __rte_arm64_cntvct()

> +}
> +
> +static inline uint64_t
> +tim_cntfrq(void)
> +{
> +       uint64_t freq;
> +
> +       asm volatile("mrs %0, cntfrq_el0" : "=r"(freq));
> +       return freq;


Reuse __rte_arm64_cntfrq()


Please fix the following checkpatch and check format errors too.


[1]
Wrong headline case:
                        "event/octeontx2: optimize timer arm routine":
arm --> Arm

Invalid patch(es) found - checked 4 patches


[2]
total: 0 errors, 47 warnings, 272 lines checked
Warning in drivers/event/octeontx2/otx2_tim_worker.h:
Using rte_smp_[r/w]mb
Warning in drivers/event/octeontx2/otx2_tim_worker.c:
Using __atomic_thread_fence


>