From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9B1A0524; Sat, 20 Mar 2021 14:34:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F4571410CB; Sat, 20 Mar 2021 14:34:19 +0100 (CET) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mails.dpdk.org (Postfix) with ESMTP id 862E81410C7 for ; Sat, 20 Mar 2021 14:34:18 +0100 (CET) Received: by mail-io1-f51.google.com with SMTP id b10so9088528iot.4 for ; Sat, 20 Mar 2021 06:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UJULLZeWfttln5F1lxCrz5LGSpJ4Z7YMcIghjGusBsI=; b=kNVbNTx9mjrH2YtjyuAKyOdK2L7+O5sk4SAIGdh85xKN3ccZtrsi+xY5kIx9hpRnLT yQ6t+Se2/jN88jd57JJxfK+4vERqFAKY+T3yMV05P6f2FKYZKdnm/SGZBt/aIHtRPyKb Sv02oxgMUmrX8fmbUUdJHxAgYS/3WFMO1/DT9K4Iv1eaobdwybc9G+rwTtMc+2AOlJJ3 j7xLquN2qrvKnsFx8gUnq9AEgRr2UIcah2kBJXky52DnTUr8jqgTeQkKRTpzzrPDzeD2 dDYRnqq3CVaN2+MhPSxzFbhatf+mtIIF6/R2svoKueAIocw01iujaP0P9jZNpYdFkrRR zUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UJULLZeWfttln5F1lxCrz5LGSpJ4Z7YMcIghjGusBsI=; b=QgebrZ7u8AQRSfKKX/AZDBdmO52ue6sn9bbguxs0SEqBjo0lT70wPuKaWa7YXTOqVA jw0w2LPmq8Fo+5nPeXqKYKP1BSEVClDqTwukqIPQiZGJxYFMpi2uFTAn031asqnOuh7s PN8vSYtVssoGFLsFHpXlFCSmOv2ReMgE+YyL/e7AkrqsiJuVzhXnT5HI7neOiSNGhiIg qFLxi8xn40vSntY4BHbAYGEGkPX+CDLxZLmfGlFG3+XhE8DUaWn7c35aJ2uW/i4kn/0+ VbTrI12jbFKtXC6Rz9Bq0e/CN3JxcXLTGJK4AqbHEuScPI3dZE6hc1QbHWIjp0HwCq1M F4Bw== X-Gm-Message-State: AOAM533bsc4Iup3VNeq44OwpIYO18jsdkYsC/E16MH3bruGaqeq8rqBy 3nJBccuEGtr5DtS22P+lxMqAAG7Yisx2dhTVPAg= X-Google-Smtp-Source: ABdhPJy5ityROza1Gobz7PD2FcWsdXQ5ocdGrB2vFRbKsRJ4CjeagSW5vMhuM6bcjQn87rGFqBSoQiK5Xi000wfoars= X-Received: by 2002:a02:7086:: with SMTP id f128mr5015496jac.104.1616247257963; Sat, 20 Mar 2021 06:34:17 -0700 (PDT) MIME-Version: 1.0 References: <20210225122315.6350-1-pbhagavatula@marvell.com> <20210225122315.6350-4-pbhagavatula@marvell.com> In-Reply-To: <20210225122315.6350-4-pbhagavatula@marvell.com> From: Jerin Jacob Date: Sat, 20 Mar 2021 19:04:01 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 4/4] event/octeontx2: timer always use virtual counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 25, 2021 at 5:53 PM wrote: > > From: Pavan Nikhilesh > > Use virtual counter for estimating current bucket as PMU cannot be > reliably used to estimate time. > > Signed-off-by: Pavan Nikhilesh > > +#ifdef RTE_ARCH_ARM64 > +static inline uint64_t > +tim_cntvct(void) > +{ > + uint64_t tsc; > + > + asm volatile("mrs %0, cntvct_el0" : "=r"(tsc)); > + return tsc; Reuse __rte_arm64_cntvct() > +} > + > +static inline uint64_t > +tim_cntfrq(void) > +{ > + uint64_t freq; > + > + asm volatile("mrs %0, cntfrq_el0" : "=r"(freq)); > + return freq; Reuse __rte_arm64_cntfrq() Please fix the following checkpatch and check format errors too. [1] Wrong headline case: "event/octeontx2: optimize timer arm routine": arm --> Arm Invalid patch(es) found - checked 4 patches [2] total: 0 errors, 47 warnings, 272 lines checked Warning in drivers/event/octeontx2/otx2_tim_worker.h: Using rte_smp_[r/w]mb Warning in drivers/event/octeontx2/otx2_tim_worker.c: Using __atomic_thread_fence >