From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10993A2EEB for ; Thu, 12 Sep 2019 14:25:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2536D1E9A4; Thu, 12 Sep 2019 14:25:15 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id BAFE91E9A2 for ; Thu, 12 Sep 2019 14:25:13 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id b136so54042466iof.3 for ; Thu, 12 Sep 2019 05:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/FUoC6mmoklFjojEDYiGrFZDkKc1xY6w3t43+az3DpU=; b=PKQAWtddWvL1KnkAgJtdRzQ7B2Io22tNoWDg4K0uogxy+GXsUZpu3H31Nfx0vsAMGV AQl+MOmj/ObpIlH4RAmslFvrZuVsl8kxm2pYCu8LpKsSqzdukvOjFkmJBqf7M8VMn86X o09AMezqeXFDIzPI1HRrp1KMCz7YhOuoRknWCM4R/8p/3IH7D3Jtc6N5j2KyrUiWvEjk bHEJwm1xBs6x58s2AJBSr+mwvI+JmNUOjAX/ApFSnr2jif4wCKA5qcYlS/IpyTnoWW7X d4R08PHFDolx8B0puByTdNU/hwTatE1MwN8zevIPk5ACZbMOoATb1KGgVnceMlC6Tf93 u/1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/FUoC6mmoklFjojEDYiGrFZDkKc1xY6w3t43+az3DpU=; b=JWtYUD9fzuQDIMLL+hBL9H5l3bW2RgDVYaVst9h/NcGjzABD6v2/jQ4Gtf6pwf4RRj HBgAmQzgvumJlGIBXY1r9NAAsDtYHoM81sEAZHz0vJ9bZ1/hos7AZFLC3tvJ+ty1wCWz OjdHdlomO5XOSNN/4X23/qcwoCxFqkgqek5kGRmXyKReBWukgJ0Zvw0u5Os7lP216bp/ 4FY5xtiaNDQwRTW73LpeERnGBCrr93igxCRsaJL9d8Z6ZWcQpmMtWfogw7ksIo1BcX9J cMPe54VFijZT2DVq54u5tuQX+m47PvmMsh4j/RnzryuclWy7SA1N8EyTI4nHNmi2hkBI 7eJw== X-Gm-Message-State: APjAAAUuY7JY1scIn9DtQLP3H9hzXjEE5x60HUaJLbX3ZktUzYAiSIqE +iYJ3P4I+bE5EcHoPsq7JcRBpDy+u2UdfGcWSMQ= X-Google-Smtp-Source: APXvYqy0vQzbxLiVQ8efDVoh4Ipb6WMZ0SgCLb7zgav2wpe9/0DGKQdc8oYVBc0Vor7SeLmJ5jt1QdL+dJOF/VKynSo= X-Received: by 2002:a6b:8e0f:: with SMTP id q15mr4184757iod.186.1568291113001; Thu, 12 Sep 2019 05:25:13 -0700 (PDT) MIME-Version: 1.0 References: <20190906072548.12304-1-rmody@marvell.com> <20190906072548.12304-4-rmody@marvell.com> In-Reply-To: <20190906072548.12304-4-rmody@marvell.com> From: Jerin Jacob Date: Thu, 12 Sep 2019 17:55:02 +0530 Message-ID: To: Rasesh Mody Cc: dev@dpdk.org, ferruh.yigit@intel.com, Jerin Jacob , GR-Everest-DPDK-Dev@marvell.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/5] net/bnx2x: update to latest FW 7.13.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 6, 2019 at 12:56 PM Rasesh Mody wrote: > > Use latest firmware 7.13.11. > > Some of the fixes included with this FW are as following: > - Packets from a VF with pvid configured which were sent with a > different vlan were transmitted instead of being discarded. > - In some multi-function configurations, inter-PF and inter-VF > Tx switching is incorrectly enabled. > - Wrong assert code in FLR final cleanup in case it is sent not > after FLR. > - Chip may stall in very rare cases under heavy traffic with FW GRO > enabled. > - VF malicious notification error fixes. > - Default gre tunnel to IPGRE which allows proper RSS for IPGRE > packets, L2GRE traffic will reach single queue. > - Removes unnecessary internal mem config, latest FW performs this > autonomously. > > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c | 36 +--- > drivers/net/bnx2x/bnx2x.h | 5 +- > drivers/net/bnx2x/ecore_fw_defs.h | 252 ++++++++++++----------- > drivers/net/bnx2x/ecore_hsi.h | 2 +- > drivers/net/bnx2x/ecore_init.h | 212 +++++++++---------- > drivers/net/bnx2x/ecore_init_ops.h | 224 ++++++++++---------- > drivers/net/bnx2x/ecore_mfw_req.h | 10 +- > drivers/net/bnx2x/ecore_sp.c | 39 ++-- > drivers/net/bnx2x/ecore_sp.h | 319 ++++++++++++++++++++++++----- > 9 files changed, 680 insertions(+), 419 deletions(-) Please update the release note as well. > > diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h > index fce715b6d..11b9f77fb 100644 > --- a/drivers/net/bnx2x/ecore_sp.h > +++ b/drivers/net/bnx2x/ecore_sp.h > @@ -135,6 +135,7 @@ typedef rte_spinlock_t ECORE_MUTEX_SPIN; > #define SC_ILT(sc) ((sc)->ilt) > #define ILOG2(x) bnx2x_ilog2(x) > > +#if 0 Found dead code. Don't just copy-paste code from some SDK code. Please clean the code properly and submit the next version. > #define ECORE_ILT_ZALLOC(x, y, size, str) \ > do { \ > x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ > @@ -150,6 +151,23 @@ typedef rte_spinlock_t ECORE_MUTEX_SPIN; > } \ > } \ > } while (0) > +#else