From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C53C1A0A02; Thu, 25 Mar 2021 13:59:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACBFB4067B; Thu, 25 Mar 2021 13:59:04 +0100 (CET) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id BCD7D40147 for ; Thu, 25 Mar 2021 13:59:03 +0100 (CET) Received: by mail-il1-f181.google.com with SMTP id c17so2017597ilj.7 for ; Thu, 25 Mar 2021 05:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xs7ws1QxWymAg1aHO2e9nBCx310BERiYHJcTZyaUh+M=; b=PkzReMvNsf4zUzlZ+dWxo5Jpo9FnVDX/oeU/h3CH8EUdGZ+ijmNVJzFbLfCWwbXZRc sbVwX7hH/RHIufBeSqCDRUYureU3DDk1Dop5JyCdKLltp0Tcg8HRZXrMP5uv8vQnF0iH KgCMUjNM5OQXKnKjN2yq9fBTVT0X9W0V5PgSTvSwH/8atzn8GmhRXY+4hq4gQbPt88aK 9Da2K1S52kQAWQhTqI2YZOVdm26ycTa5fumZdVApslfKo612UrKQAc0CDz4zblWEN9Cj kXhAUOI3StKoJ7bnEyFH28oeEbZsMwGl5Gqt85pHJlybS6WYPVBSs5XMEIqYU8PdaRLJ VOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xs7ws1QxWymAg1aHO2e9nBCx310BERiYHJcTZyaUh+M=; b=lXKsoYSMu9/BO6LSaZoYv6dyPdGywCYNnz9kXCceEXnPgxetC1waH861FXm6gpQM+9 XjaFzRzZpXZpq9dJdfyKQtCbisJqQFif4g7qOPdW+Yo4hMbrEZvTfKKsV+13+jKLIVjs d/eaM2llx8hXldhJgM/M451ss4JzJ/YtBLZNAOkMtQeFfBbAXCl0nZztLkNJNx+KnBG5 psPr9wQ9PEv4Om7iEJZwLPC9JOm79voBUSnMikFFuHLSotv/OTcY9SsGA0E7p7qRg65R ADXFiI2UWW2CDyv2CgdSbz7Z2yMchhTeOMWFN0I7IyTUWwin0hJ3+Gt7I6b4W2amv4zU Fuqg== X-Gm-Message-State: AOAM533rT9VR2FX7VTgb6GJVBgvSl5/r0cvLpBvMJVVh5zCJpeaXfmRQ MjGaSAUY2Oe7e1S25E3/iZ6eoSHRYlE78OYucGI= X-Google-Smtp-Source: ABdhPJz18tLbCuNcTY+2uP5Jg7dXwLOah7rNHsVnH+oElGUcNjoSoVl4QOPsC9JTt/6b2pYno++7tU83iUwERhHQclM= X-Received: by 2002:a05:6e02:198e:: with SMTP id g14mr6260408ilf.271.1616677142718; Thu, 25 Mar 2021 05:59:02 -0700 (PDT) MIME-Version: 1.0 References: <20210225170238.15581-1-pbhagavatula@marvell.com> <11975004.s7UMkAiPBC@thomas> <5cb9bec3-6d4e-7867-e8d7-9c3d55ec78ef@ashroe.eu> <5442273.ffSK4IfYTI@thomas> <0564d636-3088-9b3e-1226-2767996d7f2a@ashroe.eu> In-Reply-To: <0564d636-3088-9b3e-1226-2767996d7f2a@ashroe.eu> From: Jerin Jacob Date: Thu, 25 Mar 2021 18:28:41 +0530 Message-ID: To: "Kinsella, Ray" Cc: Thomas Monjalon , Pavan Nikhilesh , Jerin Jacob , dpdk-dev , Harman Kalra , Nithin Dabilpuram , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 25, 2021 at 6:17 PM Kinsella, Ray wrote: > > > > On 25/03/2021 12:46, Jerin Jacob wrote: > > On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon wrote: > >> > >> 25/03/2021 11:58, Kinsella, Ray: > >>> On 25/03/2021 10:46, Thomas Monjalon wrote: > >>>> 25/03/2021 11:42, Thomas Monjalon: > >>>>> 24/03/2021 11:55, Jerin Jacob: > >>>>>> On Thu, Feb 25, 2021 at 10:33 PM wrote: > >>>>>>> > >>>>>>> From: Pavan Nikhilesh > >>>>>>> > >>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux. > >>>>>>> > >>>>>>> Signed-off-by: Pavan Nikhilesh > >>>>>> > >>>>>> Series Acked-by: Jerin Jacob > >>>>> > >>>>> I've reorganized the commits per family of drivers, > >>>>> so it makes more sense than grouping per driver class > >>>>> with "common/octeontx" for title for all: > >>>>> > >>>>> net/thunderx: enable build only on 64-bit Linux > >>>>> common/octeontx: enable build only on 64-bit Linux > >>>>> common/octeontx2: enable build only on 64-bit Linux > >>>>> > >>>>> and applied. > >>>> > >>>> Actually not applied yet. > >>>> I'm not sure what to do for the ABI check which is broken > >>>> because some drivers are not compiled anymore in 32-bit build. > >>>> I've workarounded locally by removing the dump files in the reference build. > >>>> Should we add an exception in libabigail.abignore? > >>>> > >>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage. > >>> > >>> From the policy ... > >>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change." > >> > >> So the patches should wait 21.11. > >> Everybody agree? > > > > Looks good to me to postpone. > > > > @Ray Kinsella @Thomas Monjalon @McDaniel, Timothy @David Marchand @Neil Horman > > > > Currently, I merged DLB v1 driver removal patch to next-eventdev. Is > > this ABI breakge[1]? > > > > http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/ > > > > [1] > > From the policy ... > > "Updates to the minimum hardware requirements, which drop support for > > hardware which was previously supported, should be treated as an ABI > > change." > > +1 Is +1 for not to remove the dlb driver or remove it?