From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: jerinj@marvell.com, dev@dpdk.org
Subject: Re: [PATCH v2 00/18] add Marvell cn20k SOC support for mempool and net
Date: Tue, 1 Oct 2024 16:31:14 +0530 [thread overview]
Message-ID: <CALBAE1PaQvx-xZow5mtn5tC-95wZBgse-VMA553h0DNyKtFRiA@mail.gmail.com> (raw)
In-Reply-To: <20240926160158.3206321-1-ndabilpuram@marvell.com>
On Fri, Sep 27, 2024 at 9:19 AM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> This series adds support for Marvell cn20k SOC for mempool and
> net PMD's.
>
> This series also adds few net/cnxk PMD updates to expose IPsec
> features supported by HW that are very custom in nature and
> some enhancements for cn10k.
>
>
> Ashwin Sekhar T K (4):
> mempool/cnxk: add cn20k PCI device ids
> common/cnxk: accommodate change in aura field width
> common/cnxk: use new NPA aq enq mbox for cn20k
> mempool/cnxk: initialize mempool ops for cn20k
>
> Nithin Dabilpuram (9):
> net/cnxk: add cn20k base control path support
> net/cnxk: support Rx function select for cn20k
> net/cnxk: support Tx function select for cn20k
> net/cnxk: support Rx burst scalar for cn20k
> net/cnxk: support Rx burst vector for cn20k
> net/cnxk: support Tx burst scalar for cn20k
> net/cnxk: support Tx multi-seg in cn20k
> net/cnxk: support Tx burst vector for cn20k
> net/cnxk: support Tx multi-seg in vector for cn20k
>
> Satha Rao (5):
> common/cnxk: add cn20k NIX register definitions
> common/cnxk: support NIX queue config for cn20k
> common/cnxk: support bandwidth profile for cn20k
> common/cnxk: support NIX debug for cn20k
> common/cnxk: add RSS support for cn20k
>
> v2:
> - Moved out 15 patches to seperate series
> - Updated release notes
Good to merge next version.
1)Please consider changing release note update as following
+* **Updated Marvell cnxk mempool driver.**
+
+ * Added mempool driver support for CN20K SoC.
+
+* **Updated Marvell cnxk net driver.**
+
+ * Added ethdev driver support for CN20K SoC.
+
2) Please fix following genuine check path issues.
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#109: FILE: drivers/net/cnxk/cn20k_ethdev.c:75:
+ txq->tx_compl.ptr = (struct rte_mbuf **)plt_zmalloc(
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on
the right side of the test
#183: FILE: drivers/net/cnxk/cn20k_ethdev.c:149:
+ PLT_STATIC_ASSERT(ROC_NIX_INL_SA_BASE_ALIGN == BIT_ULL(16));
WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like macro
#341: FILE: drivers/net/cnxk/cn20k_rx.h:219:
+#define NIX_RX_RECV(fn, flags)
\
+ uint16_t __rte_noinline __rte_hot fn(void *rx_queue, struct
rte_mbuf **rx_pkts, \
+ uint16_t pkts)
\
+ {
\
+ RTE_SET_USED(rx_queue);
\
+ RTE_SET_USED(rx_pkts);
\
+ RTE_SET_USED(pkts);
\
+ return 0;
\
+ }
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements
should be avoided
#341: FILE: drivers/net/cnxk/cn20k_rx.h:219:
+#define NIX_RX_RECV(fn, flags)
\
+ uint16_t __rte_noinline __rte_hot fn(void *rx_queue, struct
rte_mbuf **rx_pkts, \
+ uint16_t pkts)
\
+ {
\
+ RTE_SET_USED(rx_queue);
\
+ RTE_SET_USED(rx_pkts);
\
+ RTE_SET_USED(pkts);
\
+ return 0;
\
+ }
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as
'(flags)' to avoid precedence issues
#351: FILE: drivers/net/cnxk/cn20k_rx.h:229:
+#define NIX_RX_RECV_MSEG(fn, flags) NIX_RX_RECV(fn, flags | NIX_RX_MULTI_SEG_F)
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1470: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:27:
+ return cn20k_nix_recv_pkts_vector(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1482: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:39:
+ return cn20k_nix_recv_pkts(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1492: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:49:
+ return cn20k_nix_recv_pkts_vector(
WARNING:MACRO_ARG_UNUSED: Argument 'sz' is not used in function-like macro
#343: FILE: drivers/net/cnxk/cn20k_tx.h:211:
+#define T(name, sz, flags)
\
+ uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name(
\
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts);
WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like macro
#343: FILE: drivers/net/cnxk/cn20k_tx.h:211:
+#define T(name, sz, flags)
\
+ uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name(
\
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#343: FILE: drivers/net/cnxk/cn20k_tx.h:211:
+#define T(name, sz, flags)
\
+ uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name(
\
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t
pkts); \
+ uint16_t __rte_noinline __rte_hot
cn20k_nix_xmit_pkts_vec_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts);
WARNING:MACRO_ARG_UNUSED: Argument 'sz' is not used in function-like macro
#356: FILE: drivers/net/cnxk/cn20k_tx.h:224:
+#define NIX_TX_XMIT(fn, sz, flags)
\
+ uint16_t __rte_noinline __rte_hot fn(void *tx_queue, struct
rte_mbuf **tx_pkts, \
+ uint16_t pkts)
\
+ {
\
+ RTE_SET_USED(tx_queue);
\
+ RTE_SET_USED(tx_pkts);
\
+ RTE_SET_USED(pkts);
\
+ return 0;
\
+ }
WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like macro
#356: FILE: drivers/net/cnxk/cn20k_tx.h:224:
+#define NIX_TX_XMIT(fn, sz, flags)
\
+ uint16_t __rte_noinline __rte_hot fn(void *tx_queue, struct
rte_mbuf **tx_pkts, \
+ uint16_t pkts)
\
+ {
\
+ RTE_SET_USED(tx_queue);
\
+ RTE_SET_USED(tx_pkts);
\
+ RTE_SET_USED(pkts);
\
+ return 0;
\
+ }
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1382: FILE: drivers/net/cnxk/tx/cn20k/tx_all_offload.c:18:
+ return cn20k_nix_xmit_pkts_mseg(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1395: FILE: drivers/net/cnxk/tx/cn20k/tx_all_offload.c:31:
+ return cn20k_nix_xmit_pkts_vector(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#145: FILE: drivers/net/cnxk/cn20k_rx.h:547:
+ rte_prefetch0(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#147: FILE: drivers/net/cnxk/cn20k_rx.h:549:
+ rte_prefetch0(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#149: FILE: drivers/net/cnxk/cn20k_rx.h:551:
+ rte_prefetch0(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#151: FILE: drivers/net/cnxk/cn20k_rx.h:553:
+ rte_prefetch0(
total: 0 errors, 0 warnings, 6 checks, 475 lines checked
### [PATCH] net/cnxk: support Tx burst scalar for cn20k
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#234: FILE: drivers/net/cnxk/cn20k_tx.h:543:
+ cmd23 = vsetq_lane_u64(
next prev parent reply other threads:[~2024-10-01 11:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 8:58 [PATCH 00/33] " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 01/33] mempool/cnxk: add cn20k PCI device ids Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 02/33] common/cnxk: accommodate change in aura field width Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 03/33] common/cnxk: use new NPA aq enq mbox for cn20k Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 04/33] mempool/cnxk: initialize mempool ops " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 05/33] net/cnxk: added telemetry support do dump SA information Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 06/33] net/cnxk: handle timestamp correctly for VF Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 07/33] net/cnxk: update Rx offloads to handle timestamp Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 08/33] event/cnxk: handle timestamp for event mode Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 09/33] net/cnxk: update mbuf and rearm data for Rx inject packets Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 10/33] common/cnxk: remove restriction to clear RPM stats Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 11/33] common/cnxk: allow MAC address set/add with active VFs Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 12/33] net/cnxk: move PMD function defines to common code Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 13/33] common/cnxk: add cn20k NIX register definitions Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 14/33] common/cnxk: support NIX queue config for cn20k Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 15/33] common/cnxk: support bandwidth profile " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 16/33] common/cnxk: support NIX debug " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 17/33] common/cnxk: add RSS support " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 18/33] net/cnxk: add cn20k base control path support Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 19/33] net/cnxk: support Rx function select for cn20k Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 20/33] net/cnxk: support Tx " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 21/33] net/cnxk: support Rx burst scalar " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 22/33] net/cnxk: support Rx burst vector " Nithin Dabilpuram
2024-09-10 8:58 ` [PATCH 23/33] net/cnxk: support Tx burst scalar " Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 24/33] net/cnxk: support Tx multi-seg in cn20k Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 25/33] net/cnxk: support Tx burst vector for cn20k Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 26/33] net/cnxk: support Tx multi-seg in " Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 27/33] common/cnxk: add flush wait after write of inline ctx Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 28/33] common/cnxk: fix CPT HW word size for outbound SA Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 29/33] net/cnxk: add PMD APIs for IPsec SA base and flush Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 30/33] net/cnxk: add PMD APIs to submit CPT instruction Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 31/33] net/cnxk: add PMD API to retrieve CPT queue statistics Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 32/33] net/cnxk: add option to enable custom inbound sa usage Nithin Dabilpuram
2024-09-10 8:59 ` [PATCH 33/33] net/cnxk: add PMD API to retrieve the model string Nithin Dabilpuram
2024-09-23 15:44 ` [PATCH 00/33] add Marvell cn20k SOC support for mempool and net Jerin Jacob
2024-09-26 16:01 ` [PATCH v2 00/18] " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 01/18] mempool/cnxk: add cn20k PCI device ids Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 02/18] common/cnxk: accommodate change in aura field width Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 03/18] common/cnxk: use new NPA aq enq mbox for cn20k Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 04/18] mempool/cnxk: initialize mempool ops " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 05/18] common/cnxk: add cn20k NIX register definitions Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 06/18] common/cnxk: support NIX queue config for cn20k Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 07/18] common/cnxk: support bandwidth profile " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 08/18] common/cnxk: support NIX debug " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 09/18] common/cnxk: add RSS support " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 10/18] net/cnxk: add cn20k base control path support Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 11/18] net/cnxk: support Rx function select for cn20k Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 12/18] net/cnxk: support Tx " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 13/18] net/cnxk: support Rx burst scalar " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 14/18] net/cnxk: support Rx burst vector " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 15/18] net/cnxk: support Tx burst scalar " Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 16/18] net/cnxk: support Tx multi-seg in cn20k Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 17/18] net/cnxk: support Tx burst vector for cn20k Nithin Dabilpuram
2024-09-26 16:01 ` [PATCH v2 18/18] net/cnxk: support Tx multi-seg in " Nithin Dabilpuram
2024-10-01 11:01 ` Jerin Jacob [this message]
2024-10-01 12:40 ` [PATCH v3 00/18] add Marvell cn20k SOC support for mempool and net Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 01/18] mempool/cnxk: add cn20k PCI device ids Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 02/18] common/cnxk: accommodate change in aura field width Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 03/18] common/cnxk: use new NPA aq enq mbox for cn20k Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 04/18] mempool/cnxk: initialize mempool ops " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 05/18] common/cnxk: add cn20k NIX register definitions Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 06/18] common/cnxk: support NIX queue config for cn20k Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 07/18] common/cnxk: support bandwidth profile " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 08/18] common/cnxk: support NIX debug " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 09/18] common/cnxk: add RSS support " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 10/18] net/cnxk: add cn20k base control path support Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 11/18] net/cnxk: support Rx function select for cn20k Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 12/18] net/cnxk: support Tx " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 13/18] net/cnxk: support Rx burst scalar " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 14/18] net/cnxk: support Rx burst vector " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 15/18] net/cnxk: support Tx burst scalar " Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 16/18] net/cnxk: support Tx multi-seg in cn20k Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 17/18] net/cnxk: support Tx burst vector for cn20k Nithin Dabilpuram
2024-10-01 12:40 ` [PATCH v3 18/18] net/cnxk: support Tx multi-seg in " Nithin Dabilpuram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PaQvx-xZow5mtn5tC-95wZBgse-VMA553h0DNyKtFRiA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).