From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C287245A79; Tue, 1 Oct 2024 13:01:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60CDA4027E; Tue, 1 Oct 2024 13:01:44 +0200 (CEST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by mails.dpdk.org (Postfix) with ESMTP id A9FBE4027C for ; Tue, 1 Oct 2024 13:01:42 +0200 (CEST) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4582face04dso49075631cf.1 for ; Tue, 01 Oct 2024 04:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727780502; x=1728385302; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SP94XjRDtoy9KKprnBGcTXEABLLzgZg0VNhiaD9dvjc=; b=M+hhUME+Y628e8XRUvYu6WGsjnM5JabLTNzGQWgJJK1LgdoQu5EAmfL+N1SSxacQBQ SyIPqdfU8cRNF6SKlQ2BaTNMf6TM+6h1vUdb58lYT0YaKbYDv38voOEOJRjFjbdj4Q4V D9Wav3FGY7ON7kLs5oKDELrRfSmxwGU4rnmdxKajYcBR+LrKGB9MvMT8jKcwZTNgpnI4 E2jHjk21ydEhfI98VRQ0s+fjyqDA5BYAQaHwy20uoc010VOyfbgunSKu94rMgVh3+WHr iBKgTyUD/Crt4J6aK2Jwkiri1yTEZPn6/6GYRZNYOapHYRFyLRYCsIUmdElurWxk4iP3 0RSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727780502; x=1728385302; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SP94XjRDtoy9KKprnBGcTXEABLLzgZg0VNhiaD9dvjc=; b=irD1qPIvq1CsSGxKtv6OCwTbXhDQRSauQY9/Jt99cI+Yzsy8V28QqLDSqovTMJrDZq j121v3Fb6Kg/s0g4ae9OKqueTDGCwRzVcIfXTWQKQHABqvhy2f5F4ePfLaxrw6hDRRkg w48C+T6l3r3n4kC5HdGdxZaUky8AtAMMFy7f1CLEs8SZszO9UQez7CGKEn29rUIN/DKO OZo6YKvqqYLx0uMWV10BgxErVr4I0y7PP7VPBGtjv3UqdJC17qQ3bL8w7H0wkEOTXkZ3 6w/VjIJ0/UWZu+ArrDLATYs65ZbQT2f+9dLDUae5Enq7/STDWbG1GLbhW9OYke1KSazV nPCA== X-Forwarded-Encrypted: i=1; AJvYcCWbPbFHxVFOfDPQeU12BEoMtfSHi5CQsw3zRiaIb/E2Vf9N2fQdDJAtCYdoq35iEpl3ebY=@dpdk.org X-Gm-Message-State: AOJu0Yy3t9wFAliCDAlOOyj1CIs3y9IPuh1UU7jBbNTQMsaRVCJaVjEW HWWhoaF4yhEDIe8j/u9EYxAQi9on1u3AJFaxwt+xtrF9n1boJGs5KLBcCiD204nHDtpLaQZ12Ui ywQ/s5Iqfe2m8gU+EU0bgtRLk9mofA/MQyZI= X-Google-Smtp-Source: AGHT+IELbwvRaCu+rM16a3ENn4qRvimH1hxRHKAwu19MvnBlWa3qdSszZH51NgH0AOKUrKWFiUA16M65Yuo4pFuFWsA= X-Received: by 2002:ac8:7f04:0:b0:458:2e58:46d with SMTP id d75a77b69052e-45d73a5e67cmr41615151cf.12.1727780501658; Tue, 01 Oct 2024 04:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20240910085909.1514457-1-ndabilpuram@marvell.com> <20240926160158.3206321-1-ndabilpuram@marvell.com> In-Reply-To: <20240926160158.3206321-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Tue, 1 Oct 2024 16:31:14 +0530 Message-ID: Subject: Re: [PATCH v2 00/18] add Marvell cn20k SOC support for mempool and net To: Nithin Dabilpuram Cc: jerinj@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 27, 2024 at 9:19=E2=80=AFAM Nithin Dabilpuram wrote: > > This series adds support for Marvell cn20k SOC for mempool and > net PMD's. > > This series also adds few net/cnxk PMD updates to expose IPsec > features supported by HW that are very custom in nature and > some enhancements for cn10k. > > > Ashwin Sekhar T K (4): > mempool/cnxk: add cn20k PCI device ids > common/cnxk: accommodate change in aura field width > common/cnxk: use new NPA aq enq mbox for cn20k > mempool/cnxk: initialize mempool ops for cn20k > > Nithin Dabilpuram (9): > net/cnxk: add cn20k base control path support > net/cnxk: support Rx function select for cn20k > net/cnxk: support Tx function select for cn20k > net/cnxk: support Rx burst scalar for cn20k > net/cnxk: support Rx burst vector for cn20k > net/cnxk: support Tx burst scalar for cn20k > net/cnxk: support Tx multi-seg in cn20k > net/cnxk: support Tx burst vector for cn20k > net/cnxk: support Tx multi-seg in vector for cn20k > > Satha Rao (5): > common/cnxk: add cn20k NIX register definitions > common/cnxk: support NIX queue config for cn20k > common/cnxk: support bandwidth profile for cn20k > common/cnxk: support NIX debug for cn20k > common/cnxk: add RSS support for cn20k > > v2: > - Moved out 15 patches to seperate series > - Updated release notes Good to merge next version. 1)Please consider changing release note update as following +* **Updated Marvell cnxk mempool driver.** + + * Added mempool driver support for CN20K SoC. + +* **Updated Marvell cnxk net driver.** + + * Added ethdev driver support for CN20K SoC. + 2) Please fix following genuine check path issues. CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #109: FILE: drivers/net/cnxk/cn20k_ethdev.c:75: + txq->tx_compl.ptr =3D (struct rte_mbuf **)plt_zmalloc( WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #183: FILE: drivers/net/cnxk/cn20k_ethdev.c:149: + PLT_STATIC_ASSERT(ROC_NIX_INL_SA_BASE_ALIGN =3D=3D BIT_ULL(= 16)); WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like mac= ro #341: FILE: drivers/net/cnxk/cn20k_rx.h:219: +#define NIX_RX_RECV(fn, flags) \ + uint16_t __rte_noinline __rte_hot fn(void *rx_queue, struct rte_mbuf **rx_pkts, \ + uint16_t pkts) \ + { \ + RTE_SET_USED(rx_queue); \ + RTE_SET_USED(rx_pkts); \ + RTE_SET_USED(pkts); \ + return 0; \ + } WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #341: FILE: drivers/net/cnxk/cn20k_rx.h:219: +#define NIX_RX_RECV(fn, flags) \ + uint16_t __rte_noinline __rte_hot fn(void *rx_queue, struct rte_mbuf **rx_pkts, \ + uint16_t pkts) \ + { \ + RTE_SET_USED(rx_queue); \ + RTE_SET_USED(rx_pkts); \ + RTE_SET_USED(pkts); \ + return 0; \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as '(flags)' to avoid precedence issues #351: FILE: drivers/net/cnxk/cn20k_rx.h:229: +#define NIX_RX_RECV_MSEG(fn, flags) NIX_RX_RECV(fn, flags | NIX_RX_MULTI_S= EG_F) CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1470: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:27: + return cn20k_nix_recv_pkts_vector( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1482: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:39: + return cn20k_nix_recv_pkts( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1492: FILE: drivers/net/cnxk/rx/cn20k/rx_all_offload.c:49: + return cn20k_nix_recv_pkts_vector( WARNING:MACRO_ARG_UNUSED: Argument 'sz' is not used in function-like macro #343: FILE: drivers/net/cnxk/cn20k_tx.h:211: +#define T(name, sz, flags) \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like mac= ro #343: FILE: drivers/net/cnxk/cn20k_tx.h:211: +#define T(name, sz, flags) \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #343: FILE: drivers/net/cnxk/cn20k_tx.h:211: +#define T(name, sz, flags) \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); \ + uint16_t __rte_noinline __rte_hot cn20k_nix_xmit_pkts_vec_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts); WARNING:MACRO_ARG_UNUSED: Argument 'sz' is not used in function-like macro #356: FILE: drivers/net/cnxk/cn20k_tx.h:224: +#define NIX_TX_XMIT(fn, sz, flags) \ + uint16_t __rte_noinline __rte_hot fn(void *tx_queue, struct rte_mbuf **tx_pkts, \ + uint16_t pkts) \ + { \ + RTE_SET_USED(tx_queue); \ + RTE_SET_USED(tx_pkts); \ + RTE_SET_USED(pkts); \ + return 0; \ + } WARNING:MACRO_ARG_UNUSED: Argument 'flags' is not used in function-like mac= ro #356: FILE: drivers/net/cnxk/cn20k_tx.h:224: +#define NIX_TX_XMIT(fn, sz, flags) \ + uint16_t __rte_noinline __rte_hot fn(void *tx_queue, struct rte_mbuf **tx_pkts, \ + uint16_t pkts) \ + { \ + RTE_SET_USED(tx_queue); \ + RTE_SET_USED(tx_pkts); \ + RTE_SET_USED(pkts); \ + return 0; \ + } CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1382: FILE: drivers/net/cnxk/tx/cn20k/tx_all_offload.c:18: + return cn20k_nix_xmit_pkts_mseg( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1395: FILE: drivers/net/cnxk/tx/cn20k/tx_all_offload.c:31: + return cn20k_nix_xmit_pkts_vector( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #145: FILE: drivers/net/cnxk/cn20k_rx.h:547: + rte_prefetch0( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #147: FILE: drivers/net/cnxk/cn20k_rx.h:549: + rte_prefetch0( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #149: FILE: drivers/net/cnxk/cn20k_rx.h:551: + rte_prefetch0( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #151: FILE: drivers/net/cnxk/cn20k_rx.h:553: + rte_prefetch0( total: 0 errors, 0 warnings, 6 checks, 475 lines checked ### [PATCH] net/cnxk: support Tx burst scalar for cn20k CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #234: FILE: drivers/net/cnxk/cn20k_tx.h:543: + cmd23 =3D vsetq_lane_u64(