From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B5C4EA04BC;
Sun, 27 Sep 2020 14:27:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A69771D5FA;
Sun, 27 Sep 2020 14:27:29 +0200 (CEST)
Received: from mail-il1-f196.google.com (mail-il1-f196.google.com
[209.85.166.196]) by dpdk.org (Postfix) with ESMTP id C50D31D5F9
for <dev@dpdk.org>; Sun, 27 Sep 2020 14:27:27 +0200 (CEST)
Received: by mail-il1-f196.google.com with SMTP id y2so7138779ila.0
for <dev@dpdk.org>; Sun, 27 Sep 2020 05:27:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=Nu21Dzqdjd/djMaOYXHN9laiIMnaL7sEe+j/1AeeKTs=;
b=hMFobpVltzjWFNAdUlTFvl6cG98ryFSfW+6FiwDIKB+0SKpT0mNvAiehPObO39hLJ9
krxXUak2Erx5ojebJKg2/xX1idC13Yt9KYnxSG9uyHqrZsFlKo/seeR5hPZDl818H9kc
xxZSi1itKU2z8B7cTid3GGhuv1rRiQtkgrYnNCApHCaKQZcg/q/+i2+f5IW87YWL1Qek
4YGA4r7OON6Y2Aum00SrdBINqZ7T6AwSRK998gZ1if5Zl21ExsetPtJwXP4del9GWnvM
cUsXs15OoCUDYx0G97R+MevXKUsq55IQnuFl9BrZejP7YTSaNYL/DZK2ehv3sRnS6AiI
KyUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Nu21Dzqdjd/djMaOYXHN9laiIMnaL7sEe+j/1AeeKTs=;
b=PTCrcV2tEZxCSRw8oYZ4r6zMa2UZ1BAC5G5dtuBkHJqsvcOznNyEgNPpeKjPxSAibL
XdDuvSXrY5aUA3Q1baUO8SMSR2M9QDPYFFzToeEpxkjb9tGiMJr2a04Jg4VtPhNzwD2E
o4ftUpbhstFbWD8Vx1xhxMpl5P6Q67etjwjaKagxjLYetCzurK486uzls++PfUkbw7w6
2/se5wicgztdmuSwwGZ0IuDjOYjDM/f6LuItdv4T7oMYuqe8B/juhnJpBkQqFS7au/95
CKkk0GyadoENVlo4UeylqN03jiyAx424GH7UAQ8QP+eplzE7q8XrsUKfbO4vtL977ozW
rgZw==
X-Gm-Message-State: AOAM530Yw6+b0+wOfyt0hHZfXMtWbPJxa6dy4URLgy4W6S5qLdnG6EDr
BgJDBL3rHkrtsYYa1+RMURxPIOSXGHQMedY9AGM=
X-Google-Smtp-Source: ABdhPJylFU+Gf7HgIPo0a8mNtMaF6Es2kH7nXFaOz1DVgioaJCbrfeOvKG+UC+/eDidQMT2WvSKcBAS/Rtz8Ua/tM2w=
X-Received: by 2002:a05:6e02:e01:: with SMTP id
a1mr6874163ilk.162.1601209646117;
Sun, 27 Sep 2020 05:27:26 -0700 (PDT)
MIME-Version: 1.0
References: <20200908100956.25868-1-adwivedi@marvell.com>
<20200917051638.1904-1-adwivedi@marvell.com>
<20200917051638.1904-4-adwivedi@marvell.com>
In-Reply-To: <20200917051638.1904-4-adwivedi@marvell.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sun, 27 Sep 2020 17:57:10 +0530
Message-ID: <CALBAE1PbXhgA=3ePM++jWVdes9FmcP_qnsoTUQDkzuEQGv0fMw@mail.gmail.com>
To: Ankur Dwivedi <adwivedi@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>, Akhil Goyal <akhil.goyal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2 3/3] event/octeontx2: add crypto adapter
datapath
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Sep 17, 2020 at 10:47 AM Ankur Dwivedi <adwivedi@marvell.com> wrote:
>
> In the op new mode of crypto adapter, the completed crypto operation
> is submitted to the event device by the OCTEON TX2 crypto PMD.
> During event device dequeue the result of crypto operation is checked.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> @@ -66,8 +67,10 @@ otx2_ssogws_get_work(struct otx2_ssogws *ws, struct rte_event *ev,
> ws->cur_tt = event.sched_type;
> ws->cur_grp = event.queue_id;
>
> - if (event.sched_type != SSO_TT_EMPTY &&
> - event.event_type == RTE_EVENT_TYPE_ETHDEV) {
> + if (event.sched_type == SSO_TT_EMPTY)
> + goto setev_and_return;
Please move the security updation under the security flag template to
avoid performance impact
on nonsecurity case.
> +
> + if (event.event_type == RTE_EVENT_TYPE_ETHDEV) {
> otx2_wqe_to_mbuf(get_work1, mbuf, event.sub_event_type,
> (uint32_t) event.get_work0, flags, lookup_mem);
> /* Extracting tstamp, if PTP enabled*/
> @@ -76,8 +79,11 @@ otx2_ssogws_get_work(struct otx2_ssogws *ws, struct rte_event *ev,
> otx2_nix_mbuf_to_tstamp((struct rte_mbuf *)mbuf, ws->tstamp,
> flags, (uint64_t *)tstamp_ptr);
> get_work1 = mbuf;
> + } else if (event.event_type == RTE_EVENT_TYPE_CRYPTODEV) {
> + get_work1 = otx2_handle_crypto_event(get_work1);
> }
>