From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAD53A0547; Tue, 15 Nov 2022 08:08:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C784F40DFD; Tue, 15 Nov 2022 08:08:45 +0100 (CET) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mails.dpdk.org (Postfix) with ESMTP id 361C540150 for ; Tue, 15 Nov 2022 08:08:44 +0100 (CET) Received: by mail-vs1-f51.google.com with SMTP id t14so13804066vsr.9 for ; Mon, 14 Nov 2022 23:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y6R+G1pmnU27D9/qMds3HtwXHQbVlr7hkluSuMbWr4c=; b=HlmFRR9hVddQZfgN77MYir3CogakFbAcodVuEgEzWVLqyiWDQ/PdjFiC11ar5FgwFE AI4AEopIea5dZNEdx84VWx+omR8bRHIU3g6jVDjcdcJGcY+s2LVc0NlWEFQc4DBhyKbW CZHq7P2ZHednMted51sT9HW8EAc2V1W8dnCvRzcZrqLD0aP60bZB4rfdiXDEpaPg5Bya NyxWttiJauKMzaBvkv272KaIdfrAqc9GUOAhYFqP5FutvC3dm52zfBpsD07pMRQ8OPRN Muia36BDDLWuJrXcskNTiCot8jQXd5UAI3ufc9MbO+hXWZ1MiGu2cGkAG7AvEvvf8KSr pt6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y6R+G1pmnU27D9/qMds3HtwXHQbVlr7hkluSuMbWr4c=; b=qqzxh7hPbrrl/9XMIaNZhWCZ3jt2iNsfT0WI2p/g86tKOOGwG5jCmv0gW0zIOJoFdz A2FgyUFpy0YwtuiAVYgWNT2M9U0t/vwnP3KnOYivR3kH+VvuNZlD5rstBCf90acNmWk8 elIVlZhWOHR7Cx67F3fGcqvRbxJOmUiInLtw2jeSZdjpxDLL73QavDcWPKlzXt27RWcS hbzcS0v010j3deSCVUAbIM612fcFtE5LCX9lj9IV425H9Tbt+MVbndyF1Z7cWmViklCv e6+eolKKja9ipCgCTLMAuRZ940qsLesovWHxwviIm+YOOl+kVb7Z4XUmnaDGYS+QQYr+ 5goQ== X-Gm-Message-State: ANoB5pnACEzzwW+KVDDALJxSRon37goAiO+zvBUjwPzEJYBycU7yK5zK WDiPF4KB4+aoyaIjokgg8FEgWMdZCsFuTg/q7JI= X-Google-Smtp-Source: AA0mqf7x3rwfbO5+PdxYSpvH92MFLR5MGlEA6NpHhGrqq6RrSp8fQZ9ZVqSPlCAPAYT35dYoaDDr2VRgH9YJhIG6D8U= X-Received: by 2002:a67:e985:0:b0:3ab:8a0a:a528 with SMTP id b5-20020a67e985000000b003ab8a0aa528mr8204845vso.66.1668496123452; Mon, 14 Nov 2022 23:08:43 -0800 (PST) MIME-Version: 1.0 References: <20221115020948.18356-1-fengchengwen@huawei.com> In-Reply-To: <20221115020948.18356-1-fengchengwen@huawei.com> From: Jerin Jacob Date: Tue, 15 Nov 2022 12:38:16 +0530 Message-ID: Subject: Re: [PATCH] config/arm: make SoC-generic more generic To: Chengwen Feng , "Richardson, Bruce" , Konstantin Ananyev Cc: thomas@monjalon.net, dev@dpdk.org, ruifeng.wang@arm.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 15, 2022 at 7:46 AM Chengwen Feng wrote: > > The non-generic soc has 1280 max-lcores and 32 max-numas, but the > implementer-generic still has 256 max-lcores and 4 max-numas, which may > result in restrictions on the use of binaries compiled by soc-generic > in these systems. > > This patch changes the soc-generic max-lcores to 1280 and max-numas to > 32 to make it more generic. I think, it is not specific to ARM architecture issue. Even x86 config set as below. dpdk_conf.set('RTE_MAX_LCORE', 128) dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) I think, it makes sense to keep generic as "most commonly used max" per application, expectation cases can have separate config. Also, this is for SINGLE application, even if you have 1280 cores a single application most likely won't use that. So in that way this patch is not needed. > > Also, because single numa is a special case of multiple numas, mark > soc-generic's numa flag as true. > > Signed-off-by: Chengwen Feng > --- > config/arm/meson.build | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 6442ec9596..97b91cf609 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -32,8 +32,8 @@ implementer_generic = { > 'flags': [ > ['RTE_MACHINE', '"armv8a"'], > ['RTE_USE_C11_MEM_MODEL', true], > - ['RTE_MAX_LCORE', 256], > - ['RTE_MAX_NUMA_NODES', 4] > + ['RTE_MAX_LCORE', 1280], > + ['RTE_MAX_NUMA_NODES', 32] > ], > 'part_number_config': { > 'generic': { > @@ -271,7 +271,8 @@ implementers = { > soc_generic = { > 'description': 'Generic un-optimized build for armv8 aarch64 exec mode', > 'implementer': 'generic', > - 'part_number': 'generic' > + 'part_number': 'generic', > + 'numa': true > } > > soc_generic_aarch32 = { > -- > 2.17.1 >