DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: smadarf@marvell.com, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>, Liron Himi <lironh@marvell.com>,
	 Guy Kaneti <guyk@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/octeontx2: support flow action port id
Date: Sat, 27 Mar 2021 19:59:48 +0530
Message-ID: <CALBAE1Pc5brpxJYEvwx_TX2incVP0_o8BRm1w93QQfCgYvYAig@mail.gmail.com> (raw)
In-Reply-To: <20210325160321.22016-1-smadarf@marvell.com>

On Fri, Mar 26, 2021 at 3:18 PM <smadarf@marvell.com> wrote:
>
> From: Smadar Fuks <smadarf@marvell.com>
>
> Action port_id was not supported until now.
> In this patch the action port_id supports passing from input
> port PF to output port which is one of input port respective VF
>
> Signed-off-by: Smadar Fuks <smadarf@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks

> ---
>  doc/guides/nics/octeontx2.rst               |  6 +++
>  drivers/net/octeontx2/otx2_ethdev.c         |  6 +--
>  drivers/net/octeontx2/otx2_ethdev.h         |  5 +++
>  drivers/net/octeontx2/otx2_ethdev_devargs.c |  2 +-
>  drivers/net/octeontx2/otx2_flow_parse.c     | 47 ++++++++++++++++++++-
>  5 files changed, 61 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rst
> index cca7f7fc7..258c1693f 100644
> --- a/doc/guides/nics/octeontx2.rst
> +++ b/doc/guides/nics/octeontx2.rst
> @@ -401,6 +401,12 @@ Actions:
>     +----+-----------------------------------------+
>     | 11 | RTE_FLOW_ACTION_TYPE_OF_POP_VLAN        |
>     +----+-----------------------------------------+
> +   | 12 | RTE_FLOW_ACTION_TYPE_PORT_ID            |
> +   +----+-----------------------------------------+
> +
> +.. note::
> +
> +   ``RTE_FLOW_ACTION_TYPE_PORT_ID`` is only supported between PF and its VFs.
>
>  .. _table_octeontx2_supported_egress_action_types:
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index 389b66d03..4f95917e7 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -2802,6 +2802,6 @@ static struct rte_pci_driver pci_nix = {
>         .remove = nix_remove,
>  };
>
> -RTE_PMD_REGISTER_PCI(net_octeontx2, pci_nix);
> -RTE_PMD_REGISTER_PCI_TABLE(net_octeontx2, pci_nix_map);
> -RTE_PMD_REGISTER_KMOD_DEP(net_octeontx2, "vfio-pci");
> +RTE_PMD_REGISTER_PCI(OCTEONTX2_PMD, pci_nix);
> +RTE_PMD_REGISTER_PCI_TABLE(OCTEONTX2_PMD, pci_nix_map);
> +RTE_PMD_REGISTER_KMOD_DEP(OCTEONTX2_PMD, "vfio-pci");
> diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h
> index 99f0469d8..5a9dc9be0 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.h
> +++ b/drivers/net/octeontx2/otx2_ethdev.h
> @@ -164,6 +164,11 @@
>  /* Additional timesync values. */
>  #define OTX2_CYCLECOUNTER_MASK   0xffffffffffffffffULL
>
> +#define OCTEONTX2_PMD                  net_octeontx2
> +
> +#define otx2_ethdev_is_same_driver(dev) \
> +       (strcmp((dev)->device->driver->name, RTE_STR(OCTEONTX2_PMD)) == 0)
> +
>  enum nix_q_size_e {
>         nix_q_size_16,  /* 16 entries */
>         nix_q_size_64,  /* 64 entries */
> diff --git a/drivers/net/octeontx2/otx2_ethdev_devargs.c b/drivers/net/octeontx2/otx2_ethdev_devargs.c
> index 8d9feb3a8..83f905315 100644
> --- a/drivers/net/octeontx2/otx2_ethdev_devargs.c
> +++ b/drivers/net/octeontx2/otx2_ethdev_devargs.c
> @@ -201,7 +201,7 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev)
>         return -EINVAL;
>  }
>
> -RTE_PMD_REGISTER_PARAM_STRING(net_octeontx2,
> +RTE_PMD_REGISTER_PARAM_STRING(OCTEONTX2_PMD,
>                               OTX2_RSS_RETA_SIZE "=<64|128|256>"
>                               OTX2_IPSEC_IN_MAX_SPI "=<1-65535>"
>                               OTX2_SCL_ENABLE "=1"
> diff --git a/drivers/net/octeontx2/otx2_flow_parse.c b/drivers/net/octeontx2/otx2_flow_parse.c
> index bbb845811..63a33142a 100644
> --- a/drivers/net/octeontx2/otx2_flow_parse.c
> +++ b/drivers/net/octeontx2/otx2_flow_parse.c
> @@ -900,14 +900,17 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev,
>  {
>         struct otx2_eth_dev *hw = dev->data->dev_private;
>         struct otx2_npc_flow_info *npc = &hw->npc_flow;
> +       const struct rte_flow_action_port_id *port_act;
>         const struct rte_flow_action_count *act_count;
>         const struct rte_flow_action_mark *act_mark;
>         const struct rte_flow_action_queue *act_q;
>         const struct rte_flow_action_vf *vf_act;
> +       uint16_t pf_func, vf_id, port_id, pf_id;
> +       char if_name[RTE_ETH_NAME_MAX_LEN];
>         bool vlan_insert_action = false;
> +       struct rte_eth_dev *eth_dev;
>         const char *errmsg = NULL;
>         int sel_act, req_act = 0;
> -       uint16_t pf_func, vf_id;
>         int errcode = 0;
>         int mark = 0;
>         int rq = 0;
> @@ -983,6 +986,48 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev,
>                         }
>                         break;
>
> +               case RTE_FLOW_ACTION_TYPE_PORT_ID:
> +                       port_act = (const struct rte_flow_action_port_id *)
> +                               actions->conf;
> +                       port_id = port_act->id;
> +                       if (rte_eth_dev_get_name_by_port(port_id, if_name)) {
> +                               errmsg = "Name not found for output port id";
> +                               errcode = EINVAL;
> +                               goto err_exit;
> +                       }
> +                       eth_dev = rte_eth_dev_allocated(if_name);
> +                       if (!eth_dev) {
> +                               errmsg = "eth_dev not found for output port id";
> +                               errcode = EINVAL;
> +                               goto err_exit;
> +                       }
> +                       if (!otx2_ethdev_is_same_driver(eth_dev)) {
> +                               errmsg = "Output port id unsupported type";
> +                               errcode = ENOTSUP;
> +                               goto err_exit;
> +                       }
> +                       if (!otx2_dev_is_vf(otx2_eth_pmd_priv(eth_dev))) {
> +                               errmsg = "Output port should be VF";
> +                               errcode = ENOTSUP;
> +                               goto err_exit;
> +                       }
> +                       vf_id = otx2_eth_pmd_priv(eth_dev)->vf;
> +                       if (vf_id  >= hw->maxvf) {
> +                               errmsg = "Invalid vf for output port";
> +                               errcode = EINVAL;
> +                               goto err_exit;
> +                       }
> +                       pf_id = otx2_eth_pmd_priv(eth_dev)->pf;
> +                       if (pf_id != hw->pf) {
> +                               errmsg = "Output port unsupported PF";
> +                               errcode = ENOTSUP;
> +                               goto err_exit;
> +                       }
> +                       pf_func &= (0xfc00);
> +                       pf_func = (pf_func | (vf_id + 1));
> +                       req_act |= OTX2_FLOW_ACT_VF;
> +                       break;
> +
>                 case RTE_FLOW_ACTION_TYPE_QUEUE:
>                         /* Applicable only to ingress flow */
>                         act_q = (const struct rte_flow_action_queue *)
> --
> 2.27.0
>

  reply	other threads:[~2021-03-27 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 16:03 smadarf
2021-03-27 14:29 ` Jerin Jacob [this message]
2021-03-31 16:08   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1Pc5brpxJYEvwx_TX2incVP0_o8BRm1w93QQfCgYvYAig@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=guyk@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lironh@marvell.com \
    --cc=smadarf@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git