From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF3DA2F67 for ; Sat, 5 Oct 2019 17:28:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18D511C2B6; Sat, 5 Oct 2019 17:28:35 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 1C8F71C2B6 for ; Sat, 5 Oct 2019 17:28:33 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id q1so19960840ion.1 for ; Sat, 05 Oct 2019 08:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zu30fCuxmGXvmun2pzF6ucuz39M6AnOV0l+Sg7ZuVcs=; b=gVukXUIhIkQhQFWbX1J8GzEuBjfrpsobJafjsTZW3fNX8uFgNgMBacL3X/8lUJgR20 VlGZtxzRZyrh50aJ/OyWJ9IRbBrq01S9QL8l8VhHxEncPhtrDEv0pWNFgGdI6y8Pytrt WUvpouCJQd+81QQ8eUXb1xYo/hoxaT/IhtAd1yjPTA4LxroUaiSXo98w6t40wj40GpuE uZ2Nnxy0tpwDWgrTHttpy2VtcgldDGgFLCKWXLTRWX+lfkackqN7t63DZc/YOUSBEoZP WqqmooBsKEQpn+E3+2xuPSsD1K8Gl3CQB6kDRMDmRyOHTFBez+cwZwS0b2+2JWj6XS3h zJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zu30fCuxmGXvmun2pzF6ucuz39M6AnOV0l+Sg7ZuVcs=; b=idvaPudvAZx7L/3XCRkvrB0KN3poiQa/AWNtFQ/cYDWtuhsoIJZxopBu/Ek2cJbI43 UskudxBRClxJWy4DjQRTVaVLcpB8WkQPIgTIrpca5VEuhsKWQ+l9jSBSoGTz6REn9yk7 JDTlqlgo9msVcRC4ylfDvx4sK4hdrFQTyhZlkXqSrmNRXHKIKFK7fe1hZBp1iXwzJv6t WAv6ATymjsYR3kcHexHjWDLylLbu3K6kuPmDGuUs0MRKPd33M0HApHSIhJ9KswzO3tDE 1pW5Mxm4x1TubQmG/y91CTF3uHjL43ney3ji5lrpmLpQXNy4UCfg+qWW7A3mr9sLFI2u KPmQ== X-Gm-Message-State: APjAAAXcKOMGv/1krHAVnm1q1g1xS2j38vPg51Uddmd1w0lMzHd1WUz+ b8wSjmxs3kf3ziGRMGUBX8x88VCUShBQj+Qe8EI= X-Google-Smtp-Source: APXvYqyws+TUEBA98rxJemWnvuj2+RrEPzPuUL72IygaUeGdTmdaV8qS7HrrtpvmBy7YsCbOxuLq22puMHTzTPtr+bc= X-Received: by 2002:a6b:c895:: with SMTP id y143mr17694823iof.271.1570289312238; Sat, 05 Oct 2019 08:28:32 -0700 (PDT) MIME-Version: 1.0 References: <20191003225732.13463-1-dharmik.thakkar@arm.com> In-Reply-To: <20191003225732.13463-1-dharmik.thakkar@arm.com> From: Jerin Jacob Date: Sat, 5 Oct 2019 20:58:20 +0530 Message-ID: To: Dharmik Thakkar , Akhil Goyal , Hemant Agrawal , Thomas Monjalon , anoobj@marvell.com, pathreya@marvell.com Cc: Jerin Jacob , Bruce Richardson , dpdk-dev , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 4, 2019 at 4:27 AM Dharmik Thakkar wrote: > > Add new meson.build file for crypto/armv8 > > Signed-off-by: Dharmik Thakkar > --- > drivers/crypto/armv8/meson.build | 25 +++++++++++++++++++++++++ > drivers/crypto/meson.build | 6 +++--- > meson_options.txt | 2 ++ > 3 files changed, 30 insertions(+), 3 deletions(-) > create mode 100644 drivers/crypto/armv8/meson.build > > option('allow_invalid_socket_id', type: 'boolean', value: false, > description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly') > +option('armv8_crypto_dir', type: 'string', value: '', > + description: 'path to the armv8_crypto library installation directory') It is not specific to this patch but it is connected to this patch. Three years back when Cavium contributed to this driver the situation was different where only Cavium was contributing to DPDK and now we have multiple vendors from ARMv8 platform and ARM itself is contributing it. When it is submitted, I was not in favor of the external library. But various reasons it happened to be the external library where 90% meat in this library and shim PMD the driver moved to DPDK. Now, I look back, It does not make sense to the external library. Reasons are - It won't allow another ARMv8 player to contribute to this library as Marvell owns this repo and there is no upstreaming path to this library. - That made this library to not have 'any' change for the last three year and everyone have there owned copy of this driver. In fact the library was not compiling for last 2.5 years. - AES-NI case it makes sense to have an external library as it is a single vendor and it is not specific to DPDK. But in this, It is another way around - If it an external library, we might as well add the PMD code as well there and that only 10% of the real stuff. We are not able able to improve anything in this library due to this situation. Does anyone care about this PMD? If not, we might as well remove this DPDK and every vendor can manage the external library and external PMD(Situation won't change much) Thoughts from ARM, other ARMv8 vendors or community?