From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4192141C61; Fri, 10 Feb 2023 16:25:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CDE8410D3; Fri, 10 Feb 2023 16:25:14 +0100 (CET) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mails.dpdk.org (Postfix) with ESMTP id 7CD55410D0 for <dev@dpdk.org>; Fri, 10 Feb 2023 16:25:12 +0100 (CET) Received: by mail-vk1-f180.google.com with SMTP id b81so2813237vkf.1 for <dev@dpdk.org>; Fri, 10 Feb 2023 07:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HPgLrJqVW9VjLJS8j4cyJ22lxogNbfkVlqlYghnznZI=; b=bRg+dK9dsgof5ofU/h+eZHBWcBw04SdY4qQn+hkLy8Yl7iQhV+N/iAlSoW+/4gdYla GmFpXnVlTXHb1PWIN4xl05JGWE9cOoSJz3O2mFQqZfv6SDky2y8Xaw3SBzLnWsgDmiZx BLUvvMpbKbwAGfTGFPj8bK3JruvHasn7JHMUayI3OmEtYNqh3qQe56lhKuTUUPnhsk5t TUsf1H0j1hwmGpV/NKNE9dyroPtz00HT9/gilaUl608CJkSEnA/iHMr7WEJAkojr6UqP 7CvgF9ZqBepBKlmuKieBEh9A31adb11KjUsxn7NFkJEm4UYudF4lAXewmcD/K2TTmlN3 OU/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HPgLrJqVW9VjLJS8j4cyJ22lxogNbfkVlqlYghnznZI=; b=wm9kIRkHSlK3nltkrgszbbzVl/jl21XiWgv0gquUWnTURaYU8M2/kKet7zMjJ5P4GH SDr3c6uNIiow2jJNvql60GPiixJuHVbD+Bd4llaaYNAcL51R3XdRxJ8ophIb9EPOPUh5 7lOJNxbwzGH9lbQ2SnbPp2S43Ea/k6iUDErZvwae+x/N8gnG+KDHydavjkqlVedM/Qku 6rOE/zi30oh/L2OgnuDq4hlsUeaRQGFcZCYNWRn1xzqJ8U9lPnkynKtOUB8fJYPO7ygE YvY210/aZuEwbgLlTuHbzVE8uhdecT5xDS+rtsIL3rbLeXHcZx1hT5O4oIcst/L1TApG qdCg== X-Gm-Message-State: AO0yUKWFy8BfAH5fKG3XDcUowUSENz5aTNeFHha3XMsn8G7a6b3kngii lnO0P735YFb92KfSR1aaGxeX4RTqnYEoBNiNZJU= X-Google-Smtp-Source: AK7set+aWRjZdo8vipa2SvOV3tWxNO/t7/PvoiU981PgyUBE/ASkmsUd9hD1jYLs7rWHJyATzQmEj3SIQiqfI7M1TEU= X-Received: by 2002:a05:6122:14a2:b0:3ea:4be1:4a72 with SMTP id c2-20020a05612214a200b003ea4be14a72mr3141121vkq.20.1676042711820; Fri, 10 Feb 2023 07:25:11 -0800 (PST) MIME-Version: 1.0 References: <20230210045816.3039312-1-s.v.naga.harish.k@intel.com> <20230210134646.3407253-1-s.v.naga.harish.k@intel.com> <20230210134646.3407253-2-s.v.naga.harish.k@intel.com> <CALBAE1NK=yRC8eUvC_dWSt50avkVi4jWNZ0nxpbygaOXYB6UeQ@mail.gmail.com> <DM6PR11MB3868AFE1689C458944E31F8EA1DE9@DM6PR11MB3868.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB3868AFE1689C458944E31F8EA1DE9@DM6PR11MB3868.namprd11.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Fri, 10 Feb 2023 20:54:45 +0530 Message-ID: <CALBAE1PenwGp+nkPJ7Y1CCRwz3Up+NJFA+biSHJ4YWohnnS1Bw@mail.gmail.com> Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com> Cc: "jerinj@marvell.com" <jerinj@marvell.com>, "Carrillo, Erik G" <erik.g.carrillo@intel.com>, "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com> Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 8:32 PM Naga Harish K, S V <s.v.naga.harish.k@intel.com> wrote: > > > > > -----Original Message----- > > From: Jerin Jacob <jerinjacobk@gmail.com> > > Sent: Friday, February 10, 2023 7:36 PM > > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > > Cc: jerinj@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar, > > Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org; > > Jayatheerthan, Jay <jay.jayatheerthan@intel.com> > > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs > > > > On Fri, Feb 10, 2023 at 7:17 PM Naga Harish K S V > > <s.v.naga.harish.k@intel.com> wrote: > > > > > > The adapter runtime configuration parameters defined in the struct > > > rte_event_eth_tx_adapter_runtime_params can be configured and > > > retrieved using rte_event_eth_tx_adapter_runtime_params_set and > > rte_event_eth_tx_adapter_runtime_params_set() > > > > > rte_event_eth_tx_adapter_runtime_params_get respectively. > > > > rte_event_eth_tx_adapter_runtime_params_get() > > > > > > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> > > > > Not relevent any more. Use > > rte_event_eth_tx_adapter_runtime_params_init(). > > i.e This sentence can be removed. > > > > > > > + * modify the required parameters and then call > > > + * rte_event_eth_tx_adapter_runtime_params_set(). > > > > > > > > > + * > > > + * This API is to be used after adding at least one queue to the > > > + adapter > > > + * and is supported only for service based adapter. > > > > This paragraph we can removed here as it is not generic API description. > > > > This sequence is still needed as the "max_nb_tx" parameter of the adapter is configured A specific parameter specific constrain can go in the parameter Doxygen comments. i.e comment for "max_nb_tx" parameter. > during the addition of first queue to the adapter with the default value. If params_set() is > called before adding the first queue, the params of the adapter will be overwritten to the > default value later during the first queue add.