From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5B73A034F; Mon, 19 Jul 2021 15:37:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2D1C4014E; Mon, 19 Jul 2021 15:37:12 +0200 (CEST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 3EA864003E for ; Mon, 19 Jul 2021 15:37:11 +0200 (CEST) Received: by mail-io1-f43.google.com with SMTP id z11so20023645iow.0 for ; Mon, 19 Jul 2021 06:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HQrzLukhDPnjfy0MTk0s2txM47NPP217lJhbdLIUPuE=; b=W3n0kaLL8FewcLvBhpeBx8VkuLfYpSqgpwN7tNpW4JUtj8+tuaXJ9uxlCAe7h4g1tp /gepNGwaIZNzfwo7nF/avvFOdM2X4roOr2VstK//Btx9fkyuZmK4FC6iue1EIa2q2Ioo cnPcAvS+wJwl8N0os0GGNE2Wqofvzpj6iFdz5NV/usT9ZMURHUHpnWkckNc8yQFeVw5D S8MNsLIIDe6kevu4AhVwLYpxT5Mr33eY7/qATJaAi/NuwodFFW0IGgVD6bR7EhS3ct+C r88vop4DbiP20v+miSvkPjRuIdJUBWwaRB3STnzHK1jK0MN9Guaq2lcA75K8fsZ+r8EB jV8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HQrzLukhDPnjfy0MTk0s2txM47NPP217lJhbdLIUPuE=; b=NxEc5ZBXeNaB4P717n/u6+uK56MSHwYnGUZXkJ4flJ3A+4gO9G0+EPzYnlHVMLzJj9 DLOFPkf1EtHg6leUv1azhPwQKmOrhDC1oclwy3jwBqJkV0LjWFMx947n9XNGYq+GoOS3 +itqPD5LpuL4iVCMzD33tot+4942sO/1Keg+p7FHAR65ijpKcwQi3+rZo0mhP7wbCz2F LLUd/Zd8X8gqae4c215QKJoOTbWru+O4o7lp32zTHz06q/tCzsqcaIgD+cJvtNcYWFsz oM2Gc5UZVA6dJWcMDiVAkm+C4wZ7ZDQL1v68TDFm0P+X6C48c7T9Her7YCivazkRVTeG nQuQ== X-Gm-Message-State: AOAM531DVdgN9pQ81LKQsxoBLfeEv0wMR9ww0x2VlTTM/eJlSusapXPc ppHdJJ/KyaG9484S5zDx3HVOHtkJ5LFruG2sy/s= X-Google-Smtp-Source: ABdhPJxzbE1oLgDRrlSzdluxKUB3iXRSNVaKLSIvzVitKrIboc9ADANwOiJxnvP71VqKXjq8swaQbmL0BQINzMlsa4Q= X-Received: by 2002:a6b:d20c:: with SMTP id q12mr18562511iob.59.1626701830646; Mon, 19 Jul 2021 06:37:10 -0700 (PDT) MIME-Version: 1.0 References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1626665358-48826-1-git-send-email-fengchengwen@huawei.com> In-Reply-To: From: Jerin Jacob Date: Mon, 19 Jul 2021 19:06:43 +0530 Message-ID: To: fengchengwen Cc: Thomas Monjalon , Ferruh Yigit , "Richardson, Bruce" , Jerin Jacob , Andrew Rybchenko , dpdk-dev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Nipun Gupta , Hemant Agrawal , Maxime Coquelin , Honnappa Nagarahalli , David Marchand , Satananda Burla , Prasun Kapoor , "Ananyev, Konstantin" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 19, 2021 at 6:50 PM fengchengwen wrote: > > Many thank. > > Most of the comment fixed in v7, and v7 still include implementation. Changes good to me. > > I did a thorough test of the implementation, so could you please review > the implementation also ? Wiil do > > One comment is modified as follows: > COMMENT: > >> + * | | | ------------------ > >> + * | |DMA| | | ------ > >> + * | | | | |--------| EP | > >> + * | | |--------| PCIE Core2 | ------ > >> + * | | | | | ------ > >> + * | | | | |--------| EP | > >> + * | | | | | ------ > >> + * | ----- ------------------ > > > > > > This diagram does not show correctly in doxygen. Please fix it. > > REPLY: I can't find the right way to show it as correctly except split them to two > part (one with doxygen format, and the other not), so if you have a good idea, > please let me know, thanks. Use \code{.unparsed} \endcode diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 1518187c1e..df2d9f975c 100644 --- a/lib/dmadev/rte_dmadev.h +++ b/lib/dmadev/rte_dmadev.h @@ -463,12 +463,14 @@ struct rte_dmadev_port_param { * @see enum rte_dmadev_port_type */ union { - /* The following model shows SoC's PCIe module connects to + /** + * The following model shows SoC's PCIe module connects to * multiple PCIe hosts and multiple endpoints. The PCIe module * has an integrate DMA controller. integrate -> integrated * If the DMA wants to access the memory of host A, it can be * initiated by PF1 in core0, or by VF0 of PF0 in core0. * + * \code{.unparsed} * System Bus * | ----------PCIe module---------- * | Bus @@ -499,8 +501,9 @@ struct rte_dmadev_port_param { * | | | | |--------| EP | * | | | | | ------ * | ----- ------------------ - */ - /** The following structure is used to describe the PCIe access + * \endcode + * + * The following structure is used to describe the PCIe access * port parameters. * * @note If some fields can not be supported by the [main]dell[dpdk.org] > > On 2021/7/19 14:21, Jerin Jacob wrote: > > On Mon, Jul 19, 2021 at 9:02 AM Chengwen Feng wrote: > >> > >> This patch introduce 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of dmadev library exposes some generic operations which can > >> enable configuration and I/O with the DMA devices. > >> > >> Signed-off-by: Chengwen Feng > > > > > > The API specification aspects look pretty good to me. > > > > Some minor comments are below. You can add my Acked by on future version > > API header file where you will split the patch. > > > > [snip] >