From: Jerin Jacob <jerinjacobk@gmail.com>
To: Phil Yang <Phil.Yang@arm.com>
Cc: "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: use c11 atomics for statistics
Date: Sat, 4 Apr 2020 22:09:01 +0530 [thread overview]
Message-ID: <CALBAE1PfuZ9uY6F7EZ+mX6oKH9r91ewxXz6w6vby1P6i+jABBg@mail.gmail.com> (raw)
In-Reply-To: <VE1PR08MB464085320F9D499D4F1F6060E9CB0@VE1PR08MB4640.eurprd08.prod.outlook.com>
On Mon, Mar 30, 2020 at 11:56 AM Phil Yang <Phil.Yang@arm.com> wrote:
> > if (flags & OTX2_TIM_ENA_STATS)
> > - rte_atomic64_add(&tim_ring->arm_cnt, index);
> > + __atomic_fetch_add(&tim_ring->arm_cnt, index,
> > __ATOMIC_RELAXED);
> >
> > return index;
> > }
> > @@ -130,7 +130,8 @@ tim_timer_arm_tmo_brst(const struct
> > rte_event_timer_adapter *adptr,
> > break;
> > }
> > if (flags & OTX2_TIM_ENA_STATS)
> > - rte_atomic64_add(&tim_ring->arm_cnt, set_timers);
> > + __atomic_fetch_add(&tim_ring->arm_cnt, set_timers,
> > + __ATOMIC_RELAXED);
> >
> > return set_timers;
> > }
> > --
> > 2.17.1
>
> It goods good to me.
>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
Applied to dpdk-next-eventdev/master. Thanks.
>
> Thanks,
> Phil
prev parent reply other threads:[~2020-04-04 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:55 pbhagavatula
2020-03-30 6:25 ` Phil Yang
2020-04-04 16:39 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PfuZ9uY6F7EZ+mX6oKH9r91ewxXz6w6vby1P6i+jABBg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).