DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	 Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
Date: Mon, 27 Apr 2020 23:32:38 +0530
Message-ID: <CALBAE1PgRLWvcJmNdtR27AiWQP7ChsACOOpOMF3DFd-gRxRoPw@mail.gmail.com> (raw)
In-Reply-To: <2638871.7x91mkYCy2@thomas>

On Mon, Apr 27, 2020 at 1:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 26/04/2020 20:48, Jerin Jacob:
> > On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 26/04/2020 19:42, Jerin Jacob:
> > > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > 06/02/2020 15:36, Jerin Jacob:
> > > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > > > >
> > > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > > > > to scroll the screen to find other issues in boot-up.
> > > > > > > >
> > > > > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > > > > to reduce the clutter on default boot-up logs
> > > > > > >
> > > > > > > I think the PCI probe informations are... informational.
> > > > > > > Maybe you are just not interested in info logs.
> > > > > > > If this is the case, I suggest to change the log level at runtime.
> > > > > >
> > > > > > I am wondering, what would be the right balance, Following is DPDK
> > > > > > startup output from octeontx2[1]
> > > > > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > > > > below prints using log level at runtime?
> > > > > > I believe it comes as a debug category, i.e information required to
> > > > > > debug if something is not working,
> > > > > > dpdk bind script already lists what is bound to DPDK.
> > > > > >
> > > > > > Suggestion to remove clutter?
> > > > >
> > > > > I suggest using dynamic log level in the PCI driver.
> > > > > Unfortunately a lot of old DPDK code is still using the old log macros.
> > > > > Some cleanup work is needed here.
> > > >
> > > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
> > >
> > > No, a PCI PMD can work without a known kernel driver.
> > > This is the case of mlx4/mlx5.
> >
> > Yes. it can work with UNKNOWN, But It not with NONE.
> >
> > > > I think that is the source of the problem.
> > > > http://patches.dpdk.org/patch/69351/
> > >
> > > The source of the problem is just changing log levels dynamically
> > > is not possible currently with PCI driver logs.
> >
> > Assuming if we add, dynamic stuff what would the default log level for
> > RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >
> > If it is INFO, Still the problem persist in the default bootup. Right?
>
> Yes
>
> We need to know in INFO level which devices are successfully probed.
> You want to decrease to DEBUG the level of logs announcing a probe.
> I think it would be OK if adding an INFO log after probe success.

OK. I will send the v2 by changing the existing one as DEBUG and a
successful probe as INFO.



>
>
>

  reply	other threads:[~2020-04-27 18:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  8:00 jerinj
2020-02-06 14:14 ` Thomas Monjalon
2020-02-06 14:36   ` Jerin Jacob
2020-04-25 20:12     ` Thomas Monjalon
2020-04-26 17:42       ` Jerin Jacob
2020-04-26 18:06         ` Thomas Monjalon
2020-04-26 18:48           ` Jerin Jacob
2020-04-26 19:56             ` Thomas Monjalon
2020-04-27 18:02               ` Jerin Jacob [this message]
2020-05-04 13:26 ` [dpdk-dev] [PATCH v2] " jerinj
2020-05-07 13:54   ` Jerin Jacob
2020-05-07 15:36     ` Thomas Monjalon
2020-05-11 14:39       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1PgRLWvcJmNdtR27AiWQP7ChsACOOpOMF3DFd-gRxRoPw@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git