From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D55242988; Wed, 19 Apr 2023 12:15:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2324E40A79; Wed, 19 Apr 2023 12:15:56 +0200 (CEST) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by mails.dpdk.org (Postfix) with ESMTP id 01B534021F for ; Wed, 19 Apr 2023 12:15:54 +0200 (CEST) Received: by mail-vs1-f45.google.com with SMTP id u12so2054308vst.11 for ; Wed, 19 Apr 2023 03:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681899354; x=1684491354; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=31eC+6Pn5isFmGkqS4pFaS9GBa3ucHbN8N+ZsL6H/aA=; b=i+8slEKJse+co3D0fzs/CC5igY9z67sxqKqv8lA4FcOMye09wvgsopohH8ftYtw6vX xZEM40pb9z9z8z1RFumm6s3clQ5VuS9KRZPpPCuQgz5MmgVhaHNBwobAjnirc7Y3hB6U x6UZEtzPv88Hv/rL3QHBGkbWTUxuq65iO3wNX4SAUD8eB6NQdwWGdjCFh32Y+c1lyebL qZyoq3EkoI6G5fdbBxoIM6fvo6ueSRKxEAlT92D+K9lJKYlXiKYlEpBJRLTBqTzJXvHl g7ka9T1juB3QvB/oZ/jIo1W//VwTd0tAvcuFPUAdbIPcHl7xuddLyhzKAqrY61NYI/L7 waUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681899354; x=1684491354; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31eC+6Pn5isFmGkqS4pFaS9GBa3ucHbN8N+ZsL6H/aA=; b=ADwgRhMaunEsxxl6z/vcs4kRI8EMJGKr+a8xsZcjPqNmz9o/Wy+KQ+0HgV+ZqNez4P LSvmGDiaI/VUSDFh6xzbWGKUQDVZgCs23ulHCxNNPYSj4IadEE1VJlUPaFma33nLeQvb ocN/rBnWfK9VWZvdsoU33PLu6NWwlVPxEKdhSoBv+T6jJdp5FriZ4ww2ZBOS+N8rHyTH kKkR+oFNUi1keKI+sBYXIxhiHZcsQ0H9K/Q8c90TCqXXf3MTFqzpmCPyGEJZXqBQbFN0 yBdyLUgLmdh8n7FaxJRkInLvOonGlXCOhVrvu+loowukwsAAZ8FtZ243+fMuz3RMWGLQ LLzw== X-Gm-Message-State: AAQBX9cZckj4yQ+uvtHXVeV5MFeCDq29CeweLwAf30ViBYDzce+bCEry PLloCLmTlXYfsZ2TfTSvEL+at8zTxKJGidIoB7I= X-Google-Smtp-Source: AKy350YbHNMemK4v3ArK2JmFuNMBO+d235koaruVjEe8WQ59RJUeap3bcRykhO5iuQJDctbF88DkPHIDWTnitJpjeIM= X-Received: by 2002:a05:6102:134f:b0:42f:e8bb:5882 with SMTP id j15-20020a056102134f00b0042fe8bb5882mr3896122vsl.19.1681899354290; Wed, 19 Apr 2023 03:15:54 -0700 (PDT) MIME-Version: 1.0 References: <20230419095427.563185-1-sivaprasad.tummala@amd.com> In-Reply-To: <20230419095427.563185-1-sivaprasad.tummala@amd.com> From: Jerin Jacob Date: Wed, 19 Apr 2023 15:45:28 +0530 Message-ID: Subject: Re: [RFC PATCH 1/5] eventdev: add power monitoring API on event port To: Sivaprasad Tummala Cc: david.hunt@intel.com, jerinj@marvell.com, harry.van.haaren@intel.com, dev@dpdk.org, Pavan Nikhilesh , "McDaniel, Timothy" , Shijith Thotton , Hemant Agrawal , Sachin Saxena , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Peter Mccarthy , Liang Ma Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 19, 2023 at 3:24=E2=80=AFPM Sivaprasad Tummala wrote: > > A new API to allow power monitoring condition on event port to > optimize power when no events are arriving on an event port for > the worker core to process in an eventdev based pipelined application. > > Signed-off-by: Sivaprasad Tummala > + * > + * @param dev_id > + * Eventdev id > + * @param port_id > + * Eventdev port id > + * @param pmc > + * The pointer to power-optimized monitoring condition structure. > + * > + * @return > + * - 0: Success. > + * -ENOTSUP: Operation not supported. > + * -EINVAL: Invalid parameters. > + * -ENODEV: Invalid device ID. > + */ > +__rte_experimental > +int > +rte_event_port_get_monitor_addr(uint8_t dev_id, uint8_t port_id, > + struct rte_power_monitor_cond *pmc); + eventdev driver maintainers I think, we don't need to expose this application due to applications 1)To make applications to be transparent whether power saving is enabled or= not? 2)Some HW and Arch already supports power managent in driver and in HW (Not using CPU architecture directly) If so, that will be translated to following, a) Add rte_event_port_power_saving_ena_dis(uint8_t dev_id, uint8_t port_id, bool ena) for controlling power saving in slowpath. b) Create reusable PMD private function based on the CPU architecture power saving primitive to cover the PMD don't have native power saving support. c)Update rte_event_dequeue_burst() burst of PMD callback to use (b). > + > /** > * Start an event device. > * > -- > 2.34.1 >