From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A97E3A0032; Thu, 12 May 2022 13:03:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 316C640E64; Thu, 12 May 2022 13:03:34 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id AA7FE4014F for ; Thu, 12 May 2022 13:03:32 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id z26so4871587iot.8 for ; Thu, 12 May 2022 04:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=juG+jR/0TTNNhaqY2x/KGqFj7LJ7CjdJGqgaVIHqYTY=; b=Vk8Z/ceGIroby2qsBc9y7MyIIQ8tH7GHIKKGj4umNl2rKJ1VMRgcZ+VYMAeAvw+2pL QfPRCCtgRicDGzwrWi1OzxCqvP3Nxk0wxK5DAIvdqkUIKw5McmWhjo35Kq+L6a4DsoOb /2+eC9dYuAfLoctRA1zWNxcvXMc0CUpOKj3mUYP/n2X/p3RajRT5uByZyTZwTwDWnVV+ S5NGiR7g/b6cevkkdkFWNAcp9tAQcVVAbaeROUjm7g0F84SKDWMF1BkPFX56ubpXikGa SK5nofAoLVDSEYYoPfEL6I8jqmsEfpqgbXYTilDbMtV3b8v9sqPQOoNik6EpFk1iCsvX tsSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=juG+jR/0TTNNhaqY2x/KGqFj7LJ7CjdJGqgaVIHqYTY=; b=yU4CWLbbMg3/3Y6VIbvRauDMQdaXe8yQ354glP3ol/qkCtczNM2pj6Y+wuYRgUNmqT 8xlZDw9HovC2G8grlffx7WDa66fUz2olFhQVOQ5HtPoVrSU0dY8LcwS1dr4H6IYzTang UqppQYXiEuznKvHNgiGXGa9ZjbirCc5+AVgI911lc7hxkdmg2+DaZU0gT9FY83TD+bHq 5pxz80fDsLlotlh/cs72rpkSwshd89NMaMpwWRXC85Qlmc1F4A+X4jitJgo5od7FnbT9 0ih7aaLyUZrwrK1Vy23ubbbfvAVvNuZ6RzcGOhvPCrUHnAj0jD9nhjaddhj8wOevDG/e TL6w== X-Gm-Message-State: AOAM532ScjdLyQQV1RArvnXUW6LEfj4F492kwQqoceBUN9E2K7JR2BvM NUiSFJjKT7WywQNVNBTA+Rxpt+nddha5V4lWtt0= X-Google-Smtp-Source: ABdhPJy5QJnlLwTV1Co7VKeYI9NqUnyqiemohrOIHTjME1DTaar/hcBTfiKRzoVFqByxKOE/v21TY5AaOLqaQE74zPM= X-Received: by 2002:a05:6638:468e:b0:32b:fe24:906a with SMTP id bq14-20020a056638468e00b0032bfe24906amr9615895jab.123.1652353411924; Thu, 12 May 2022 04:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20220421180241.514767-1-jerinj@marvell.com> <20220501144637.3757757-1-jerinj@marvell.com> <7ee66146-93e1-36c6-7954-b498af8a1ec8@oktetlabs.ru> In-Reply-To: <7ee66146-93e1-36c6-7954-b498af8a1ec8@oktetlabs.ru> From: Jerin Jacob Date: Thu, 12 May 2022 16:33:05 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection To: Andrew Rybchenko Cc: Jerin Jacob , dpdk-dev , Cristian Dumitrescu , Thomas Monjalon , Ray Kinsella , Ferruh Yigit , Ajit Khaparde , Andrew Boyer , Beilei Xing , "Richardson, Bruce" , Chas Williams , "Xia, Chenbo" , Ciara Loftus , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Gaetan Rivet , Gagandeep Singh , Guoyang Zhou , Haiyue Wang , Harman Kalra , heinrich.kuhn@corigine.com, Hemant Agrawal , Hyong Youb Kim , Igor Chauskin , Igor Russkikh , Jakub Grajciar , Jasvinder Singh , Jian Wang , Jiawen Wu , Jingjing Wu , John Daley , John Miller , "John W. Linville" , "Wiles, Keith" , Kiran Kumar K , Lijun Ou , Liron Himi , Long Li , Marcin Wojtas , Martin Spinler , Matan Azrad , Matt Peters , Maxime Coquelin , Michal Krawczyk , "Min Hu (Connor" , Pradeep Kumar Nalla , Nithin Dabilpuram , Qiming Yang , Qi Zhang , Radha Mohan Chintakuntla , Rahul Lakkireddy , Rasesh Mody , Rosen Xu , Sachin Saxena , Satha Koteswara Rao Kottidi , Shahed Shaikh , Shai Brandes , Shepard Siegel , Somalapuram Amaranath , Somnath Kotur , Stephen Hemminger , Steven Webster , Sunil Kumar Kori , Tetsuya Mukawa , Veerasenareddy Burru , Viacheslav Ovsiienko , Xiao Wang , Xiaoyun Wang , Yisen Zhuang , Yong Wang , Ziyang Xuan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 12, 2022 at 1:06 PM Andrew Rybchenko wrote: > > Hi Jerin, Hi Andrew, > > On 5/1/22 17:46, jerinj@marvell.com wrote: > > From: Jerin Jacob > > > > Currently, meter object supports only DSCP based on input color table, > > The patch enhance that to support VLAN based input color table, > > color table based on inner field for the tunnel use case, and > > support for fallback color per meter if packet based on a different field. > > > > All of the above features are exposed through capability and added > > additional capability to specify the implementation supports > > more than one input color table per ethdev port. > > > > Suggested-by: Cristian Dumitrescu > > Signed-off-by: Jerin Jacob > > the patch LGTM, but I have a couple of questions to clarify: > > 1. Will we have API usage patches in the release cycle (I guess > testpmd)? > > 2. Will we have net driver patches which add support for > new driver callbacks and advertise added capabilities? Yes. Both will be there for this release. Most likely post rc1. We have testpmd, cnxk driver changes for the v1 version of the spec[1]. We will update both for the latest spec version.(We just awaiting for spec to merge) [1] https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-3-skori@marvell.com/ https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-2-skori@marvell.com/ > > Thanks, > Andrew.