From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion
Date: Fri, 13 Sep 2019 20:10:13 +0530 [thread overview]
Message-ID: <CALBAE1PjEEToAa2+JD5VpRb96Z_KWQ8Z9CdniY99gJbKKfTYNQ@mail.gmail.com> (raw)
In-Reply-To: <20190816041955.69877-1-ndabilpuram@marvell.com>
On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> This patch fixes configuration for port Tx vlan insertion feature.
> As per latest Tx KEX profile, pf_func should be at
> KW[0](47:32) and not KW[1](63:48).
>
> Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions")
> Cc: kirankumark@marvell.com
Cc: stable@dpdk.org
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/net/octeontx2/otx2_vlan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_vlan.c b/drivers/net/octeontx2/otx2_vlan.c
> index c01089b..2be7671 100644
> --- a/drivers/net/octeontx2/otx2_vlan.c
> +++ b/drivers/net/octeontx2/otx2_vlan.c
> @@ -468,9 +468,9 @@ nix_vlan_handle_default_tx_entry(struct rte_eth_dev *eth_dev,
> pf_func = (dev->pf_func & 0xff) << 8;
> pf_func |= (dev->pf_func >> 8) & 0xff;
>
> - /* PF Func extracted to KW1[63:48] */
> - entry.kw[1] = (uint64_t)pf_func << 48;
> - entry.kw_mask[1] = (BIT_ULL(16) - 1) << 48;
> + /* PF Func extracted to KW1[47:32] */
> + entry.kw[0] = (uint64_t)pf_func << 32;
> + entry.kw_mask[0] = (BIT_ULL(16) - 1) << 32;
>
> nix_set_tx_vlan_action(&entry, type, vtag_index);
> vlan->def_tx_mcam_ent = entry;
> --
> 2.8.4
>
next prev parent reply other threads:[~2019-09-13 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 4:19 Nithin Dabilpuram
2019-09-13 14:40 ` Jerin Jacob [this message]
2019-09-23 8:00 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PjEEToAa2+JD5VpRb96Z_KWQ8Z9CdniY99gJbKKfTYNQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).